July 2022 - Koha-bugs - lists.koha-community.org

[Bug 30801] New: OPAC and staff interface show 856 as link even if there is no $u (MARC21)
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '22

07 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30801 Bug ID: 30801 Summary: OPAC and staff interface show 856 as link even if there is no $u (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org Hi everyone, If any 856 subfield is filled, the OPAC and staff interface show that information as a link (blue text, clickable, etc.) and uses the content of $u as the href. Which is OK. However, if there is no $u, the other subfields still appear as links. Cases where the electronic resource is a file that is not online would not have a $u. I'm no cataloging expert, but I think only $u and $y (and maybe $a/$d/$f but I'm not knowledgable enough about those subfields to say for sure) should appear as a link and the rest should be regular text. Test plan: 1- Create a record 2- Fill in the required fields 3- In 856, fill in $3 with 'In-library access only' 4- Save 5- Click on 'Normal' to view the record Note that the text from 856$3 is a link, if you try clicking on it, nothing happens 6- Click on the OPAC view link Note that the text from 856$3 is a link, if you try clicking on it, nothing happens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 25220] New: maxoutstanding syspref should be disabled by a null value
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220 Bug ID: 25220 Summary: maxoutstanding syspref should be disabled by a null value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Several fines-related system preferences (OPACFineNoRenewals, noissuescharge, etc) can be disabled by leaving them blank. But maxoutstanding treats a blank as a zero, blocking OPAC holds for *any* fine balance. I'd like this to change to match the functionality of the other sysprefs. If nothing else, we should add some language to say a blank is treated as a zero. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 14564] Incorrect permissions prevent web download of configuration backups
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31098 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31110] New: Use `_should_be_fk` for ReturnClaim in TestBuilder
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110 Bug ID: 31110 Summary: Use `_should_be_fk` for ReturnClaim in TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 29495 In bug 29495 we added a follow-up to fix the TestBuilder test. However, we added the change to the wrong place; Instead of forcing undefined in the test data and not creating a link, we should add the field lacking a proper foreign key to the list in _should_be_fk These are deliberately not foreign keys because they link to one of two tables.. the original and old_ version tables.. but we do add dbix::class relations for the link. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137208|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137234&action=e… Bug 15187: (QA follow-up) Add unit test This patch adds a unit test for the newly introduced filter. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137207|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137233&action=e… Bug 15187: Index 880 in Zebra the same as Elasticsearch This patch modifies the MARC21 export to Zebra, so that 880 fields are rewritten as their linked fields, in the same way that we already do with Elasticsearch, so that the alternate graphic representation of fields are indexed accordingly. (ie 880 $6245-01 Chinese titles will be indexed into the title index using the 245 rules) Test plan: 0. Apply patch 1. Turn on ICU indexing 1b. vi /etc/koha/zebradb/etc/default.idx 1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml 1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml 1e. Restart Zebra server 1f. Re-index Zebra 2. Add record with a 880 $6 245-01 $a 教牧書信 field. 3. Search for this record using a title index with the Chinese title 4. Note that the record is correctly retrieved (Note: This test probably works better using author or series as they present as links on the detail page which makes the fix more obviously useful.) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29495] New: Issue link is lost in return claims when using 'MarkLostItemsAsReturned'
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Bug ID: 29495 Summary: Issue link is lost in return claims when using 'MarkLostItemsAsReturned' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We have a foreign key constraint in return_claims for issue_id.. this means that if you have 'MarkLostItemsAsReturned' enabled, we first add the issue_id linking to the original checkout, then immediately move the checkout to old_issues and nuke the issue_id from the claims_return table :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 104

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I added a unit test for you to get this through QA.. Tomas may want to rename the filter at push.. I couldn't come up with a nicer name.. but I don't really like they we call out it's a Zebra thing... What I've not managed to test.. does this cause any issues with non-icu indexed Koha's.. I imagine not as you are unlikely to have such a field in your database in the first place without having enabled ICU (all our customers are ICU by default in case). Passing QA.. scripts are happy, we're now covered by tests and it's a great improvement. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 --- Comment #24 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137208&action=e… Bug 15187: (QA follow-up) Add unit test This patch adds a unit test for the newly introduced filter. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts
by bugzilla-daemon＠bugs.koha-community.org 06 Jul '22

06 Jul '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137050|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 137207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137207&action=e… Bug 15187: Index 880 in Zebra the same as Elasticsearch This patch modifies the MARC21 export to Zebra, so that 880 fields are rewritten as their linked fields, in the same way that we already do with Elasticsearch, so that the alternate graphic representation of fields are indexed accordingly. (ie 880 $6245-01 Chinese titles will be indexed into the title index using the 245 rules) Test plan: 0. Apply patch 1. Turn on ICU indexing 1b. vi /etc/koha/zebradb/etc/default.idx 1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml 1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml 1e. Restart Zebra server 1f. Re-index Zebra 2. Add record with a 880 $6 245-01 $a 教牧書信 field. 3. Search for this record using a title index with the Chinese title 4. Note that the record is correctly retrieved (Note: This test probably works better using author or series as they present as links on the detail page which makes the fix more obviously useful.) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0