January 2023 - Koha-bugs - lists.koha-community.org

[Bug 24359] New: Remove items from Holds Queue when checked in
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Bug ID: 24359 Summary: Remove items from Holds Queue when checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently, if an item is checked in and the hold is triggered/captured, the item will not come off the holds queue until the the cronjob runs again. This causes some confusion for multibranch systems when other branches attempt to fill holds that have already been filled. Proposal: Remove bib/items from the Holds Queue after checkin and before the next holds queue cron runs to update the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 31735] New: Circulation optimizations
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Bug ID: 31735 Summary: Circulation optimizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We recently had time-out issues and high server loads for patrons with high checkout counts (some patrons have several hundreds, up to about 400). One of the major bottlenecks turned out to be C4::Circulation::CanBookBeRenewed. The primary reason it performed so poorly was constant re-fetching of different database entities which could just as well be passed down directly instead of passing ids which requires re-fetching further down the call stack. After refactoring the most performance critical subroutines to take objects instead of object ids the calls to expensive DBIx-methods has been greatly reduced. In addition some other optimizations and bug fixes related to non working caching resulted in further speedups. The performance gain for a patron with around 400 checkouts is currently about 500%. I made an effort to fix all tests affected by the changes, but I can not guarantee there are absolutely no regressions left in the test-suite. Since many tests seem to fail due to reasons not related to this patch, mainly due to the state of my local instance triggering tests-bugs (for example caused by preferences not being mocked correctly, or relying on database test-entries that are not guaranteed to exist), it was impractical and very time consuming to make sure all tests still run successfully. So subset of tests where the changed subroutines are called directly was selected and these should now pass. The following tests should be effected by the changes and should be run as a part of the test-plan: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t The following still fails for me but should either work on a fresh Koha installation, or fail for unrelated reasons (that is they also fail in Koha master): t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Items.t t/db_dependent/SIP/ILS.t To be able to run t/db_dependent/Circulation.t in my Koha instance there where some existing bugs that needed fixing, so this patch have a dependency on Bug 31676. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 109

[Bug 15812] New: Checkout search with too many results (single character search) causes poor performance or timeout
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Bug ID: 15812 Summary: Checkout search with too many results (single character search) causes poor performance or timeout Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On a system with many patrons a checkout search for a single character (2,X,J) can cause a slow search or timeout from the large number of results returned. Patron search has no problem with the same searches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 74

[Bug 31453] New: Add ability to skip processing messages in message queue based on message contents
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Bug ID: 31453 Summary: Add ability to skip processing messages in message queue based on message contents Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz It would be very useful to be able to tell process_message_queue.pl to skip processing some messages. This is particularly useful where a plugin handles sending some message using the before_send_messages hook, but while that plugin is processing, more messages meant for the plugin might be queued. At that point, control moves back to the script and SendQueuedMessages is called, and those messages end up being processed there instead of by the plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 15701] New: Port Koha::Contrib::Tamil koha-cloud into Koha code base
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Bug ID: 15701 Summary: Port Koha::Contrib::Tamil koha-cloud into Koha code base Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Port Koha::Contrib::Tamil koha-cloud into Koha code base more info to come... -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15957] New: Move AO in Patron Status
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15957 Bug ID: 15957 Summary: Move AO in Patron Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 27881] New: Markup error in masthead-langmenu.inc
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug ID: 27881 Summary: Markup error in masthead-langmenu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20168 masthead-langmenu.inc has a few instances of this error: <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 15695] New: koha-plack script does not enable plack when plack has never been enabled
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Bug ID: 15695 Summary: koha-plack script does not enable plack when plack has never been enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: wwwretive(a)yahoo.fr QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Created attachment 47401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47401&action=ed… the patch for koha-plack script hello, When running koha-plack --enable, the script assumes that there is already a commented line that includes the plack configuration in the apache virtual host's config of the instance. The script would comment out the line : (from /usr/sbin/koha-plack line 148) : sed -i 's:^\s*#$\s*Include /etc/koha/apache-shared-opac-plack.conf$$:\1:' "$instancefile" sed -i 's:^\s*#$\s*Include /etc/koha/apache-shared-intranet-plack.conf$$:\1:' "$instancefile" For old fashioned installs there is no commented line that includes plack configuration, so the regular expression doesn't match and the script doesn't enable plack. In my config (we've set up koha 3 years ago) i had to add the plack-related line directly in the apache virtual host config. Since the included files use the ${instance} variable, i had to define that variable as well in my vhost config : Define instance myinstancename (the "Define" keyword is not well documented in the apache docs ; i used it because SetEnv didn't work). Instead of commenting out the (possibibly non-existent) plack related lines, it is possible to find where the "/etc/koha/apache-shared-{opac,intranet}.conf" files are included and add the two relevant lines. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15882] New: refactor C4::Log::GetLogs to accept DateTime
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '23

28 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15882 Bug ID: 15882 Summary: refactor C4::Log::GetLogs to accept DateTime Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org C4::Log::GetLogs accepts dates in the user interface format, which is bad for an internal module. Refactored to accept DateTimes so it can be used internally more easily. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15875] New: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '23

28 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Bug ID: 15875 Summary: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes.

1 5