November 2023 - Koha-bugs - lists.koha-community.org

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158289|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #35) > FIXED Serious omission: $confirm DOES NOT DO anything ! Blocker Well, not what I expected at least :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Squashed first 3 patches: Resolving: FAIL git manipulation The file has been added and deleted in the same patchset. Tidied a bit more. Follow-up: Renamed some vars. Removed unused $success. Extended die statement. Added Modern::Perl. FIXED Serious omission: $confirm DOES NOT DO anything ! Blocker TODO The expiration parameter is not tested in any way? Does not feel good. (No definitive blocker for me.) TODO If we added a debarment and run the script again, we will add another debarment. Please add a check. (Doubt if this is a blocker.) TODO We need a manual option like other scripts? No blocker for me. DONE We need a verbose parameter as Lucas mentioned. DONE If we do not confirm, I would expect to list patron info in verbose mode. DONE I would add a count at the end. May be no blocker, but generally expected. Please still add a follow-up or leave final decision to RM. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 158318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158318&action=e… Bug 15157: (QA follow-up) Some more changes Renamed some vars. Removed unused $success. Extended die statement. Added Modern::Perl. Added verbose parameter. Added some logic around the confirm parameter. Making it possible to run the script in 'dry' mode. Print totals at the end. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158292|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 158317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158317&action=e… Bug 15157: Add my $amount and fix options Variable my $amount was missing. Also option amount has to be declared as integer and option confirm is no longer string. Sponsored by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> [EDIT] Run perltidy to resolve one line. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158291|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 158316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158316&action=e… Bug 15157: (follow-up) Add ability to set lower limit Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158288|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 158315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158315&action=e… Bug 15157: Cronjob to debar Patrons with unpaid accountlines If your library wants to debar all Borrower who haven't paid their fines by the end of the year, this script will do that trick :) You can give the message from a file if the cronjob runner doesn't deal with quotes, or as a command-line parameter. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Bug 15157: Update script This patch updates debarrBorrowersWithFines.pl script to match changes made in bug 15156. To test: 1. Have patron(s) with unpaid fines 2. Run e.g debarrBorrowersWithFines.pl --confirm -m "This is a description of you bad deeds" (test other options too) 3. Confirm patron(s) with fines has been debarred with the explanation Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Bug 15157: Modernise and Update for bug 15156 This patch updates the script to use filter_by_amount_owed, renames it to debar_patrons_with_fines.pl and moves it to the cronjobs directory whilst also adding a copyright notice and POD. We could add a series of options to the script to allow more fine grained control. Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> [EDIT] Run perltidy to resolve three lines. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '23

03 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0