December 2023 - Koha-bugs - lists.koha-community.org

[Bug 29087] New: Holds to pull list can crash with a SQL::Abstract puke
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 Bug ID: 29087 Summary: Holds to pull list can crash with a SQL::Abstract puke Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Opening the holds to pull list page can crash with the following logged error: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -NOT IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /usr/share/koha/lib/Koha/Objects.pm line 145 I've traced this to Koha::Holds->get_items_that_can_fill(). Among other things, this routine fetches a list of item types that cannot fill holds, i.e., cases where the 'holdallowed' rule value is 'not_allowed'. However, if your default rule is to not allow holds, the @hold_not_allowed_itypes list will end up including an entry whose value is undef. When passed to the item query, doing the -not_in filter on itype will result in the crash listed above. A quick fix might be to filter out undef from that list. That will fix the crash, but could lead to incorrect results if the default policy is to deny holds for all item types except for ones that are going to be specifically permitted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 56

[Bug 33237] New: If TranslateNotices is off, use the interface language includes in slips
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33237 Bug ID: 33237 Summary: If TranslateNotices is off, use the interface language includes in slips Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Most of our clients use Koha in one language only (French) and their patrons are also all french-speakers. So they don't use TranslateNotices, since they don't need to print slips in different languages. However, if TranslateNotices is off, the translations for "includes" (in my specific example, account types), are not taken into consideration and print in English. Same if TranslateNotices is on, but the patron's language is Default. In those cases, shouldn't it use the interface language rather than just print in English? To replicate: 1. Install the other language (i used fr-CA here) 1.1. gulp po:update fr-CA ./misc/translator/translate install fr-CA 1.2. In Administration > Global system preferences, search for language and check the added language 2. Create a manual invoice in a patron's account and pay it 3. From the Transactions tab, click 'Print' next to the payment line --> On the printed slip, the title is "Payment receipt" (OK) 4. Switch interface to other language 5. Redo step 3 --> On the printed slip, the title is still "Payment receipt" (not ok) 6. In Administration > Global system preferences, enable TranslateNotices 7. Go to Tools > Notices and slips > ACCOUNT_CREDIT and copy the content of the letter into all the languages 8. Redo step 3 (you should still be in the other language interface) --> On the printed slip, the title is still "Payment receipt" (not ok?) 9. Edit the patron's account and change the preferred language to the other language 10. Redo step 3 --> On the printed slip, the title is "Paiement receipt" (OK) On step 3, the account type is in English in the English interface (OK) On step 5, the account type is in English in the other interface, with TranslateNotices off, I feel like the slip should take the interface into account in this case for the include... On step 8, TranslateNotices is on, but the patron's language is Default, I feel like this should also take into account the interface language... On step 10, TranslateNotices is on and patron language is set, these are currently the only settings which allow to have the accounttypes in the other language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 90

[Bug 34972] New: Canceling a waiting hold from the holds over tab can make the next hold unfillable
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Bug ID: 34972 Summary: Canceling a waiting hold from the holds over tab can make the next hold unfillable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When a staff member cancels a hold by clicking the button in the "holds waiting over 10 days" report, Koha incompletely attempts to assign that item to the next matching hold. Koha assigns the itemnumber to the hold, but does *not* set found status of the hold. Instead, it prompts the staff member, "Please retain this item and check it in to process the hold." This causes a few problems: - The itemnumber is immediately assigned to the hold without an opportunity for staff input, even if HoldsAutoFill is disabled. - If the staff member does not check in the book afterward (whether intentionally or through human error), it leaves the hold in an invalid state: it is tied to the itemnumber, but it is neither "found" nor an item-level hold. - Since the itemnumber is assigned, other items can't fill the hold. However, since the "found" field was never set, the option to "revert waiting status" or "revert transit status" isn't available. Essentially, a bib-level hold is suddenly behaving like an item-level hold, with no way for staff to identify or fix the issue. This is especially a problem if the item is missing from the holds shelf for some reason, and the staff member cancels the waiting hold first and then marks the item "lost". This makes the next-in-line hold unfillable unless the item is found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 52

[Bug 33832] New: Can't change a patron's username without entering passwords
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 Bug ID: 33832 Summary: Can't change a patron's username without entering passwords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In the staff interface, on the "Change password" page, it's not possible to update a patron's username without also entering password information. This is contrary to the help text, "Leave the field blank to leave password unchanged." As far as I can tell this bug goes back to at least 21.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 35548] New: Move KitchenSink test on its own and control table creation
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35548 Bug ID: 35548 Summary: Move KitchenSink test on its own and control table creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org See bug 35507. Since KitchenSink contains CREATE TABLE, it commits cruft into db. Lets control that a bit more. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 35507] New: TestBuilder.t is failing randomly
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Bug ID: 35507 Summary: TestBuilder.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org koha_1 | # Failed test 'No encoding warnings!' koha_1 | # at t/db_dependent/TestBuilder.t line 519. koha_1 | # found warning: Failed to load Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at /kohadevbox/koha/Koha/Plugins.pm line 124. koha_1 | # didn't expect to find a warning koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'build_sample_biblio() tests' koha_1 | # at t/db_dependent/TestBuilder.t line 523. Has been failing on Koha_Master/2759 but fixed in 2760. The output is full of Failed to load Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at /kohadevbox/koha/Koha/Plugins.pm line 124. -- You are receiving this mail because: You are watching all bug changes.

1 86

[Bug 35536] New: Improve cleanup/uninstall of Koha plugins
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Bug ID: 35536 Summary: Improve cleanup/uninstall of Koha plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org See bug 35507 comment10 a.o. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 92

[Bug 35329] New: Move patron searches to a modal
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Bug ID: 35329 Summary: Move patron searches to a modal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The patron searches are made in a popup window, we should move it to a modal: 1. More friendly for end users 2. Will be able to test correctly from cypress 3. Easier to maintain (code will be less ugly). -- You are receiving this mail because: You are watching all bug changes.

1 202

[Bug 34647] New: name attribute is obsolete in anchor tag
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34647 Bug ID: 34647 Summary: name attribute is obsolete in anchor tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: martin.renvoize(a)ptfs-europe.com Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, oleonard(a)myacpl.org Looks like since HTML5, attribute "name" on tag <a> is obsolete : https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conformin… We have a few of them : koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"></a> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <a name="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a> koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: <h3><a name="summary" id="summary"></a>Summary</h3> koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt: <a name="modaction"></a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt: <a name="newsitem[% koha_new.idnew | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.idnew | uri %]">[% koha_new.title | html %]</a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt: [% IF loop.first %]<a name="patron-attr-start-[% pa.type.code | html %]"></a>[% END %] How should we replace ? Some may be not uniq so can't be an id. Maybe an accessibility issue. -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 31143] New: We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '25

23 Jun '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 Bug ID: 31143 Summary: We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org With the move to more and more of Koha using the REST API's and our rest API's being suitably strict about date formats, we need to retrospectively correct occurrences of 0000-00-00 dates appear in database fields system wide. I've had enough occurrences of bad data still in the database after a number of upgrade and it biting me in the UI that I think we should now look at introducing a script to either bulk fix these or at the least identify them and warn they will cause serious issues going forward. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 127