February 2023 - Koha-bugs - lists.koha-community.org

[Bug 12643] Emailing cart should send more details view instead of simple view
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Owen Leonard from comment #1) > Should this bug be a duplicate of or dependent on Bug 3150? I think we could mark it "MOVED" now. It should be possible to add all these information with the new notices, but the first iteration mostly aims on making sure we don't lose anything in the transition from hardcoded template to configurable notice :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #159 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I have to say, I am not sad to see a lot of this old code go away,especially the old template files. This appears as quite a code clean-up. 10 files changed, 306 insertions(+), 1083 deletions(-) 1) The database update and the sample files are both marked as "is_html", but were missing some line breaks and such. I ended up also fixing some issues with missing USE statements causing the OPAC link to not display. --> Follow-up provided, see commit message for more details 2) Currently the mails are sent immediately, this should be kept moving forward. --> Follow-up provided 3) The notices need to be amended to include the changes from bug 16522 to avoid a regression: Bug 16522 - Add 773 (Host item entry) to the cart and list displays and e-mails --> I got stuck on this one, could you please take a look, Aleisha? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #158 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146867&action=e… Bug 3150: (follow-up) Improve and fix new notice templates This fixes several issues found and improves formatting: * Add missing line breaks <br> where required as we are now using HTML * Add missing USE statements to show * library * location * Link to the OPAC (Preference was not resolved) * Make sure there is a comma between library and location * Make sure Author(s): only displays when there is content after * The comment field allows multi-line comments, formatting is now preserved -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #157 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146866&action=e… Bug 3150: (follow-up) Send list and cart emails immediately again With this patch set the cart and list emails are sent via the message_queue instead of bypassing it and being sent immediately. This patch keeps them in message_queue, but also sends them immediately, restoring the previous behavior. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #156 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146865&action=e… Bug 3150: Fix file permission on database update file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146566|0 |1 is obsolete| | --- Comment #155 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146864&action=e… Bug 3150: (follow-up) Use get_marc_contributors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146565|0 |1 is obsolete| | --- Comment #154 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146863&action=e… Bug 3150: (QA follow-up) Remove borrowernumber from EnqueueLetter Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146564|0 |1 is obsolete| | --- Comment #153 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146862&action=e… Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146563|0 |1 is obsolete| | --- Comment #152 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146861&action=e… Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '23

17 Feb '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146562|0 |1 is obsolete| | --- Comment #151 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 146860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146860&action=e… Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0