April 2023 - Koha-bugs - lists.koha-community.org

[Bug 33198] New: request.pl is calculating pickup locations that are not used
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Bug ID: 33198 Summary: request.pl is calculating pickup locations that are not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com One systems with many branches, or complex rules calculating the pickup locations can be expensive. It appears we are calling $biblio->pickup_locations that is only used during multi-holds for all of our holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 33309] New: Race condition while checkout renewal with ES
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Bug ID: 33309 Summary: Race condition while checkout renewal with ES Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: nick(a)bywatersolutions.com Performing checkout renewal with ES turned on causes race condition in BackgroundJobs processing, manifesting with lines like: [2023/03/20 17:18:10] [WARN] No job found for id=13218 main:: /usr/share/koha/bin/background_jobs_worker.pl (114) in worker-output.log. This is due to calling -- inside transaction -- $item_object->store in C4::Circulation::AddRenewal. [Koha::Item->store in turn calls $indexer->index_records, which in installations with ES creates BackgroundJob]. The solution could be similar to that proposed in Bug 33019, i.e. calling $item_object->store with {skip_record_index => 1} and calling $indexer->index_records after the transaction ends. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 33151] New: Improve translation of string in cities.tt and desks.tt
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33151 Bug ID: 33151 Summary: Improve translation of string in cities.tt and desks.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr admin/cities.tt and admin/desks.tt share a similar problem with regard to translation: #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:178 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt:179 #, c-format msgid "%s Searching: %s %s %s " msgstr "%s Recherche : %s %s %s " Wrapping this string with <span> in both templates will make it easier: msgid "Searching: %s" msgstr "Recherche" -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 32399] New: Database update for bug 30483 is failing
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 Bug ID: 32399 Summary: Database update for bug 30483 is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 30483 We have had 2 reports recently of this database update failing: 22.06.00.041 [09:45:46]: Bug 30483 - Make issues.borrowernumber and issues.itemnumber NOT NULLERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'borrowernumber': used in a foreign key constraint 'issues_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 739 And: Upgrade to 22.05.06.001 [19:37:23]: Bug 30483 - Make issues.borrowernumber and itemnumber NOT NULL ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'borrowernumber': used in a foreign key constraint 'issues_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 739 Both refer to the same bug/SQL statements, but backported to different versions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 40

[Bug 33100] New: Authority linking doesn't work for bib headings ending in two or more punctuation characters
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Bug ID: 33100 Summary: Authority linking doesn't work for bib headings ending in two or more punctuation characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, nick(a)bywatersolutions.com At the time of bug 24094 this apparently worked, but now in both my production 22.05 instance and a master sandbox, while Doe, John A. in a bib record will link to Doe, John A. in an authority record, Doe, John A., (as it will be in virtually every RDA record, since you are supposed to have a $e relator for personal names, and you are supposed to have a comma before the $e) will not link to the Doe, John A. authority record. That's a barely noticeable thing unless you actually track your unlinked authorites, but it's very noticeable if you use AutoCreateAuthorites and the first-match linker. In that case, every time you add a new Box, C. J. item, the linker strips off the comma from $aBox, C. J.,$eauthor., declares that your existing authority record for Box, C. J. doesn't match, and AutoCreateAuthorities also strips off the comma, creates a new duplicate Box, C. J. record, and then does it again the next time you save the record, and then does it again when you update the authority record for the series heading because it changed, and that triggers relinking the whole bib record, then again any time you edit the record or any authority linked to it. Two maybe-interesting exceptions, from when I started out looking at all the punctuation that _get_search_form in C4/Heading/MARC21.pm trims from the end of a bib heading to attempt to make it searchable, and the not-quite-the-same things that AutoCreateAuthorities strips before creating what it hopes will be an authority heading that will actually still match during the next linking: Doe, John A-- will autocreate an authority record which is exactly that, because autocreate's set of punctuation lack only that one character from _get_search_heading's regex, but, even though _get_search_heading will turn that into a search for Doe, John A- during a relink, that will match the -- authority form. The same is true for other characters: if you edit the authority record for Doe, John A. and make it Doe, John A., then that will match a bib record with Doe, John A., and will also match a bib record with Doe, John A.! or Doe, John A./ or Doe, John A.^ which isn't even in the set of stripped punctuation so the search should be for Doe, John A.^ and that still matches Doe, John A., Doe, John A=, will match an authority record for Doe, John A with no punctuation, though there's no similar magic for Doe, John,= where _get_search_heading has stripped off the equal sign, making me think at least that bit of magic is happening in the search engine or the query prep. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 33076] New: Add context to "Quotes"
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Bug ID: 33076 Summary: Add context to "Quotes" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr In German at least, a quote in the sense of a "quote of the day" and a quote for something I want to buy/order are different thing that require different translation. It would be great if we could add context to those labels where just "Quotes" is used. koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_accounts.tt:322 koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt:107 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 29173] New: Button "replace authority record via Z39/50/SRU" doesn't work
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Bug ID: 29173 Summary: Button "replace authority record via Z39/50/SRU" doesn't work Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: marion.durand(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To replace an authority record via Z39.50/SRU there are two buttons on differents pages but their behaviour is not the same. One pre-fill the search form but the other don't. If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Replace record via Z39.50/SRU" Then: "Z39.50 authority search points" pop up but all field are empty. But If I do: 1- go to the detail page of an authority record [Koha]/cgi-bin/koha/authorities/detail.pl?authid=[ID] where Koha is your instance of koha and ID is your authority id 2- On the menu Edit click on the button "Edit record" 3- Click on the button "Replace record via Z39.50/SRU search" Then: "Z39.50 authority search points" pop up with usefull values already filled (for example the Author) There is the same two button for bibliographic record and both of them pre-fill the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 78

[Bug 33278] New: Advanced search page first tab not activated
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Bug ID: 33278 Summary: Advanced search page first tab not activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 32683 The JS which triggers the display of a default tab on the advanced search page uses a selector which isn't specific enough now that the header search tabs are Bootstrap too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 [Bug 32683] Convert header search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 29942] New: Spurious commit in mysql session storage
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942 Bug ID: 29942 Summary: Spurious commit in mysql session storage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.jonsson(a)kreablo.se QA Contact: testopia(a)bugs.koha-community.org The DBI storage driver for CGI::Session commits any on-going transactions in its destructor subroutine. Consequently if SessionStorage is set to mysql, instantiating a session and assigning it to a local variable inside a transaction will unexpectedly cause the transaction to be committed as illustrated by the below script. I have reported this issue upstream and created pull requests but it is unclear if anyone is maintaining CGI::Session. https://rt.cpan.org/Ticket/Display.html?id=140855 https://github.com/cromedome/cgi-session/pull/5 We should maybe consider maintaining our own fork of CGI::Session. #!/usr/bin/perl -w use DBI; use C4::Auth; use Koha::Database; use strict; my $dbh = C4::Context->dbh; my $schema = Koha::Database->schema; print "SessionStorage: '" . C4::Context->preference('SessionStorage') . "'\n"; sub test { my $session = C4::Auth::get_session(""); } $dbh->do("CREATE TABLE IF NOT EXISTS `tmp_test_cgi_session` (foo TINYTEXT)"); eval { $schema->txn_do(sub { my $sth = $dbh->prepare("INSERT INTO `tmp_test_cgi_session` VALUES ('foo')"); $sth->execute(); test(); die "error"; }); }; if ($@) { print $@, "\n"; } my $sth = $dbh->prepare("SELECT * FROM `tmp_test_cgi_session`;"); $sth->execute(); # The INSERT of the foo row should have been rolled back, but isn't when # SessionStorage is 'mysql'. while (my $row = $sth->fetchrow_arrayref) { print $row->[0], "\n"; } $dbh->do("DROP TABLE `tmp_test_cgi_session`"); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 32991] New: Improve our Dialog component and remove routes for deletion
by bugzilla-daemon＠bugs.koha-community.org 03 May '23

03 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Bug ID: 32991 Summary: Improve our Dialog component and remove routes for deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com Agustin suggested some nice improvements on bug 32607 that would be great to have in a separate bug. We should embed the changes here, and eventually remove the specific routes (and components) we have to delete object. -- You are receiving this mail because: You are watching all bug changes.

1 122