May 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #112 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Working on fixes and will PQA with follow-ups. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=125…) ----------------------------------------------------------------- ::: Koha/Email.pm @@ +118,5 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); > + foreach my $email (@emails) { This isn't required.. Email::Address handles formatted lists of addresses already. See: https://metacpan.org/pod/Email::Address#parse -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256 Bug 12532: Send email to guarantee and guarantor Review of attachment 150256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=125…) ----------------------------------------------------------------- I love where this is going... but I think it needs a few more little fixes to get it through. Happy to help work those in. ::: C4/Letters.pm @@ +1471,5 @@ > || $message->{to_address} ne $email->email->header('To'); > > + _update_message_from_address($message->{'message_id'},$email->email->header('From') ) > + if !$message->{from_address} > + || $message->{from_address} ne $email->email->header('From'); Not sure how this relates to the core bug here.. and I don't see any updated tests to show what this does either? ::: Koha/Email.pm @@ +118,4 @@ > $args->{to} = $params->{to}; > } > > + my @emails = split(',', $args->{to}); Interesting.. I thought we already supported multiple comma delimited to addresses.. this feels bad enough that we should have it on it's own bug really... but I'm happy to let that slide to get it in. ::: Koha/Patron.pm @@ +1439,5 @@ > + $address .= $guarantor_address if $guarantor_address; > + } > + } > + } > + return $address; I'd like to see this rebased against bug 33223 given it makes the use of notice_email_address more consistent generally. ::: installer/data/mysql/mandatory/sysprefs.sql @@ +597,4 @@ > ('RecallsMaxPickUpDelay','7',NULL,'Define the maximum time a recall can be awaiting pickup','Integer'), > ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'), > ('Reference_NFL_Statuses','1|2',NULL,'Contains not for loan statuses considered as available for reference','Free'), > +('RedirectGuaranteeEmail', '0', NULL, 'Enable the ability to redirect guarantee email messages to guarantor.', 'YesNo'), Redirect seems like the wrong term here.. we're cc'ing in effect in the end.. so perhaps it should be renamed 'Copy' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33223 [Bug 33223] Koha::Patron->notice_email_address isn't consistently used -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #109 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Looking here.. I think it you want to make sure you're catching all locations you need to depend on bug 33223 which systematically goes through the codebase making sure we use notice_email_address consistently. I'm doing a splinter review now.. there seems to be a lot wrapped up into the commit that I'm not sure it directly related to the bug reported. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33223 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20751] New: Marc21: Show i for 776
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20751 Bug ID: 20751 Summary: Marc21: Show i for 776 Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl In 17.11 the marc21 776 field ( [15140] Add MARC21 776 to OPAC and staff display ) became visible in the OPAC and staff client. This was specifically for subfield $t and $w. It would be great if the $i could also be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3