May 2023 - Koha-bugs - lists.koha-community.org

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #125 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- 1. - b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, + # b_sel => ( $budget->{budget_id} == $order->budget_id ) ? 1 : 0, Then remove ;) 2. + creator: + type: + - object + - "null" + description: Patron that created the order We could tell here we expect an object representing a patron 3. + - items.home_branch + - items.holding_branch + - items.itemtype Shouldn't they use the "fixed names"? home_library, item_type? It means to add more methods, and tests, but once it's in the spec it will be hard to modify. Not blocker as I guess we are doing that in other places. 4. https://snipboard.io/SvHwAn.jpg The "Change currency" checkbox is not aligned properly And it's actually not working: * edit * Set actual cost, check "change currency", select a currency, save * edit again => Values are not saved, you are actually breaking bug 25655. Also I have seen "NaN" generated in actual cost but not sure when/how. And finally, values are not saved in the DB (invoice_currency, invoice_unitprice). 5. Partial receive does not seem to work I ordered 3, received 1, receiving again: "Receiving 0 out of 2" => OK Click edit => There are 3 items in the items table 6. "Date received:" does not have flatpickr applied 7. Fund is not marked "required" like before 8. We lost the "show active" checkbox next to the fund list 9. There are missing spaces after numbers "Retail price: 0.00(adjusted for USD, tax exclusive)" 10. + <th></th> Do we want that? 11. JS code in parcel.tt use 2 spaces indentation instead of 4 12. I noticed 2 parallel request to parcel.pl?invoiceid=1 at the end of the process, and one of them is aborted. This is what is in the console: https://snipboard.io/IKwoVP.jpg 13. comment 111 and comment 112 still need an answer. I don't understand how dataTables.select.min.js, select.dataTables.min.css is useful here. Is that the row.select() and row.deselect() statements in parcel.tt? If so, what are they doing? I removed them and didn't see any issues. 14. There are several parts of the JS code in orderreceive.tt that are commented, if we don't need them we should remove them. 15. I think we should widen the modal. The item form is not displayed nicely https://snipboard.io/VIKAgY.jpg 16: not sure it's a blocker: When you select some orders, the table on the order receive page has "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But there is no way to display them all. I understand why and what it implies, just noting. 17. Another "just noting": the code (introduced by bug 20212 I think) related to biblio.suggestions.suggester is bad and should have been simplified before we did all this. I submitted a patch yesterday to remove GetSuggestionInfoFromBiblionumber, it's on bug 28844. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28556 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #118 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I agree Marcel.. It was late last night. So.. In short, I'd like some explanations from the original author as to why they picked the changes they did.. I still don't understand a number of them. I think hooking into _send_message_by_email in C4::Letters is starting to feel like it might be the right place... but setting a `cc` rather than additional `to` -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 11 May '23

11 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #117 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #115) > I'm not so sure that we're hooking this into the right place.. I'm wondering > if it may be better placed in Koha::Email->create.. I would prefer to keep ->create clean and move this specific guarantor action a level higher. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27638] New: Allow exclusions on cancel_expired_holds
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27638 Bug ID: 27638 Summary: Allow exclusions on cancel_expired_holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be good to be able to exclude groups of holds from the cancel_expired_holds cron. Ideally, this would allow exclusion based on library, patron category, and/or item type. Ideally it would be set/edited from the staff client rather than the commandline. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 13529] Easy analyticals and UseControl number should be able to coexist
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 --- Comment #1 from Lauren Denny <lauren_denny(a)sil.org> --- Could someone explain why the two system preferences 'UseControlNumber' & 'EasyAnalytics' cannot co-exist? We used to have both turned on until a recent upgrade and now only use 'UseControlNumber' so that we can seperate our links to the corresponding relationship instead of combining all the options into the 773 field. We are needing features from both system preferences. The flexibility of the 'UseControlNumber' allows koha to use seperate linking fields based on the relationship between records/items instead of putting all the links in the 773 which is only for the parent/child relationship. And how EasyAnalytics allows koha display the item record on both records for those linked together. Here are functions that are utilized by the EasyAnalytics that I would find helpful with some ideas on how to make it work. (I am not a programer so I don't totally know if they would work but are ideas from a librarian's point of view.) 1 - Have a drop-down menu that allows you to choose the linking field you want the information to koha auto-populate subfields from based on the bibilonumber instead of the barcode. The field selected where to put the inforamtion to pulled based on system preference or framework selection. 2- System preference that allows you to control which fields auto-populate with the selected field. 245$ab title to $t, 1xx$a author to $a, 250$a edition to $b, 001 control number (biblionumber) to $w , 260/264 publishing details to $d, 020 ISBN to $x, 022 ISSN to $z Another idea would be to have a checkbox in the framework that people select that tells koha what information to pull into the field. 3- Have the item record appear on both the parent & child records This would be helpful for records using the 773 (parent & child relationship) where one item record is 'shared' with both record. It is physcially on the child record but would be helpful to patrons to have a list of all the items associated with the parent record. An idea would be, if the item number or barcode is found in the 773 field, the item appears on record with the link. If these subfields are empty the item will not display on the linked record. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #116 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Sorry, I also meant to say I think the guarantor email should go in the cc field rather than to field (unless the to field is empty in which case just put guarantor in to). This complicates things a little but I feel it's the right behaviour -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #115 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I'm not so sure that we're hooking this into the right place.. I'm wondering if it may be better placed in Koha::Email->create.. Needs a little thought.. I've stuck my QA follow-up's in and will switch back to SO to get some other QA opinions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #114 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 151029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151029&action=e… Bug 12532: (QA follow-up) Clean up notice_email_address Reduce some of the code duplication -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 10 May '23

10 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #113 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 151028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151028&action=e… Bug 12532: (QA follow-up) Undo changes to Koha::Email The changes here aren't required (Email::Address already deals with lists of addresses internally) -- You are receiving this mail because: You are watching all bug changes.

1 0