July 2023 - Koha-bugs - lists.koha-community.org

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 mathieu saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #111 from mathieu saby <mathsabypro(a)gmail.com> --- Works as described, but note that the syspref is now named EmailFieldPrimary -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Biblibre Sandboxes <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153540|0 |1 is obsolete| | --- Comment #110 from Biblibre Sandboxes <sandboxes(a)biblibre.com> --- Created attachment 154076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154076&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25763] New: Allow update of order fund after receipt
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Bug ID: 25763 Summary: Allow update of order fund after receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nick(a)bywatersolutions.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Sometimes after an order has come in there are donations or changes to funds and the library may wish to change the fund that the order is allocated from. This bug will allow updating the order fund from the invoice page. -- You are receiving this mail because: You are watching all bug changes.

1 30

[Bug 33052] New: Add a message for from_local_hold_group override
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Bug ID: 33052 Summary: Add a message for from_local_hold_group override Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 8273] Add biblionumber to deleted item on log
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The biblionumber is part of the fully logged item information now. Closing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8290] Replace usage of Greybox modals with Bootstrap modals
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Should we pick this up again? It looks like there is only one pending bug still open, but not sure if these were all cases. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8362] Circulation fixes and improvements omnibus
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Bug 8362 depends on bug 8371, which changed state. Bug 8371 Summary: Add global level issuing rules (number of checkouts over all libraries, etc.) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8371] Add global level issuing rules (number of checkouts over all libraries, etc.)
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 8137 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 29 Jul '23

29 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #92 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** Bug 8371 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0