August 2023 - Koha-bugs - lists.koha-community.org

[Bug 30825] New: Get rid of GetReservesControlBranch
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Bug ID: 30825 Summary: Get rid of GetReservesControlBranch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The method currently requires unblessed objects only to access one attribute on them... and it can certainly be moved to Koha::* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 59

[Bug 32496] New: Reduce unnecessary unblessings of objects in Circulation.pm
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Bug ID: 32496 Summary: Reduce unnecessary unblessings of objects in Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There are a lot of instances in of unnecessary unblesssings in Circulation.pm (and also in some other parts of the C4 namespace), for legacy reasons I assume as it was an convenient way not having to adept the code to much after changing to the object oriented interface. This patch builds on Bug 31735 and cleans up a large part, but not all, of these uncalled-for unblessings. I focused mainly on refactoring CanBookBeRenewed and the subroutines it calls as this is run for each checked out item and has on of the highest performance impacts of the circulation related subroutines. The performance gains are pretty modest though, so the main motivation is to clean up the code (and in some instances avoid having to re-fetch the object where a method needs to be called, and an unblessed hashref was passed in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 62

[Bug 34391] New: Inconsistencies in Cash registers page headers
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34391 Bug ID: 34391 Summary: Inconsistencies in Cash registers page headers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Cash registers page, here is what should be changed to make it consistent with the other pages in the module: Page header - Change 'Add new cash register' to 'New cash register' - Add cash register ID to page header -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34389] New: Inconsistencies in Debit types page titles, breadcrumbs, and header
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34389 Bug ID: 34389 Summary: Inconsistencies in Debit types page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Debit types page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add debit type code to Modify X (e.g. Modify debit type 'MANUAL') Breadcrumb - Add debit type code to Modify X (e.g. Modify debit type 'MANUAL') Page header - Change 'Modify a debit type' to "Modify debit type 'Y'" -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 33812] New: Accessibility: OPAC messaging preferences is missing form labels
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Bug ID: 33812 Summary: Accessibility: OPAC messaging preferences is missing form labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: matt.blenkinsop(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The checkboxes in the Messaging preferences table in the OPAC have been flagged as non-compliant by the Shaw Trust in a report carried out for the British Museum. It is not clear for screen readers what the checkboxes are for. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 34153] New: Add ability to allow items with additional materials notes to be checked out via SIP
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34153 Bug ID: 34153 Summary: Add ability to allow items with additional materials notes to be checked out via SIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org At this time, any item with an additional materials date is blocked from checkout via SIP with a screen message to take the item to a circulation desk for checkout. Some libraries wish to allow patrons to check out items via SIP even if the item has additional materials. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 33245] New: Add $patron->is_active
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Bug ID: 33245 Summary: Add $patron->is_active Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 37

[Bug 34357] New: Subroutine Koha::ItemType::SUPER::imageurl redefined
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34357 Bug ID: 34357 Summary: Subroutine Koha::ItemType::SUPER::imageurl redefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This becomes visible since Bug 33745: Lazily create attribute accessor methods in AUTOLOAD. Note that Koha::ItemType was introduced with an unneeded SUPER reference on commit db2a1aa0dda1c786c34c3cf239fccfcaedefd094: +sub image_location { + my ( $self, $interface ) = @_; + return C4::Koha::getitemtypeimagelocation( $interface, $self->SUPER::imageurl ); +} We should just use $self->imageurl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 33983] New: Move translatable strings out of OPAC's datatables.inc into JavaScript
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33983 Bug ID: 33983 Summary: Move translatable strings out of OPAC's datatables.inc into JavaScript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 21156 Strings defined for translation in datatables.inc in the OPAC can should be wrapped in the new translation function inside datatables.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 34026] New: Move translatable cover-handling strings out of opac-bottom.inc
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34026 Bug ID: 34026 Summary: Move translatable cover-handling strings out of opac-bottom.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart+koha(a)gmail.com, testopia(a)bugs.koha-community.org Depends on: 33983, 21156 opac-bottom.inc defines several template variables for variations on "No cover image available" which are unnecessary. We can wrap those strings in the __() function in the JS files. This patch will cover Coce, Amazon, Baker & Taylor, Google, and OpenLibrary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33983 [Bug 33983] Move translatable strings out of OPAC's datatables.inc into JavaScript -- You are receiving this mail because: You are watching all bug changes.

1 20