August 2023 - Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #126 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 155037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155037&action=e… Bug 21272: Unit test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #125 from Hammat wele <hammat.wele(a)inlibro.com> --- Created attachment 155036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155036&action=e… Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34534] New: Anonymisation - ability to set different period by patron category
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34534 Bug ID: 34534 Summary: Anonymisation - ability to set different period by patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: aude.charillon(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Both the batch_anonymise.pl script and the Batch patron deletion/anonymization tool allow to set a number of days or a date after which circulation history is anonymised. However, both of these methods apply the same period of time to all patrons. It would be useful if libraries could set different periods by patron category. For example, if standard users could have their circulation history anonymised earlier than housebound users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 24359] New: Remove items from Holds Queue when checked in
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Bug ID: 24359 Summary: Remove items from Holds Queue when checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently, if an item is checked in and the hold is triggered/captured, the item will not come off the holds queue until the the cronjob runs again. This causes some confusion for multibranch systems when other branches attempt to fill holds that have already been filled. Proposal: Remove bib/items from the Holds Queue after checkin and before the next holds queue cron runs to update the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 34675] New: Build and use the holds queue when checking in an item and searching for holds
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34675 Bug ID: 34675 Summary: Build and use the holds queue when checking in an item and searching for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently we have two distinct but very similar codepaths When building the queue we use the code in C4/HoldsQueue.pm to map all available items on a bib to the holds requests, choosing the most prioritized hold per item When checking in an item we use the CheckReserves code in C4/Reserves.pm to map a single item to the most prioritized hold request It seems these processes should be combined and standardized. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 31735] New: Circulation optimizations
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Bug ID: 31735 Summary: Circulation optimizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We recently had time-out issues and high server loads for patrons with high checkout counts (some patrons have several hundreds, up to about 400). One of the major bottlenecks turned out to be C4::Circulation::CanBookBeRenewed. The primary reason it performed so poorly was constant re-fetching of different database entities which could just as well be passed down directly instead of passing ids which requires re-fetching further down the call stack. After refactoring the most performance critical subroutines to take objects instead of object ids the calls to expensive DBIx-methods has been greatly reduced. In addition some other optimizations and bug fixes related to non working caching resulted in further speedups. The performance gain for a patron with around 400 checkouts is currently about 500%. I made an effort to fix all tests affected by the changes, but I can not guarantee there are absolutely no regressions left in the test-suite. Since many tests seem to fail due to reasons not related to this patch, mainly due to the state of my local instance triggering tests-bugs (for example caused by preferences not being mocked correctly, or relying on database test-entries that are not guaranteed to exist), it was impractical and very time consuming to make sure all tests still run successfully. So subset of tests where the changed subroutines are called directly was selected and these should now pass. The following tests should be effected by the changes and should be run as a part of the test-plan: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t The following still fails for me but should either work on a fresh Koha installation, or fail for unrelated reasons (that is they also fail in Koha master): t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Items.t t/db_dependent/SIP/ILS.t To be able to run t/db_dependent/Circulation.t in my Koha instance there where some existing bugs that needed fixing, so this patch have a dependency on Bug 31676. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 109

[Bug 34672] New: Error 404 when adding new page to koha
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34672 Bug ID: 34672 Summary: Error 404 when adding new page to koha Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nasralyashassan(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Hi, I am having a problem when I want to add a new page to OPAC I am getting the error 404. The error is: An error has occurred! Error 404 This message may have been caused by any of the following reasons: You made use of an external link to an item that is no longer available You followed an outdated link e.g. from a search engine or a bookmark You tried to access a page that needs authentication An internal link in the client is broken and the page does not exist What's next? Use top menu bar to navigate to another part of Koha. To report a broken link or any other issue, please contact the Koha administrator. Send email -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 34571] New: Remove use of onclick for ExpandField in addbiblio.tt
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34571 Bug ID: 34571 Summary: Remove use of onclick for ExpandField in addbiblio.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Like bug 34570, we want to get rid of "onclick". In this case, I'm targeting ExpandField. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 34570] New: Remove use of onclick for PopupMARCFieldDoc()
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34570 Bug ID: 34570 Summary: Remove use of onclick for PopupMARCFieldDoc() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org We can't use "onclick" attributes with CSP and we generally try to avoid them in Koha. This report targets the PopupMARCFieldDoc() function in the cataloguing editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 34522] New: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Bug ID: 34522 Summary: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: hebah(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Observed in 22.11 To recreate: Log into OPAC as patron of Branch A Make purchase suggestion for Branch B Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A View suggestion from staff client See that it accurately reflects suggestion having been made for Branch B This display is confusing (and inaccurate) for patrons. -- You are receiving this mail because: You are watching all bug changes.

1 16