September 2023 - Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155296|0 |1 is obsolete| | --- Comment #63 from David Nind <david(a)davidnind.com> --- Created attachment 155540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155540&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155295|0 |1 is obsolete| | --- Comment #62 from David Nind <david(a)davidnind.com> --- Created attachment 155539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155539&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155294|0 |1 is obsolete| | --- Comment #61 from David Nind <david(a)davidnind.com> --- Created attachment 155538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155538&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155293|0 |1 is obsolete| | --- Comment #60 from David Nind <david(a)davidnind.com> --- Created attachment 155537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155537&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155292|0 |1 is obsolete| | --- Comment #59 from David Nind <david(a)davidnind.com> --- Created attachment 155536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155536&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155291|0 |1 is obsolete| | --- Comment #58 from David Nind <david(a)davidnind.com> --- Created attachment 155535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155535&action=e… Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155290|0 |1 is obsolete| | --- Comment #57 from David Nind <david(a)davidnind.com> --- Created attachment 155534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155534&action=e… Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #42 from David Cook <dcook(a)prosentient.com.au> --- Can you speak more to what the output would look like? If I understand correctly, it seems like the email body would contain two full email letters in it? If a patron did have 50 holds that were filled during different times of the day, I think they'd still get separate emails with the chunk being governed the interval that "process_message_queue.pl" runs? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #41 from David Cook <dcook(a)prosentient.com.au> --- I noticed my local public library fills my holds and then I get an email the next day saying which holds are ready for me to pick up. I found the delay a bit annoying as I would've liked to know my holds were ready sooner, but I think having just 1 email was very nice. -- You are receiving this mail because: You are watching all bug changes.

1 0