January 2024 - Koha-bugs - lists.koha-community.org

[Bug 35819] New: "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Bug ID: 35819 Summary: "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 29346 A BatchUpdateBiblioHoldsQueue job is triggered from AddRenewal if RealTimeHoldsQueue is set. It is executed inside a transaction and the worker can receive the job to process before the transaction has been committed (and so before the job exists in the DB). The call stack is: opac-renew: AddRenewal In C4::Circulation::AddRenewal 3234 $schema->txn_do(sub{ 3302 $item_object->store({ log_action => 0, skip_record_index => 1 }); In Koha::Item->store 223 Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue( 224 { 225 biblio_ids => [ $self->biblionumber ] 226 } 227 ) unless $params->{skip_holds_queue} or !C4::Context->preference('RealTimeHoldsQueue'); To recreate: Turn on RealTimeHoldsQueue Check an item in to a patron At the OPAC, renew the checkout => Job 109 not found, or has wrong status main:: /kohadevbox/koha/misc/workers/background_jobs_worker.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 68

[Bug 35554] New: Authority search popup is only 700px
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Bug ID: 35554 Summary: Authority search popup is only 700px Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one : > git grep 'width=' koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open(link+"&result="+defaultvalue,"valuebuilder",'width=700,height=550,toolbar=false,scrollbars=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=550,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 35398] New: EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398 Bug ID: 35398 Summary: EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 20595 Bug 20595 introduced support for LRP fields in EDI with StockRotation enabled. However, it missed a case where each order line only contains one item per line. This wasn't spotted in the existing uses as they structure their orders somewhat differently, but is being highlighted at a sight where they regularly order in this way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595 [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 35351] New: Adjust basket details template to avoid showing empty page-section
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351 Bug ID: 35351 Summary: Adjust basket details template to avoid showing empty page-section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org We shouldn't show an empty page-section div when there are no orders to show. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 35422] New: Unexpected tranlsation string for Suggestions template
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422 Bug ID: 35422 Summary: Unexpected tranlsation string for Suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org This string didn't get broken up as expected: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:11 %s %s %s %s &rsaquo; %s Add suggestion &rsaquo; %s %s %s &rsaquo; %s %s &rsaquo; %s &rsaquo; %s %s Maybe we need to wrap the "Add suggestion" as well? -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 35949] New: Useless code pointing to branchreserves.pl in request.tt
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35949 Bug ID: 35949 Summary: Useless code pointing to branchreserves.pl in request.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 171 [% IF ( messagetransfert ) %] 172 <div class="dialog message"> 173 <h2>Hold found for ([% nextreservtitle | html %]), please transfer</h2> 174 <p>Hold placed by : <strong> [% nextreservsurname | html %] [% nextreservfirstname | html %]</strong> at : <strong> [% branchname | html %] </strong>, Please transfer this item. 175 </p> 176 <form name="cancelReservewithtransfert" action="branchreserves.pl" method="post"> 177 [% INCLUDE 'csrf-token.inc' %] 178 <input type="submit" class="button" /> 179 </form> 180 </div> 181 [% END %] messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist! -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 23540] New: Gender 'N' is not translatable
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23540 Bug ID: 23540 Summary: Gender 'N' is not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org Patrons of type 'I' (institution) automatically get their sex/gender set to 'N' (which is short for "None"), but the 'N' is not translatable and actually shows up in the patron details page. Relevant code in memberentrygen.tt: [% IF ( I ) %]<input type="hidden" name="sex" value="N" />[% END %] The template code for showing the gender text should be unified into single included file, instead of spread over multiple places like: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: [% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %] koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt: [% IF ( patron.sex ) %]<li><span class="label">Gender:</span>[% IF ( patron.sex == 'F' ) %]Female[% ELSIF ( patron.sex == 'M' ) %]Male[% ELSE %][% patron.sex | html %][% END %]</li>[% END %] -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 21314] New: Koha enforces 3 character password length even if RequireStrongPassword is disabled
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314 Bug ID: 21314 Summary: Koha enforces 3 character password length even if RequireStrongPassword is disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 18298 added the option to enforce password complexity *if* the new system preference RequireStrongPassword is enabled. However, it appears that the code defining the minimum number of characters was not put under control of this preference and thus Koha enforces a minimum password length of 3 even if RequireStrongPassword is disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 33262] New: When an ordered record is deleted, we lose all information on what was ordered
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Bug ID: 33262 Summary: When an ordered record is deleted, we lose all information on what was ordered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: clemens.tubach(a)kit.edu, michaela.sieber(a)kit.edu Blocks: 10758 I am moving this out from bug 10758 that was filed for the display issue. But that is actually only the symptom, while we are actually facing a data loss issue. Libraries need to be able to account for the money they spent even after the items and records have been removed from their collection. At the moment we lose the connection between order and bibliographic record when the record is deleted: -- -- Table structure for table `aqorders` -- DROP TABLE IF EXISTS `aqorders`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8 */; CREATE TABLE `aqorders` ( `ordernumber` int(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key and unique identifier assigned by Koha to each line', `biblionumber` int(11) DEFAULT NULL COMMENT 'links the order to the biblio being ordered (biblio.biblionumber)', [...] CONSTRAINT `aqorders_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE SET NULL ON UPDATE CASCADE, We do have the information about the deleted record and the items, but we need to preserve the link between order and deleted record in some way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 [Bug 10758] Show bibliographic information of deleted records in acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 47

[Bug 27679] New: The notices and slips management area should be moved to 'Administration'
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27679 Bug ID: 27679 Summary: The notices and slips management area should be moved to 'Administration' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org As the title says, the Notics and Slips "tool" isn't really a tool.. it's a system administration task.. so it should live under administration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5