January 2024 - Koha-bugs - lists.koha-community.org

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35941 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35165] New: Batch item deletions are run in a single transaction and cause locking issues
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35165 Bug ID: 35165 Summary: Batch item deletions are run in a single transaction and cause locking issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We recently saw a site perform a batch deletion of ~18k items (and subsequently 2k bibs) While running the jobs we suddenly started seeing all sorts of actions fail, most notably placing reserves, and errors in the logs like: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Lock wait timeout exceeded; try restarting transaction at /usr/share/koha/lib/Koha/Object.pm line 170 I believe part of the problem is that the entire batch deletion is a single transaction. While we should make parts of this atomic, I don't think the entire job should succeed or fail on an error. I think we should commit each item, then each bib, then continue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 27

[Bug 5920] Remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 --- Comment #8 from Mirjam Vantieghem <mirjam.vantieghem(a)etf.edu> --- Addition: The patch from bug #5697 has solved the issue for us, as we were not using HTML for another purpose in these reports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 23487] New: Utf8mb4 collation causes problems with missing tables when upgrading the database
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487 Bug ID: 23487 Summary: Utf8mb4 collation causes problems with missing tables when upgrading the database Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org Changing the default encoding to utf8mb4 and collation to utf8mb4_unicode_ci, can create duplicate unique keys as it ignores differences in accented characters vs non-accented characters. An example would be the Swedish letter ö, which is treated like the letter o. More is discussed here: https://stackoverflow.com/questions/47119794/mysql-mariadb-unable-to-handle… When upgrading a large database to any version with the new encoding and collation, there is a chance of duplicate unique keys crashing the collation change of the table (or tables) and as a result corrupting InnoDB tablespace. The final result is one or more tables that both exist and don't exist, and thus can't be deleted or created again. We, not so fondly, called them Schrödinger's tables. For Stockholm University Library, we had about 30 duplicate unique keys in the borrowers table (out of ~220K patrons), mostly in userid. Which crashed the database every time we tried to upgrade until we found the cause. The workaround solution was to change/remove these duplicates, but perhaps a better solution for the community would be to change the default encoding/collation for columns with unique keys? Perhaps utf8mb4_bin? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 5920] Remove HTML from downloaded reports
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Mirjam Vantieghem <mirjam.vantieghem(a)etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem(a)etf.edu --- Comment #7 from Mirjam Vantieghem <mirjam.vantieghem(a)etf.edu> --- We have been using our own patch to strip HTML when downloading a report. It would be great if this can become part of mainstream Koha as an optional feature. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 33966] New: "Update and run SQL" for non-English templates
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 Bug ID: 33966 Summary: "Update and run SQL" for non-English templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Bug 23824 unfortunately introduced issues when the "Update and run SQL" button is used in translated templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 --- Comment #65 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #64) > Created attachment 161575 [details] [review] > Bug 34913: Fix perlcritic for VirtualShelves.pm > > C4/Utils/DataTables/VirtualShelves.pm: "@order_by" is declared but not used > at line 86, column 9. Unused variables clutter code and make it harder to > read. (Severity: 3) Patch has been pushed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34913] Upgrade DataTables from 1.10.18 to 1.13.6
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '24

30 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35343] New: record method, required for bug 26611, missing from Koha::Authority
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '24

29 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35343 Bug ID: 35343 Summary: record method, required for bug 26611, missing from Koha::Authority Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Bug 26611 was backported to 22.11.x, but missed that Koha::Authority->record was added in bug 31794. We need the record method adding for 22.11 to prevent code explosions when matches are found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 35933] New: Do not translate text nodes in xsl:attribute and other tags
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '24

29 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35933 Bug ID: 35933 Summary: Do not translate text nodes in xsl:attribute and other tags Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: kevin.carnes(a)ub.lu.se QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr, jonathan.druart+koha(a)gmail.com Koha extracts text from text nodes and makes them available for translators to translate. This can cause problems when the text needs to be the same for all languages. For example, when an HTML tag is built using XSLT, the values of its attributes should not be translated. One solution is to put the text in a xsl:value-of element instead of a text node. This patch is a quick test to see if there is a more general solution. When entering certain tags it treats text nodes as CDATA (it's also possible to make it a COMMENT, UNKNOWN, or a new token type). It increments and decrements the status to try and handle nested tags, but it might be necessary to make a more robust solution. Is there interest in developing this solution further? Are there cases where text should be translated in xsl:attribute? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3