October 2024 - Koha-bugs - lists.koha-community.org

[Bug 14007] Values listed in OpacHiddenItems should not appear in OPAC facets
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Kyle M Hall (khall) <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38199 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38199 [Bug 38199] Printing transfer slips from circ/returns.pl doesn't set focus properly ( 24.05.x and below ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11722] Hold status not updated after change while in transit
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11722 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- I think this bug no longer exists in main. It's no longer possible to manually change the priority of an item which is in transit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 28844] New: Suggestion from existing title can alert patron in error
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844 Bug ID: 28844 Summary: Suggestion from existing title can alert patron in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 14963 To recreate: - in acquisitions, create an order - on the OPAC, find the bib relating to your order and put in a purchase suggestion tied to that bib - back in acquisitions, receive your order without interacting with the purchase suggestion at all - the patron tied to the suggestion has received a notice that their suggestion is available While the suggestion and the order tie to the same bib, we cannot assume the suggestion and the order are linked directly. Especially in a multi-library system, there's no guarantee that the received copy of this title will go to the patron that requested it. We should only send suggestion notices to the patron for receipt of orders created from a purchase suggestion directly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 69

[Bug 17594] New: Make Koha::Object->discard_changes available
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17594 Bug ID: 17594 Summary: Make Koha::Object->discard_changes available Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 36305] New: Inventory tools need adjustments for CSRF
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36305 Bug ID: 36305 Summary: Inventory tools need adjustments for CSRF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The main forms don't use 'op' other than checking for the existence Problem follow-ups use an ajax post -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37018] SQL injection using q under api/
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37018 --- Comment #161 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #160) > Work as expected. > > Do you have another concern about it? Yes, the validation allows invalid operators at a deeper level as mentioned in earlier comment. Here is proof: Run this script use Modern::Perl; use Data::Dumper qw/Dumper/; use Koha::REST::Plugin::Query; my $query = { priority => [ { '=', 2 }, { '>', 5 } ] }; print Dumper( Koha::REST::Plugin::Query::_validate_query( $query ) ); $query = { priority => [ { '||', 2 }, { ';;', 5 } ] }; print Dumper( Koha::REST::Plugin::Query::_validate_query( $query ) ); $query = { "item_id" => { "<", "5" } }; print Dumper( Koha::REST::Plugin::Query::_validate_query( $query ) ); $query = { "item_id" => { "||", "5" } }; print Dumper( Koha::REST::Plugin::Query::_validate_query( $query ) ); As you can see, the second query is invalid with || operator and the fourth query is invalid too. What are the results: $VAR1 = ''; $VAR1 = ''; $VAR1 = ''; [Invalid operator found in query] This shows that the second query is approved, and only the fourth is rejected (where the operator is a level higher in the recursion). That is actually wrong. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14007] Values listed in OpacHiddenItems should not appear in OPAC facets
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #35 from David Cook <dcook(a)prosentient.com.au> --- You're a legend, David (Nind). One day we'll solve the OpacHiddenItems problem that causes the search result number mismatch problem... one day... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14007] Values listed in OpacHiddenItems should not appear in OPAC facets
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '24

25 Oct '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes item type facets release notes| |in OPAC search results when | |using OpacHiddenItems. | |Facet values in | |OpacHiddenItems are now | |filtered out and no longer | |displayed. | | | |For example, to | |hide Map item types (item | |type code = MP) in the | |OPAC: | |- add "itype: ['MP']" | |to OpacHiddenItems | |- | |previously, map items would | |not be displayed in the | |search results, but the | |'Item type' facet under | |'Refine your search' would | |still display the 'Maps' | |value | |- now, the item type | |facet no longer displays | |the 'Maps' value --- Comment #34 from David Nind <david(a)davidnind.com> --- Testing notes (using KTD): 1. Test with both Elasticsearch 7 and Zebra. I couldn't start KTD with ES8, only ES7. 2. Top: start up KTD with Elastic search 7. Once tested with Elasticsearch, change SearchEngine to Zebra and reindex. 3. Note: The number of search results does not match. For example, I edited "Programming perl" (biblionumber = 262) to change the Koha item type to Maps, and edited the item so that it was Maps as well. Searching for 'perl' returns 10 actual results, which doesn't match with "Your search returned 11 results". -- You are receiving this mail because: You are watching all bug changes.

1 0