March 2024 - Koha-bugs - lists.koha-community.org

[Bug 36160] New: Use $builder->build_object when creating patrons in Circulation.t
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36160 Bug ID: 36160 Summary: Use $builder->build_object when creating patrons in Circulation.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Since Patron::update_lastseen was introduced in Bug 15504 circulation tests can protentially crash with: "Invalid value passed, borrowers.updated_on=SCALAR(0x564a85c3e9b0) expected type is datetime" depending of the value of TrackLastPatronActivityTriggers. This probably does not happen on a fresh Koha installation, but did when I ran the tests locally with "Renew an item" activated for TrackLastPatronActivityTriggers. The reason is that in the Circulation.t tests patron objects are created through Koha::Patron->new instead of using the builder object, and $self->lastseen($now)->store; is called in update_lastseen, on an object that does not have a valid updated_on, resulting in an invalid default value being assigned inKoha/Schema/Loader/mysql.pm. Possible added future test might also crash if resulting in these patron objects being updated. This patch fixes this issue, the tests still fail for other reasons: # Failed test 'transferbook tests' # at t/db_dependent/Circulation.t line 5769. Exception 'Koha::Exceptions::MissingParameter' thrown 'The to parameter is mandatory' But will create another issue for this if not due to some strange local issues. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 36265] New: Bigger font-size for headers in staff interface
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36265 Bug ID: 36265 Summary: Bigger font-size for headers in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In staff interface, text in nav bar and search header are at normal size. Since these are used a lot, I propose to increase font-size. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 36075] New: Add API route to list recalls
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36075 Bug ID: 36075 Summary: Add API route to list recalls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz CC: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 34574] New: Patron search results: Option to deactivate the filters
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34574 Bug ID: 34574 Summary: Patron search results: Option to deactivate the filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sally.healey(a)cheshiresharedservices.gov.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Since the staff interface redesign, the search patron results DataTable has filters activated at the top. Is it possible to add a way to turn these off? Alternatively, is it possible to change the dropdown selectors into a text search (as on the other columns)? The problem is that the dropdown filters include every library / patron category; this means that the columns are always the width of your longest library / longest patron category. Before the staff interface redesign, the width of these two columns were flexible. Since the redesign, if your system has any long library names or patron category names, the table breaks on width, causing a horizontal scrollbar. An example of how the library name displays: Before (on a smaller screen): Institut Protestant de Théologie After: Institut Protestant de Théologie Instead of a 12 character width column, it's a 32 character width column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 23

[Bug 36138] New: Add cancellation reason to opac-holdshistory.pl's Status column
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36138 Bug ID: 36138 Summary: Add cancellation reason to opac-holdshistory.pl's Status column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On the staff interface the Status column on members/holdshistory.pl includes the reason for cancellation, if there is one. We should add this to Status column on opac-holdshistory.pl as well. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 36093] New: Fix missing array reference in provider rollup reports
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36093 Bug ID: 36093 Summary: Fix missing array reference in provider rollup reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: matt.blenkinsop(a)ptfs-europe.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com An array has not been correctly referenced when passed into a function when creating a provider rollup report -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 30068] New: Wrong reference to table_borrowers in circulation.tt
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068 Bug ID: 30068 Summary: Wrong reference to table_borrowers in circulation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 17353, 21034 There is a reference to table_borrowers in the table settings yaml file, and this: 985 columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] in circulation.tt But #table_borrowers is not a table displaying patrons, but items. The confusion is coming from this commit that first introduced the id on this table: commit 7d598d9130c3d171af1e1a6a0a168cea043c277d Bug 21034: Re-indent circulation.tt Then: commit f6599b2c5480d2e096bac71e4e7ac759686b9fbc Bug 17353: Add phone number column to checkout search That added the columns settings line. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17353 [Bug 17353] Add phone number column to checkout search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21034 [Bug 21034] Re-indent circulation.tt -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 35810] New: Add back to top button on staff result page
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35810 Bug ID: 35810 Summary: Add back to top button on staff result page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: thibaud.guillot(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Hi all, As in bug 30136, I'd like to add a "back to top" button on the search results page. I put the same code as the opac and a bit of css to get a nice result. Feel free to test it and give feedback :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 35392] New: HTML in translatable string
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35392 Bug ID: 35392 Summary: HTML in translatable string Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: caroline.cyr-la-rose(a)inlibro.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com This string appears as is in Weblate to be translated, HTML tags and all <li>Job for uploaded file has been queued, <a href="/cgi-bin/koha/admin/background_jobs.pl?op=view&id=%s" target="_blank">click here</a> to check its progress.</li> Usually, HTML tags don't appear. I'm not sure what is different for this one. Probably something to do with JS or Vue? For reference, the line is koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFileImport.vue:93 Furthermore, while we are there to correct it, we should also correct the "click here" link. I understand it is not an accessible way of making links. All other job queue messages look like this H1 Title: The job has been enqueued! Text: It will be processed as soon as possible. Link: View detail of the enqueued job See for example https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-t… -- You are receiving this mail because: You are watching all bug changes.

1 50

[Bug 36307] New: SMS::Send driver errors are not captured and stored
by bugzilla-daemon＠bugs.koha-community.org 28 May '24

28 May '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36307 Bug ID: 36307 Summary: SMS::Send driver errors are not captured and stored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If an SMS::Send driver succeeds, it returns a value that evaluates to true. Every driver I've inspected uses croak when it encounters a failure state. When an SMS message fails to send, code hard codes the failure code to NO_NOTES (No notes from SMS driver). We should store the real error in `failure_code` and display that if the failure code doesn't match a known failure code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15