March 2024 - Koha-bugs - lists.koha-community.org

[Bug 36091] New: Spelling: Patron card number/cardnumber
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36091 Bug ID: 36091 Summary: Spelling: Patron card number/cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Not sure which spelling is correct, but consistency is good. $ grep -rn "Patron cardnumber" * koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt:4: "[% t("Manager name") | html %]"[% sep | html %]"[% t("Patron cardnumber") | html %]"[% sep | html %]"[% t("Patron name") | html %]"[% sep | html %]"[% t("Transaction library") | html %]"[% sep | html %]"[% t("Transaction date") | html %]"[% sep | html %]"[% t("Updated") | html %]"[% sep | html %]"[% t("Transaction type") | html %]"[% sep |html %]"[% t("Notes") | html %]"[% sep | html %]"[% t("Amount") | html %]"[% sep | html %]"[% t("Title") | html %]"[% sep | html %]"[% t("Barcode") | html %]"[% sep | html %]"[% t("Item type") | html %]" grep: misc/translator/po/.git/objects/pack/pack-b0a884343922aff65f857e780adda0f2bcc2203f.pack: binary file matches grep: misc/translator/po/.git/objects/pack/tmp_pack_O9fPOy: binary file matches misc/release_notes/release_notes_20_05_00.html:1588:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329">[24329]</a> Patron cardnumber change times are lost during upgrade for bug 3820</li> misc/release_notes/release_notes_20_05_00.md:1194:- [[24329]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329) Patron cardnumber change times are lost during upgrade for bug 3820 $ grep -rn "Patron card number" * koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt:172: <th>Patron card number</th> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 36099] New: JS error in console on non-existent biblio record
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36099 Bug ID: 36099 Summary: JS error in console on non-existent biblio record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4321 "Uncaught ReferenceError: biblionumber is not defined" Coming from this line: browser = KOHA.browser('', parseInt(biblionumber, 10)); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 36297] New: Avoid using var named "t" in templates
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36297 Bug ID: 36297 Summary: Avoid using var named "t" in templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Issue in templates discovered in Bug 36158 Avoid using var named "t" in templates (in FOREACH) because of conflict with t() for translations. > git grep 'FOREACH t IN' origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt: [%- FOREACH t IN [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10'] -%] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt: [%- FOREACH t IN [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'] -%] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt: [% FOREACH t IN item_templates.owned %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt: [% FOREACH t IN item_templates.shared %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt: [% FOREACH t IN item_templates.owned %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt: [% FOREACH t IN item_templates.shared %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt: [% FOREACH t IN club_templates %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt: [% FOREACH t IN club_templates %] origin/master:koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt: [% FOREACH t IN terms %] -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 35949] New: Useless code pointing to branchreserves.pl in request.tt
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35949 Bug ID: 35949 Summary: Useless code pointing to branchreserves.pl in request.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 171 [% IF ( messagetransfert ) %] 172 <div class="dialog message"> 173 <h2>Hold found for ([% nextreservtitle | html %]), please transfer</h2> 174 <p>Hold placed by : <strong> [% nextreservsurname | html %] [% nextreservfirstname | html %]</strong> at : <strong> [% branchname | html %] </strong>, Please transfer this item. 175 </p> 176 <form name="cancelReservewithtransfert" action="branchreserves.pl" method="post"> 177 [% INCLUDE 'csrf-token.inc' %] 178 <input type="submit" class="button" /> 179 </form> 180 </div> 181 [% END %] messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist! -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 8676] Show vendor name in source of acquisition
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)gmail.com |oleonard(a)myacpl.org --- Comment #20 from Jonathan Druart <jonathan.druart(a)gmail.com> --- I won't have time to work on this in a near future. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8676] Show vendor name in source of acquisition
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |jonathan.druart(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29033] New: Add C4::Context->multivalue_preference
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Bug ID: 29033 Summary: Add C4::Context->multivalue_preference Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I've seen many places in which a syspref is read, and then split used to convert the contents into a list. It seems it would be simple to add a method to do that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 45

[Bug 36148] Move CSRF check code outside of CGI->new
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36148 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36358 [Bug 36358] Typo in errorpage.tt: requets -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10060] Allow adding a branch parameter to the web-based self check to indicate library its used at
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #26 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Christopher Brannon from comment #23) > Then we need to do something like allow the library to navigate their self > check to /cgi-bin/koha/sco/sco-main.pl?branch=BRANCHCODE, which would tell > the page to login to the self check with the credentials from their page. > > AutoSelfCheckAllowed set to allow, but having nothing filled in for > AutoSelfCheckID or AutoSelfCheckPass could be the queue for Koha to check > for credentials under the branch, if specified in the URL. > > Thoughts? Locally we use /cgi-bin/koha/sco/sco-main.pl?branch=BRANCHCODE and then add a hidden input to each operation after that to include the branch. We also have AutoSelfCheckID and AutoSelfCheckPass as well still, but we suffix it with a branchcode so that each branch can have its own particular user and password. Nick's POC is interesting though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8676] Show vendor name in source of acquisition
by bugzilla-daemon＠bugs.koha-community.org 18 Mar '24

18 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It's been a long time - maybe I was worried that the field might be locked for manual input if the value is not linked to a vendor? -- You are receiving this mail because: You are watching all bug changes.

1 0