March 2024 - Koha-bugs - lists.koha-community.org

[Bug 35819] New: "No job found" error for BatchUpdateBiblioHoldsQueue (race condition)
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35819 Bug ID: 35819 Summary: "No job found" error for BatchUpdateBiblioHoldsQueue (race condition) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 29346 A BatchUpdateBiblioHoldsQueue job is triggered from AddRenewal if RealTimeHoldsQueue is set. It is executed inside a transaction and the worker can receive the job to process before the transaction has been committed (and so before the job exists in the DB). The call stack is: opac-renew: AddRenewal In C4::Circulation::AddRenewal 3234 $schema->txn_do(sub{ 3302 $item_object->store({ log_action => 0, skip_record_index => 1 }); In Koha::Item->store 223 Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue( 224 { 225 biblio_ids => [ $self->biblionumber ] 226 } 227 ) unless $params->{skip_holds_queue} or !C4::Context->preference('RealTimeHoldsQueue'); To recreate: Turn on RealTimeHoldsQueue Check an item in to a patron At the OPAC, renew the checkout => Job 109 not found, or has wrong status main:: /kohadevbox/koha/misc/workers/background_jobs_worker.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 68

[Bug 36076] New: paycollect.tt is missing permission checks for manual credit and invoice
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36076 Bug ID: 36076 Summary: paycollect.tt is missing permission checks for manual credit and invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In members/pay.tt one can see permission checks for manual credit and invoice : CAN_user_updatecharges_manual_invoice CAN_user_updatecharges_manual_credit This is missing from members/paycollect.tt. HTML is also missing classes manualcredit and manualinvoice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 35554] New: Authority search popup is only 700px
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554 Bug ID: 35554 Summary: Authority search popup is only 700px Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one : > git grep 'width=' koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open(link+"&result="+defaultvalue,"valuebuilder",'width=700,height=550,toolbar=false,scrollbars=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=550,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 24

[Bug 36009] New: Document koha-worker --queue elastic_index
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36009 Bug ID: 36009 Summary: Document koha-worker --queue elastic_index Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz koha-worker --help currently says: --queue Specify the queue/worker to restart - 'default' is used if not specified current queues are: default, long_tasks We should add elastic_index to the "current queues". "man koha-worker" only says: Allows specifying the queue worker (defaults to 'default'). It would probably make sense to add a line about the actual queues there too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 36150] New: Circulation page styling should match Cataloging styling
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Bug ID: 36150 Summary: Circulation page styling should match Cataloging styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, oleonard(a)myacpl.org Compare both: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl There's no reason for circulation home to differ and not have side margins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 35398] New: EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35398 Bug ID: 35398 Summary: EDI: Fix support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 20595 Bug 20595 introduced support for LRP fields in EDI with StockRotation enabled. However, it missed a case where each order line only contains one item per line. This wasn't spotted in the existing uses as they structure their orders somewhat differently, but is being highlighted at a sight where they regularly order in this way. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595 [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 35351] New: Adjust basket details template to avoid showing empty page-section
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351 Bug ID: 35351 Summary: Adjust basket details template to avoid showing empty page-section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org We shouldn't show an empty page-section div when there are no orders to show. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 35422] New: Unexpected tranlsation string for Suggestions template
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35422 Bug ID: 35422 Summary: Unexpected tranlsation string for Suggestions template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org This string didn't get broken up as expected: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:11 %s %s %s %s &rsaquo; %s Add suggestion &rsaquo; %s %s %s &rsaquo; %s %s &rsaquo; %s &rsaquo; %s %s Maybe we need to wrap the "Add suggestion" as well? -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 36000] New: Fix CGI::param called in list context from catalogue/search.pl
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36000 Bug ID: 36000 Summary: Fix CGI::param called in list context from catalogue/search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org $template->param( sort => $cgi->param('sort_by'), ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 36088] New: Remove useless code form opac-account-pay.pl
by bugzilla-daemon＠bugs.koha-community.org 19 Mar '24

19 Mar '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36088 Bug ID: 36088 Summary: Remove useless code form opac-account-pay.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16