July 2024 - Koha-bugs - lists.koha-community.org

[Bug 36111] New: 856$h should not appear as a link in detailed record
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 Bug ID: 36111 Summary: 856$h should not appear as a link in detailed record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org The newish MARC21 field 856$h is used to store non-functioning urls. However, if a record has data in 856$h (or any 856 subfield), a link "Click here to access online" appears in the results list and detailed record in the opac and the staff interface. To replicate: 1. Add 856$h to MARC editor 1.1. Go to Administration > MARC bibliographic frameworks 1.2. Next to Default framework, click Actions > MARC structure 1.3. Search for field 856 1.4. Click Actions > Edit subfields 1.5. Click h 1.6. Check the Editor box 1.7. Click Save changes 2. Catalog a new record with a random URL in 856$h 2.1. Go to Cataloging 2.2. Click New record 2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c, 245$a, 942$c) 2.4. Go to tab 8 and enter a value in 856$h 2.5. Click Save (No need to add an item) 3. Search for the title in the staff interface (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 3.1. Try to click the link --> Blank page 4. Access the detailed record in the staff interface --> Notice it says "Online resources: Click here to access online" 4.1. Try to click the link --> Blank page 5. Search for the title in the opac (a large enough search to have more than one result) --> Notice it says "Online resources: Click here to access online" 5.1. Try to click the link --> Blank page 6. Access the detailed record in the opac --> Notice it says "Online resources: Click here to access online" 6.1. Try to click the link --> Blank page I don't think 856$h should trigger the link to appear. I managed to hide it from the OPAC by making 856$h invisible in the OPAC, but the link is still there in the staff interface and still leads nowhere... In my opinion, if 856$h is to be displayed, it should only appear in the staff interface detailed record (not results list or opac), and only be regular text, not a link, with the mention (non functional). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 106

[Bug 37283] New: t/db_dependent/selenium/authentication.t is failing
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37283 Bug ID: 37283 Summary: t/db_dependent/selenium/authentication.t is failing Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: RM_priority Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org It's failing on D12 in Jenkins, but also locally in ktd: t/db_dependent/selenium/authentication.t .. # Failed test 'Patron cannot access svc script where circulate permissions are required' # at t/db_dependent/selenium/authentication.t line 135. # 'An Error Occurred' # doesn't match '(?^u:Error 500)' # Looks like you failed 1 test of 17. # Failed test 'not authorized' # at t/db_dependent/selenium/authentication.t line 140. # Looks like you failed 1 test of 7. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 37154] New: Remove all unnecessary uses of unbless
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37154 Bug ID: 37154 Summary: Remove all unnecessary uses of unbless Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In general we should not need to use unbless anywhere in our code. If we are unblessing an object to pass a hashref to a function, that is an indicator that we should update the code called and pass the object itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 37155] New: Remove unnecessary unblessing of patron in CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37155 Bug ID: 37155 Summary: Remove unnecessary unblessing of patron in CanItemBeReserved Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We unbless the patron here to pass to GetAgeRestriction which needs only the patron's dob to perform age calculations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 37342] New: CSRF error - Cannot add new authorities from basic editor with 'Link authorities automatically'
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37342 Bug ID: 37342 Summary: CSRF error - Cannot add new authorities from basic editor with 'Link authorities automatically' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To recreate: 1 - Go to cataloging -> new record 2 - If not in basic editor, switch 3 - Go to tab 100 4 - Enter a name that has no authority in your system: McNotExist, Falsy 5 - Click 'Link authorities automatically' 6 - subfield 9 should turn red, and have an X and a + button 7 - Click the green + 8 - Boom -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 33925] New: Improve translation of title tags: Serials
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33925 Bug ID: 33925 Summary: Improve translation of title tags: Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify serials templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 37206] New: Removing an item from a label batch should be a CSRF-protected POST operation
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37206 Bug ID: 37206 Summary: Removing an item from a label batch should be a CSRF-protected POST operation Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 36192 >From Labels -> Manage label batches -> Edit batch, the list of items in the batch has a "Delete" button for each item. Currently it's a GET operation sent via a link, but I think that should be POSTed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 37252] New: Saving an authority record as MADS (XML) fails
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37252 Bug ID: 37252 Summary: Saving an authority record as MADS (XML) fails Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 37235 Until it has been pushed, you need the patch for bug 37235 to see this, since otherwise you're stopped by a CSRF-related error first. Steps to reproduce: 1. View details for an authority record, e.g. /cgi-bin/koha/authorities/detail.pl?authid=620 2. tail -f /var/log/koha/kohadev/plack-intranet-error.log 3. In the authority details page, Save - MADS (XML) Expected result is a downloaded file of more than zero bytes, Actual result is a zero byte file and the following logged errors: [WARN] XSLT::Base: Unknown IO errorI/O warning : failed to load external entity "http://www.loc.gov/marcxml/xslt/MARC21slimUtils.xsl" compilation error: file /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MADS.xsl element include xsl:include : unable to load http://www.loc.gov/marcxml/xslt/MARC21slimUtils.xsl at /kohadevbox/koha/Koha/XSLT/Base.pm line 346. [WARN] Use of uninitialized value $marc in print at /kohadevbox/koha/authorities/export.pl line 47. If you eventually notice that the URL, which seems to work fine in a browser, is actually sending a 301 to http://www.loc.gov/standards/marcxml/xslt/MARC21slimUtils.xsl and you update the include to that, it still fails. As bug 29556 pointed out, the MADS XSLT is alone in including MARC21slimUtils.xsl from LoC, all our others include our local copy. If we want to have a canary in the coal mine that tells us when that fails, we should make it something which will actually produce a visible failure, not this spectacularly obscure authority format download. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37235 [Bug 37235] Download single authority results in 500 error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 37235] New: Download single authority results in 500 error
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37235 Bug ID: 37235 Summary: Download single authority results in 500 error Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org I'm getting a 500 error when I try to "save" (i.e. download) an authority record. To recreate: 1. Go to Authorities 2. Search for an authority 3. Click on the authority header to access the detailed record page (authorities/detail.pl?authid=XXXX) 4. Click Save > MADS (XML) --> Error 500 5. Redo step 4 with the other formats (MARCXML, MARC (non-Unicode/MARC-8), MARC (Unicode/UTF8) --> Error 500 I get this on KTD with both Zebra and ES7. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 37270] New: Deleting a report from the actions menu on a list of saved reports does not work
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37270 Bug ID: 37270 Summary: Deleting a report from the actions menu on a list of saved reports does not work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 36192 You need at least one saved report to see this. Reports - Use saved - for any listed report in the Actions column click the up-arrow next to Run and choose Delete. Confirm that you want to delete, then nothing happens. Our JS thinks that the DOM is <form> </form> <a href="#" class="delete" title="Delete this saved report"><i class="fa fa-trash-can"></i> Delete</a> And attaches a click handler to .delete at https://git.koha-community.org/Koha-community/Koha/src/commit/10853d1edc9c3… which does `return $(this).siblings('form').submit()`. That fails because there's already a form open above that form, and you can't nest forms, so the form we want to submit doesn't exist because the browser has ignored that tag. Now that we have form-submit.js, we should just use it instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 30