August 2024 - Koha-bugs - lists.koha-community.org

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37748 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37748 [Bug 37748] In Bootstrap 5 "disabled" class must be on anchor tag, not list item -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37746 [Bug 37746] SQL reports: Double class breaks rows per page selection -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 Jonathan Druart <jonathan.druart(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37745 --- Comment #32 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Jake Deery from comment #31) > Would just like to raise that the rows per page dropdown on > guided_reports.pl?op=run seems to be broken. Not sure if it is related to > this bug, but I've only noticed it since today. > > Jake Reported on bug 37745. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37745 [Bug 37745] "Rows per page" not working -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #31 from Jake Deery <jake.deery(a)ptfs-europe.com> --- Would just like to raise that the rows per page dropdown on guided_reports.pl?op=run seems to be broken. Not sure if it is related to this bug, but I've only noticed it since today. Jake -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Pushed follow-up for selenium tests. Is anyone working on the remaining fails? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Why do we have almost the same errors/messages appear twice in the OPAC template? koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt [% ELSIF failure %] ... [% UNLESS can_be_discharged %] ... I like that this makes the code cleaner looking and I also like to see this fixed. Please have a look at this and my previous comment for the template changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |additional_work_needed --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think this will always show the note about checkouts: - [% ELSIF has_issues %] - You cannot be discharged, you have checked out items. Please return items before asking for a discharge. + [% ELSIF failure %] + You cannot be discharged because you have checked out items. Please return your checked out items before asking for a discharge. + <ul> + [% IF has_debt %] + <li>You have unpaid charges. Please pay your charges before reapplying.</li> + [% END %] + [% IF has_issues %] + <li>You have checked out items. Please return your checked out items before reapplying.</li> + [% END %] + [% IF !has_issue and !has_debt %] + <li>You cannot be discharged for an unknown reason. Please contact library staff for more information.</li> + [% END %] + </ul> I believe we should remove/rephrase the line? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can generate discharge for |Don't allow to generate |patrons with fines |discharges for patrons with | |fines Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #29 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Jonathan Druart from comment #28) > 2. > # Failed test 'Update child to patron' > # at t/db_dependent/selenium/update_child_to_adult.t line 153. > Error while executing command: unexpected alert open: Dismissed user prompt > dialog: Are you sure you want to update this child to an Adult category? > This cannot be undone. at /usr/share/perl5/Selenium/Remote/Driver.pm line > 411. > > This is happening because the "Update child to adult" item in the "More" > menu (members module) is clickable. There is a tooltip and prior to this > change the item was not clickable and we didn't get the alert. Related to this, it seems that the next entry "Export today's checked in barcodes" is not shown and disabled when needed. We certainly want this change: [% IF Koha.Preference('intranetreadinghistory') %] - [%IF ( privacy == 2 ) %] + [%IF ( patron.privacy == 2 ) %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35402] Update the OPAC and staff interface to Bootstrap 5
by bugzilla-daemon＠bugs.koha-community.org 27 Aug '24

27 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 --- Comment #28 from Jonathan Druart <jonathan.druart(a)gmail.com> --- (In reply to Jonathan Druart from comment #27) > Created attachment 170745 [details] [review] > Bug 35402: Fix some selenium tests This patch fixes the following tests: t/db_dependent/selenium/administration_tasks.t t/db_dependent/selenium/authentication_2fa.t t/db_dependent/selenium/patrons_search.t 2 others are not fixed: 1. t/db_dependent/selenium/regressions.t .. 5/9 Error while executing command: no such element: Unable to locate element: //span[@id="audio-alert"]/audio[@src="/intranet-tmpl/prog/sound/beep.ogg"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. opening.ogg is played instead of beep.ogg (change in behaviour). Is that expected? In my understanding it's happening because we know have a modal in the DOM with the class "audio-alert-action": <div id="circ-warnwaitingholds-modal" class="modal audio-alert-action block"> 2. # Failed test 'Update child to patron' # at t/db_dependent/selenium/update_child_to_adult.t line 153. Error while executing command: unexpected alert open: Dismissed user prompt dialog: Are you sure you want to update this child to an Adult category? This cannot be undone. at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. This is happening because the "Update child to adult" item in the "More" menu (members module) is clickable. There is a tooltip and prior to this change the item was not clickable and we didn't get the alert. -- You are receiving this mail because: You are watching all bug changes.

1 0