September 2024 - Koha-bugs - lists.koha-community.org

[Bug 27730] New: Innocent changes to framework silently delete bibliographic data
by bugzilla-daemon＠bugs.koha-community.org 09 May '25

09 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730 Bug ID: 27730 Summary: Innocent changes to framework silently delete bibliographic data Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: ian.bays(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you copy and change a framework and either delete a subfield in the new framework or mark the subfield tab as "ignore", then any bib data with data in that subfield, when saved in the new framework will be silently destroyed with no option to undo. Test Plan to confirm behaviour: 1. Create bib record in default framework with minimal data, but add tag 365 (as it has a number of subfields all visible) and populate subfields a through h with "fa" through "fh". Save the record and with sql check the contents of the metadata. (I found this SQL gives enough information substituting the correct bib number of the saved record: select tagfield, tagsubfield, frameworkcode, tab, hidden, (select ExtractValue(metadata, '//datafield[@tag="365"]/subfield[@code>="a"]') from biblio_metadata where biblionumber = 37002 and (select frameworkcode from biblio where biblionumber = 37002) = marc_subfield_structure.frameworkcode) tv from marc_subfield_structure where frameworkcode in ('', 'TEST') and tagfield = '365'; ) 2. Copy the default framework to a TEST framework and set (say 365$b to tab ignore and delete 365$d). (I used export the default framework to a csv, create new TEST framework and import from the saved default csv) 3. Edit the bib record and change framework to TEST framework (settings > change framework) and save the record. 4. Run the SQL again and observe the data from subfields b and d have both disappeared from the metadata. If you were to rerun these tests you may need to reload memcache to ensure the newly changed frameworks are picked up. I understand it has been broadly known by some long-term Koha users that deleting a subfield from the framework has this effect, but both these situations potentially cause bib data to be silently and permanently delated from the database. Many users will be unaware and may not discover the problem for some time. Potential solutions might include: a) For subfields not in the framework or with tab "ignore" allow the data to be saved as is on saving for edit; b) When selecting "change framework" detect if data would be lost and alert the user with an option to back out of the change without losing data; c) Do not allow deletion of a subfield from a framework and do not allow the "ignore" option for the tab. If a field is to be ignored but hidden there are plenty of visibility options in the framework. NB: The current delivered default framework has 13 subfields set to the "ignore" tab. I cannot see what purpose these serve as no data can survive within them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 35581] New: ILL Koha classes are not consistent
by bugzilla-daemon＠bugs.koha-community.org 08 May '25

08 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Bug ID: 35581 Summary: ILL Koha classes are not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 127

[Bug 35083] New: Koha::Illbatchstatus should be kosher
by bugzilla-daemon＠bugs.koha-community.org 08 May '25

08 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35083 Bug ID: 35083 Summary: Koha::Illbatchstatus should be kosher Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The following methods should just be overloading their counterparts and follow what we do everywhere else: * create_and_log => overloaded store * update_and_log => overloaded store * delete_and_log => overloaded delete Also, tests need to be placed in t/db_dependent/Koha/Illbatchstatus.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 35082] New: Koha::Illbatch should be kosher
by bugzilla-daemon＠bugs.koha-community.org 08 May '25

08 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35082 Bug ID: 35082 Summary: Koha::Illbatch should be kosher Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The following methods should just be overloading their counterparts and follow what we do everywhere else: * create_and_log => overloaded store * update_and_log => overloaded store * delete_and_log => overloaded delete Also, tests need to be placed in t/db_dependent/Koha/Illbatch.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 26500] New: Automatic renewals show incorrect count of renewals allowed when CircControl is set to "the library you're logged in at"
by bugzilla-daemon＠bugs.koha-community.org 08 May '25

08 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26500 Bug ID: 26500 Summary: Automatic renewals show incorrect count of renewals allowed when CircControl is set to "the library you're logged in at" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When CircControl is set to "the library you're logged in at," the Renew column in the patron checkouts table will show the count of permitted renewals based on the library you're logged in at. This is correct for manual renewals, since those are the rules that will be enforced. However, for automatic renewals this can mean we're showing the user an incorrect number. To recreate: - Create an All Libraries rule that allows 10 renewals - Create a rule for branch A that allows 1 renewal - Creare a rule for branch B that allows 99 renewals - Check an item out from Branch A, set to auto-renew - While logged in as Branch A, confirm Koha tells you you have 1 renewal available - Log in as Branch B, see you have 99 renewals - Log in as Branch C, see you have 10 renewals - Set No Renewal Before to allow renewal immediately - run the auto_renew cron, item renews once - run the auto-renew cron again, confirm too_many error because only 1 renewal is allowed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 37995] New: (Bug 29948 follow-up) Make display author information more configurable
by bugzilla-daemon＠bugs.koha-community.org 08 May '25

08 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37995 Bug ID: 37995 Summary: (Bug 29948 follow-up) Make display author information more configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 29948 There is a problem with displaying author's identifiers while OPACAuthorIdentifiersAndInformation is on for 024$2$a. At the current, the list of identifiers source is closed and hardcoded. So if it happens that in an authority record a 024 field exists with $2 from outside the list (like wikidata or other from the official list https://www.loc.gov/standards/sourcelist/standard-identifier.html) an empty bullet with no information is being displayed. This could be corrected either by filtering out the 024 fields in Koha::Authority::get_identifiers_and_information, or by correcting the template (authority-information.inc). However, this would only be a halfway solution. A more appropriate solution might be to introduce a sub-preference containing the triplets: source code ($2), label, URI prefix. E.g.: wikidata, Wikidata, http://www.wikidata.org/wiki/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29948 [Bug 29948] Display author information for researchers -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 31188] New: UPC or ASIN from amazon for dvd, music cds image
by bugzilla-daemon＠bugs.koha-community.org 07 May '25

07 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188 Bug ID: 31188 Summary: UPC or ASIN from amazon for dvd, music cds image Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: julie.emond(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Hi, We would like, in the same way as the isbn for books, that the UPC code or the ASIN for amazon enter automatically for the display of images for dvds and music cds. In short for other documents that do not have an isbn. On other request we see that some have briefly talked about it but no solution except to enter the images by hand has been submitted. A gateway between amazon and koha for the UPC code in the same way as we have a gateway for the simagette with an ISBN. Thank you for your help -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 18315] New: authentication and authorization refactoring
by bugzilla-daemon＠bugs.koha-community.org 07 May '25

07 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18315 Bug ID: 18315 Summary: authentication and authorization refactoring Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: oha(a)oha.it QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Currently, C4::Auth is responsible to do session management, authentication and authorization. There is no clear separations between them, and the authentication is not modular, making it increasingly harder to maintain and/or introduce no authentication integrations. I was experimenting on this for a while, and I managed to put together few commits in a branch. It started as a proposal, but turned out to be working in _most_ of my tests. here more details: I completely removed any need for CGI and CGI::Session while maintaining a fork-exec aproach to the scripts. (This made it easier to implement Koha::Middleware::Session, Koha::Session::DB and ::KohaCache) Koha::Middleware::Session inject a session object in the Plack request, and invoke Koha::Auth if any authentication tokens are available. Koha::Auth has a list of modules which will be invoked in turn and could be enabled/disabled plack.psgi is changed as well, it has enabled the new Middleware and the applications used are no longer Plack::App::CGIBin but Koha::Middleware::App. here few of the things i want to do to simplify the interaction with the current "legacy" code: I didn't change the scripts or any other module at all, instead I tried to hijack C4::Auth methods to rely on Koha::Session and Koha::Auth. This make it simple to switch back to the previous plack.psgi OR using apache and the normal cgi-bin. authentication should happen upfront, before the script is even started. script will have to verify authorization. authentication MUST be modular, possibly having different systems cooperate. (Some serious discussions must be around this point, especially about accounting and authority) what needs to be done: permissions should be reintroduced. right now permissions are read for the user and set in the template, but no checks are perform on requests. (should be fairly simple to do) reintroduce the code related to shib, cas and any other. more testing, especially for the installer (there is lots of code regarding the web installer which isn't there anymore) -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 36546] New: API yaml validation is slow.
by bugzilla-daemon＠bugs.koha-community.org 07 May '25

07 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 Bug ID: 36546 Summary: API yaml validation is slow. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org >From an strace it can take up to 6 sec on our servers. Ex: First stat: 07:48:46.941069 (+ 0.000129) brk(0x5641224ad000) = 0x5641224ad000 <0.000018> 07:48:46.941340 (+ 0.000015) stat("/home/koha/src/api/v1/swagger/swagger.yaml", {st_mode=S_IFREG|0644, st_size=30696, ...}) = 0 <0.000010> ... last one 07:48:53.453980 (+ 0.000030) lstat("/home/koha/src/api/v1/swagger/swagger.yaml", {st_mode=S_IFREG|0644, st_size=30696, ...}) = 0 <0.000015> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 79

[Bug 36958] New: Internal server error when importing MARC file with bad encoding into an order
by bugzilla-daemon＠bugs.koha-community.org 06 May '25

06 May '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36958 Bug ID: 36958 Summary: Internal server error when importing MARC file with bad encoding into an order Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org Created attachment 167168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167168&action=e… Test record in MARC 8 with an encoding error (uses extended character set for Simplified Chinese characters) To reproduce: 1. Go to Cataloguing > Stage Records for Import 2. Upload the attached example file, which is encoded in MARC 8 3. Select the correct encoding and stage the file for import 4. Find or create an open basket in the Acquisitions module 5. Click Add to basket 6. Select From a staged file 7. Select the file that was just staged --> Page crashes with Internal Server Error (or a stack trace if you're testing in KTD) On the other hand, if you return to Cataloguing > Manage Staged Records and import the staged file from there, the import completes and the records are added to the catalog. The badly encoded biblio records can still be viewed (and the biblio detail page displays a warning about the bad encoding). Not sure if it makes sense to allow addorderiso2709.pl to simply import the bad record anyway like manage-marc-import.pl does, or if that would break something else in the ordering process. At the very least it should display an error message instead of crashing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3