January 2025 - Koha-bugs - lists.koha-community.org

[Bug 38646] New: C4::Languages::getLanguages is very unreasonably slow (100+ ms)
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38646 Bug ID: 38646 Summary: C4::Languages::getLanguages is very unreasonably slow (100+ ms) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: schodkowy.omegi-0r(a)icloud.com QA Contact: testopia(a)bugs.koha-community.org My profiling with NYTProf has found that the call to C4::Languages::getLanguages is unreasonably slow, taking over 100 ms (and that's just on a single call of it apparently!!!). Indeed, the way it's coded, it'd run over 540 SQL queries for no good reason, slowing the already slow catalog search page loading further down. This patch is gonna replace the inefficient and complicated function logic with proper SQL statement that joins the relevant functions. It also fixes the bug where user's native language would be displayed with native language in the parenthesis as well, such as "Polski (Polski)" instead of just "Polski". The whole query is pretty fast and it gets cached by MySQL server, meaning it's runtime is measured in microseconds instead of hundreds of miliseconds, making it easily a 1000x+ improvement. The nested CASE statements are a bit verbose, but not too bad, I figured it might be better to do that rather than select all the vars as temporary columns and later remove them or re-create the new object to return. Instead, no temporary variables that one has to remove will linger... Please note that I didn't test the actual code since I don't have a working ktd installation by hand, but I did test the SQL statement thoroughly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51

[Bug 38846] New: Only call getLanguages for advanced search pages
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38846 Bug ID: 38846 Summary: Only call getLanguages for advanced search pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org The output of getLanguages() is only used in the advanced search page and not in search results, so it should only be called for the former action. As per comments on bug 16734 and bug 38646, the performance difference is minor on a quiet system, but it could have an impact on a busier system, and it's always good to cut down on unnecessary database calls where possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 38855] New: test/README not removed by bug 22056
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38855 Bug ID: 38855 Summary: test/README not removed by bug 22056 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 22056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 [Bug 22056] Remove test/search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 38857] New: Cronjobs should log their start and command line parameters before processing options
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38857 Bug ID: 38857 Summary: Cronjobs should log their start and command line parameters before processing options Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz When a cronjob is passed bad parameters it may fail. If it does so before logging its start, there is no trace that it was even attempted We should move the logging to before the options are fetched to ease troubleshooting To test: 1 - Enable CronjobLog 2 - On command line: perl misc/cronjobs/cleanup_database.pl --old_reservers 550 3 - Error on command line 4 - In staff client, go to Tools->Log viewer, check 'Cronjobs' and submit 5 - No entries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 38926] New: POST /biblios returns 200 even if AddBiblio fails
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38926 Bug ID: 38926 Summary: POST /biblios returns 200 even if AddBiblio fails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com Depends on: 31800 For some reasons I POSTed an invalid biblio to /api/v1/biblios it returned {id: null} The biblio record is not created, but the response is 200. 707 my ( $biblio_id ) = AddBiblio( $record, $frameworkcode, { record_source_id => $record_source_id } ); 708 709 $c->render( 710 status => 200, 711 openapi => { id => $biblio_id } 712 ); Obviously we should test $biblio_id Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31800 [Bug 31800] Add POST endpoint for Biblios -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 38929] New: POST endpoints not returning the Location header
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Bug ID: 38929 Summary: POST endpoints not returning the Location header Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com I found `POST /biblios` is not returning it. Opening this bug to track and fix such problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 44

[Bug 35202] New: Table Settings change does not hide all serial_notes (OPAC).
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35202 Bug ID: 35202 Summary: Table Settings change does not hide all serial_notes (OPAC). Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: r.delahunty(a)arts.ac.uk QA Contact: testopia(a)bugs.koha-community.org We have multiple subscriptions for some serials and we have public-inappropriate notes which we want to hide. Editing the subscriptionst view of the subscriptions table in OPAC to hide the serial_notes field should make the serial_notes invisible for all subscriptions. It only vanishes from the first subscription displayed. Other subscriptions expose the serial_note data. Hiding the serial_notes via Table Settings should apply to all subscriptions. Related to Bug 22179? (But the data we have there should be elsewhere, so Bug 33298 interests us). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 38847] New: Renewing a child without guarantor whith ChildNeedsGuarantor results in an internal server error
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38847 Bug ID: 38847 Summary: Renewing a child without guarantor whith ChildNeedsGuarantor results in an internal server error Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: 1 - Create a child, make sure it has no guarantor 2 - Set ChildNeedsGuarantor to Yes 3 - Renew the child -> you will have an internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 38649] New: Searching for a patron from additem.pl triggers an issue slip to print
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38649 Bug ID: 38649 Summary: Searching for a patron from additem.pl triggers an issue slip to print Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: blawlor(a)clamsnet.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 37407 fixed automatic checkout of items that were fast cataloged from the circulation module. To reproduce: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 38657] New: Previewing cover images from OPAC search results - image obscured by the search results menu bar
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Bug ID: 38657 Summary: Previewing cover images from OPAC search results - image obscured by the search results menu bar Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org With cover images enabled, if you click on the cover image in the OPAC search results, the image preview is partially hidden behind the search results menu bar. This may depend a little on the size of the image uploaded or returned from the cover image service. To replicate: 1. Enable LocalCoverImages and OPACLocalCoverImages system preferences. 2. Add a cover image to a record. 3. In the OPAC: 3.1 Do a search that will return the record with the cover image in the search results 3.2 Click on the cover image in the search results list 3.3 Note that the image is partially obscured behind the search results menu bar. -- You are receiving this mail because: You are watching all bug changes.

1 20