January 2025 - Koha-bugs - lists.koha-community.org

[Bug 38810] New: SIP account level system preference overrides not properly cleared between requests
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38810 Bug ID: 38810 Summary: SIP account level system preference overrides not properly cleared between requests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Account level syspref overrides in SIP will "leak" between SIP requests. Basically an account level system preference override will may be set by a given request, but those overrides will never be cleared for the life of that SIP process thus "contaminating" that process until it reaches end of life". This is because the code # Clear overrides from previous message handling first foreach my $key ( keys %ENV ) { delete $ENV{$key} if index($key, 'OVERRIDE_SYSPREF_') > 0; } is checking if the env key contains the substring OVERRIDE_SYSPREF_ at an index greater than 0. The problem is that for all overrides the subtring *starts at 0* since it's always the first part of the string. If the substring is not part of the string index will return -1. TLDR we have an "off by one" error. We need to check that the return value is non-negative instead of positive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 38827] New: New search performed when column filters lose focus
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38827 Bug ID: 38827 Summary: New search performed when column filters lose focus Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com On a table using DataTables and the REST API wrapper with the column filters, if one input is used to filter the table the query will be made twice: when the user stopped typing and when the input will lose the focus. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 36836] New: Review eUsage module for translation issues
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836 Bug ID: 36836 Summary: Review eUsage module for translation issues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: f.demians(a)tamil.fr, jonathan.druart(a)gmail.com, matt.blenkinsop(a)ptfs-europe.com, michaela.sieber(a)kit.edu When testing the eUsage module in 23.11 we noticed a lot of untranslated strings. It might be worth combing through those files to check all strings are marked for translation correctly and then have a second go checking they show up after translating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 51

[Bug 38104] New: share_usage_with_koha_community.pl: Check between two runs should be a bit lower than 30d
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38104 Bug ID: 38104 Summary: share_usage_with_koha_community.pl: Check between two runs should be a bit lower than 30d Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz >From production data: HEA preference: 1725159125 select FROM_UNIXTIME( 1725159125 ); | 2024-09-01 04:52:05 | select * from action_logs where timestamp>'2024-10-01' and module='CRONJOBS' and script like '%usage%'; | 7429456 | 2024-10-01 04:52:04 | 0 | CRONJOBS | Run | 116996 | /usr/share/koha/misc/cronjobs/share_usage_with_koha_community.pl | cron | share_usage_with_koha_community.pl | | 7429457 | 2024-10-01 04:52:04 | 0 | CRONJOBS | End | 116996 | /usr/share/koha/misc/cronjobs/share_usage_with_koha_community.pl COMPLETED | cron | share_usage_with_koha_community.pl | So the HEA update was skipped since the script was 1 second too early :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 33

[Bug 38232] New: Materials specified note un-checks Forgive overdue charges box
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38232 Bug ID: 38232 Summary: Materials specified note un-checks Forgive overdue charges box Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: hebah(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: FinesMode on, have an item with a materials specified note (952$3). Check in item with 'forgive overdue charge' selected, no materials note, box stays checked. Materials note checkin deselects the box. There have been similar issues with things deselecting a check in box (wrong transfer, bug 36199), and I know materials specified notes can interact with things like since-fixed bug 29671 (materials note items deselecting book drop mode), or current bug 37424 (batch checkout silently failing with materials notes) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 38448] New: Fix inconsistencies in database update messages
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Bug ID: 38448 Summary: Fix inconsistencies in database update messages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: tomascohen(a)gmail.com Depends on: 38394 Moved from bug 38394: * "Added OAI-PMH:HarvestEmailReport system preference" should be "Added new system preference 'OAI-PMH:HarvestEmailReport'" * Added new system preference 'JobsNotificationMethod' is white instead of green * Added column 'service_platformerm_usage_data_providers' is blue (why not green?) * "list_borrowers added to 1 users with manage_bookings" should be better worded, like "Added permissions 'permission' to ..." * "Added BOOKING_CANCELLATION authorised value category" should be "Added new authorised value category 'CAT'" * "Updated manage_search_targets permission description" => this is only noise Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 [Bug 38394] Remove try/catch and say_failures for 24.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 38646] New: C4::Languages::getLanguages is very unreasonably slow (100+ ms)
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38646 Bug ID: 38646 Summary: C4::Languages::getLanguages is very unreasonably slow (100+ ms) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: schodkowy.omegi-0r(a)icloud.com QA Contact: testopia(a)bugs.koha-community.org My profiling with NYTProf has found that the call to C4::Languages::getLanguages is unreasonably slow, taking over 100 ms (and that's just on a single call of it apparently!!!). Indeed, the way it's coded, it'd run over 540 SQL queries for no good reason, slowing the already slow catalog search page loading further down. This patch is gonna replace the inefficient and complicated function logic with proper SQL statement that joins the relevant functions. It also fixes the bug where user's native language would be displayed with native language in the parenthesis as well, such as "Polski (Polski)" instead of just "Polski". The whole query is pretty fast and it gets cached by MySQL server, meaning it's runtime is measured in microseconds instead of hundreds of miliseconds, making it easily a 1000x+ improvement. The nested CASE statements are a bit verbose, but not too bad, I figured it might be better to do that rather than select all the vars as temporary columns and later remove them or re-create the new object to return. Instead, no temporary variables that one has to remove will linger... Please note that I didn't test the actual code since I don't have a working ktd installation by hand, but I did test the SQL statement thoroughly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51

[Bug 38846] New: Only call getLanguages for advanced search pages
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38846 Bug ID: 38846 Summary: Only call getLanguages for advanced search pages Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org The output of getLanguages() is only used in the advanced search page and not in search results, so it should only be called for the former action. As per comments on bug 16734 and bug 38646, the performance difference is minor on a quiet system, but it could have an impact on a busier system, and it's always good to cut down on unnecessary database calls where possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 38855] New: test/README not removed by bug 22056
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38855 Bug ID: 38855 Summary: test/README not removed by bug 22056 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 22056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 [Bug 22056] Remove test/search.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 38857] New: Cronjobs should log their start and command line parameters before processing options
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '26

20 Apr '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38857 Bug ID: 38857 Summary: Cronjobs should log their start and command line parameters before processing options Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz When a cronjob is passed bad parameters it may fail. If it does so before logging its start, there is no trace that it was even attempted We should move the logging to before the options are fetched to ease troubleshooting To test: 1 - Enable CronjobLog 2 - On command line: perl misc/cronjobs/cleanup_database.pl --old_reservers 550 3 - Error on command line 4 - In staff client, go to Tools->Log viewer, check 'Cronjobs' and submit 5 - No entries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16