February 2025 - Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172659|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178671&action=e… Bug 10190: Rebase for rspack Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172658|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178670&action=e… Bug 10190: Update for bootstrap 5 Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172657|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178669&action=e… Bug 10190: Clarify workflow This patch re-arranges the edit/add modal form to clarify the need to select context, then decide on editing an existing trigger or adding a new one and then, and only then, exposes the actual rule inputs Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172656|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178668&action=e… Bug 10190: Add custom input for delay This custom input allows for dynamic min/max rules and it updates the input styling to match other inputs on the page including a 'clear' button. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172655|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178667&action=e… Bug 10190: Modal form improvements We now fetch all rules on modal open and the effective rule on context selection. This allows us to compare the specific values of the rule we're adding/editing to the fallback values present in the all rules set. We use the fallback rule values as placeholders in the input boxes to highlight to the end user what value will be used should they choose to wipe the input. We also allow wiping inputs and pass 'null' to the API appropriately. Finally, we set a minimum value for delay when adding a new rule to highlight to the user that the new trigger will be added after existing triggers. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172654|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178666&action=e… Bug 10190: Restore 'edit' from 'Add/Edit' Modal Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172653|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178665&action=e… Bug 10190: Display effective values and highlight them Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172652|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178664&action=e… Bug 10190: Rework logic of overdue_notices The original logic for digesting overdues in the overdue notices script was flawed given the additional itemtype handling introduced in this patchset and the way in which it handles effective fallbacks for rules. This patch tidies the file and reworks the logic so that we fetch overdues by patron category and branch and then iterate through those comparing to the correct effective rules and combing them into digest groups based on notice + trigger level. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172651|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178663&action=e… Bug 10190: Add comments to overdue_notices and rename variable Trying to fully understand how this script operates.. this patch adds some notes to the script for developers and also renames a variable that I found was being re-used. Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '25

25 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172650|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize (ashimema) <martin.renvoize(a)ptfs-europe.com> --- Created attachment 178662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178662&action=e… Bug 10190: Update itiva script to reflect move to circ_rules Sponsored-by: Glasgow Colleges Library Group <https://library.cityofglasgowcollege.ac.uk> Signed-off-by: George Harkins <George.Harkins(a)cityofglasgowcollege.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0