February 2025 - Koha-bugs - lists.koha-community.org

[Bug 22223] New: Item url double-encode when parameter is an encoded URL
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223 Bug ID: 22223 Summary: Item url double-encode when parameter is an encoded URL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- The following use of the "url" filter is problematic: [% IF Koha.Preference("OPACURLOpenInNewWindow") %] <a target="_blank" rel="noreferrer" href="[% ITEM_RESULT.uri | url %]" property="url">[% ITEM_RESULT.uri | html %]</a> [% ELSE %] <a href="[% ITEM_RESULT.uri | url %]" property="url">[% ITEM_RESULT.uri | html %]</a> [% END %] If ITEM_RESULT.uri is "https://idp.com?redirect_url=https%3A%2F%2Fsomewhere_else.com", then the percent signs in the argument to the "redirect_url" parameters will be encoded incorrectly and the result will be "https://idp.com?redirect_url=https%253A%252F%252Fsomewhere_else.com", which is obviously an invalid URL. Can we really expect that no one will ever include a URL with URI encoded parameters? -- You are receiving this mail because: You are watching all bug changes.

1 85

[Bug 30397] New: Duplicate '20' option in dropdown 'Show entries' menu
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30397 Bug ID: 30397 Summary: Duplicate '20' option in dropdown 'Show entries' menu Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On the members-home.pl page and the members/search.pl pop-up, the dropdown menu to select the number of shown entries, there is two times the option for '20' results. Seen on master and 20.11.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 37365] New: Bad redirect when adding a patron message from members/files.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37365 Bug ID: 37365 Summary: Bad redirect when adding a patron message from members/files.pl Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1. Set 'EnableBorrowerFiles' to 'Do'. 2. Find a patron record 3. Upload a file 4. Once the upload completes 'Add message' and save 5. You are redirected to /cgi-bin/koha/members/files.pl with a message like: "Patron not found. Return to search" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 34709] New: Eliminate event handler attributes in the OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34709 Bug ID: 34709 Summary: Eliminate event handler attributes in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org There aren't too many event handler attributes left in the OPAC, so I'm hoping to do a blitz on them and have this be the umbrella report. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 35126] New: Remove the use of event attributes from opac-addbybiblionumber.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35126 Bug ID: 35126 Summary: Remove the use of event attributes from opac-addbybiblionumber.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org There are some event attributes in opac-addbybiblionumber.pl. These should be removed in favour of defining events in JavaScript. ./opac/opac-addbybiblionumber.pl: print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"window.opener.location.reload(true);self.close();\"></body></html>"; ./opac/opac-addbybiblionumber.pl: print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"self.close();\"></body></html>"; -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 37863] New: Patron card batches don't detect when the patron is already in the list
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37863 Bug ID: 37863 Summary: Patron card batches don't detect when the patron is already in the list Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: adolfo.rodriguez(a)xercode.es QA Contact: testopia(a)bugs.koha-community.org When adding patrons to a batch from the modal the include file patron-search.inc is designed to show a success message (Patron '%s' added) or an error message (Patron '%s' is already in the list.) depending on the result of the function add_user. If add_user returned a negative number, it would show the error message. Otherwise it shows the success message. The problem is that the function add_user at the template edit_batch.tt doesn't return anything, so the system always adds the user, thus allowing to include several times the same user in the card batch. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 38329] New: Remove orphan confirm_deletion() in supplier.tt
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Bug ID: 38329 Summary: Remove orphan confirm_deletion() in supplier.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: phil(a)chetcolibrary.org Reporter: phil(a)chetcolibrary.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 28082 A dozen years ago, we used YUI rather than Bootstrap, and https://git.koha-community.org/Koha-community/Koha/src/commit/f05a8c839f7bd… was actually used. The switch to Bootstrap duplicated the function in koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc, so we had two of them with slightly different strings (and I'm not going down the rabbit-hole of which one was actually used), until bug 28082 switched it from a link with href="javascript:confirm_deletion()" to a form a couple of years ago. Luckily, that was on 22.05, before every currently supported version, so it doesn't matter which one was used, because there's only one and it is unused on every current version. Now, it's just a complete orphan which gives a false-positive for anyone looking for the ?op="delete" which will fail due to CSRF protection. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 [Bug 28082] Add acquisitions toolbar to vendors on vendor search page -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 38100] New: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38100 Bug ID: 38100 Summary: Items with damaged status are shown in OPAC results as "Not available" even with AllowHoldsOnDamagedItems Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: januszop(a)gmail.com Reporter: januszop(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: pmis(a)mnw.art.pl Items with damaged status are shown on the OPAC results page as "Not available" even with AllowHoldsOnDamagedItems set to 'Allow', which is misleading for the users. 'other/Damaged' status should be assigned only if AllowHoldsOnDamagedItems is set to 'Don't allow'. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 38322] New: Wrong comment in t/db_dependent/api/v1/erm_users.t
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38322 Bug ID: 38322 Summary: Wrong comment in t/db_dependent/api/v1/erm_users.t Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The test creates two users, and says list should return both, however, the user performing the call doesn't have 'view_borrower_infos_from_any_libraries' permission and only lists 1, which is what the test checks -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 24690] New: Make OPACPopupAuthorsSearch work with search terms containing parenthesis
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '25

03 Feb '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug ID: 24690 Summary: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org As noted in bug 13327 this feature doesn't work when the selected search terms contain (). No results will be found. -- You are receiving this mail because: You are watching all bug changes.

1 19