July 2025 - Koha-bugs - lists.koha-community.org

[Bug 39286] New: BackgroundJob.t should mock_config
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 Bug ID: 39286 Summary: BackgroundJob.t should mock_config Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 35655 Blocks: 34070 Bug 35655 needed to mock the config, but instead introduced new env variables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34070 [Bug 34070] background_jobs_worker.pl floods logs when it gets error frames https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35655 [Bug 35655] Make it possible to switch off RabbitMQ without any warns in logs/about page -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 34070] New: background_jobs_worker.pl fills logs when not connecting
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34070 Bug ID: 34070 Summary: background_jobs_worker.pl fills logs when not connecting Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org I noticed my disk was filling up, because worker-output.log was getting several hundred of these per second: [2023/06/20 18:21:24] [WARN] Frame not processed - malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "You must log in usin...") at /usr/share/koha/bin/background_jobs_worker.pl line 116. main::catch {...} /usr/share/koha/bin/background_jobs_worker.pl (119) I think the problem is related to this code: 106 while (1) { 107 if ( $conn ) { 108 my $frame = $conn->receive_frame; 109 if ( !defined $frame ) { 110 # maybe log connection problems 111 next; # will reconnect automatically 112 } 113 114 my $args = try { 115 my $body = $frame->body; 116 decode_json($body); # TODO Should this be from_json? Check utf8 flag. 117 } catch { 118 Koha::Logger->get({ interface => 'worker' })->warn(sprintf "Frame not processed - %s", $_); 119 return; 120 } finally { 121 $conn->ack( { frame => $frame } ); 122 }; 123 124 next unless $args; 125 126 # FIXME This means we need to have create the DB entry before 127 # It could work in a first step, but then we will want to handle job that will be created from the message received 128 my $job = Koha::BackgroundJobs->find($args->{job_id}); There is a problem with the connection, but $conn is still defined, so this code is run. When I Dump $conn after line 107 it looks like this: $VAR1 = bless( { 'bufsize' => 8192, 'logger' => bless( { 'warn' => 1, 'error' => 1, 'fatal' => 1 }, 'Net::Stomp::StupidLogger' ), '_framebuf_changed' => 1, 'port' => '61613', 'connect_delay' => 5, '_pid' => ***, 'hostname' => 'localhost', 'reconnect_attempts' => 0, 'reconnect_on_fork' => 1, 'select' => bless( [ '�', 1, undef, undef, undef, undef, undef, undef, undef, bless( \*Symbol::GEN0, 'IO::Socket::IP' ) ], 'IO::Select' ), 'socket' => $VAR1->{'select'}[9], 'initial_reconnect_attempts' => 1, '_framebuf' => '', 'socket_options' => {}, 'subscriptions' => { 'dest-/queue/koha_***-default' => { 'ack' => 'client', 'destination' => '/queue/koha_***-default', 'prefetch-count' => 1 } } }, 'Net::Stomp' ); If I dump the contents of $body after line 115, I get 'You must log in using CONNECT first'. Not sure why that happens yet, but how we handle it seems to be problematic. We fail to decode it, because it is not JSON. So the "catch" block is run and logs the problem. But then I think the "return" kicks us back to the start of the "while" and we end up logging the same error as fast as we can, which seems to be pretty fast. And we never get to the "ack" on line 121. The comment "will reconnect automatically" seems to be a little optimistic? Moving the "return" from the end of the "catch" block, to the end of the "finally" block slows things down, now the logging only happens about every other second. But there is also a problem because we are assigning the "output" from the try/catch to $args. If we can decode_json the $body, that works as expected. But if we execute the "catch" block, it looks like $args gets assigned the result of Koha::Logger->get, which seems to be 1. So $args is defined on line 124 and we get to Koha::BackgroundJobs->find, but using "1" as a hashref there does not work. I think maybe something like this would work better: my $args; try { my $body = $frame->body; $args = decode_json($body); # TODO Should this be from_json? Check utf8 flag. } catch { Koha::Logger->get({ interface => 'worker' })->warn(sprintf "Frame not processed - %s", $_); } finally { $conn->ack( { frame => $frame } ); return; }; Is the return needed? This is a little above my head, so other solutions are most welcome. And if anyone can tell me why I get 'You must log in using CONNECT first' I would be most grateful. :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 58

[Bug 39995] New: Koha/Biblio.t can fail on slow servers
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39995 Bug ID: 39995 Summary: Koha/Biblio.t can fail on slow servers Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 16:35:27 koha_1 | # Failed test 'timestamp is added to the biblio object' 16:35:27 koha_1 | # at t/db_dependent/Koha/Biblio.t line 594. 16:35:27 koha_1 | # got: '2025-05-23T14:32:59+00:00' 16:35:27 koha_1 | # expected: '2025-05-23T14:33:00+00:00' 16:35:27 koha_1 | # Looks like you failed 1 test of 34. 16:35:27 koha_1 | 16:35:27 koha_1 | # Failed test 'to_api() tests' 16:35:27 koha_1 | # at t/db_dependent/Koha/Biblio.t line 608. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 39747] New: Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39747 Bug ID: 39747 Summary: Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Correct preference is 'DefaultHoldExpirationdateUnitOfTime'. Also no reason for ";" : origin/main:t/db_dependent/Reserves.t: t::lib::Mocks::mock_preference( 'DefaultHoldExpirationUnitOfTime', 'days;' ); -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 39746] New: Wrong system preference 'AutoLocation' in test suite
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39746 Bug ID: 39746 Summary: Wrong system preference 'AutoLocation' in test suite Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 26176 renamed AutoLocation to StaffLoginRestrictBranchByIP Needs to be fixed in test suite -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 40320] New: Missing Cypress tests for patron address display
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40320 Bug ID: 40320 Summary: Missing Cypress tests for patron address display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The changes on bug 40319 should be covered by tests. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 27208] New: Add a configurable time delay feature to notice templates
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Bug ID: 27208 Summary: Add a configurable time delay feature to notice templates Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: barbara.johnson(a)bedfordtx.gov QA Contact: testopia(a)bugs.koha-community.org It would be helpful to have a configurable time delay feature added to the notice templates. In our case, items with holds are immediately trapped, and the hold notice gets sent, when they get returned through our sorter. However, we are quarantining materials for 72 hours so we don’t want the hold pickup notice sent until the items come out of quarantine. Other possible uses for a configurable time delay might be when one library in a system is quarantining items but another is not. In a consortium, with a mix of school and public libraries, they might want to send notices at different times. Other libraries have mentioned their patrons arrive at the library because they got their pickup notice but staff hasn’t actually had time to process the holds. This would be especially helpful with hold notices but could also apply to other notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 35

[Bug 40404] New: t/Test/Mock/Logger.t generates warnings
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40404 Bug ID: 40404 Summary: t/Test/Mock/Logger.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 25515 t/Test/Mock/Logger.t .. 1/10 # trace: # (No trace messages) # debug: # "Debug message" at /usr/share/perl/5.36/Test/Builder.pm line 374 # info: # (No info messages) # warn: # (No warn messages) # error: # (No error messages) # fatal: # (No fatal messages) t/Test/Mock/Logger.t .. ok All tests successful. Files=1, Tests=10, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.40 cusr 0.07 csys = 0.50 CPU) Result: PASS Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 40317] New: Auth_with_shibboleth.t generates warnings
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40317 Bug ID: 40317 Summary: Auth_with_shibboleth.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org t/db_dependent/Auth_with_shibboleth.t .. 1/5 GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 73. EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 80. SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 90. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 40373] New: Reserves.t generates a warning
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40373 Bug ID: 40373 Summary: Reserves.t generates a warning Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 25515 t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.

1 19