September 2025 - Koha-bugs - lists.koha-community.org

[Bug 40636] New: C4::Reserves::CancelExpiredReserves behavior depends on date it is run
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40636 Bug ID: 40636 Summary: C4::Reserves::CancelExpiredReserves behavior depends on date it is run Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Looking at this method, I noticed (a few things, of which the more relevant is) calculation depends on the date the method is called. For example: If a hold expired on Monday but the script runs on Tuesday (which happens to be a holiday), the hold that should have been canceled on Monday will be skipped entirely, even though Monday wasn't a holiday. The logic should be checking if the expiration date itself was a holiday, not whether today is a holiday -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 43

[Bug 40672] New: `desk_id` not cleared when `revert_found()` called
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40672 Bug ID: 40672 Summary: `desk_id` not cleared when `revert_found()` called Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, lisette(a)bywatersolutions.com, tomascohen(a)gmail.com When `ModReserveAffect` is used to set a waiting status for a hold, if the session has a `desk_id` set, then the hold is marked as waiting and the `desk_id` is set for the hold. Neither the original `RevertWaitingStatus` or the new `revert_found` methods reset the `desk_id`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 39869] New: Club holds API missing tests
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39869 Bug ID: 39869 Summary: Club holds API missing tests Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The introduction of `Test::NoWarnings` (bug 38944) allowed us to detect these tests do not cover all the behavior: when the database makes `Can*BeReserved` not return `status => OK` the tests pass (because the endpoint is designed to place the hold regardless, but a warning is printed in the logs. This behavior is not tested. The tests should: * Cover the item-level holds case * Not depend on existing data/circulation rules on the DB * Tests this `warn` behavior correctly -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 37898] New: All db dependent tests should run within a transaction
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37898 Bug ID: 37898 Summary: All db dependent tests should run within a transaction Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Some tests do not cleanup and leave new data that might interfere with other tests. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 40539] New: Cypress videos and screenshots should be gitignored
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40539 Bug ID: 40539 Summary: Cypress videos and screenshots should be gitignored Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: matt.blenkinsop(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 40493] New: t/cypress/plugins/dist/ must be git ignored
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40493 Bug ID: 40493 Summary: t/cypress/plugins/dist/ must be git ignored Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 40173 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40173 [Bug 40173] Reuse http-client from Cypress tests - preparation steps -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 40386] New: t/Edifact.t generates warnings
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40386 Bug ID: 40386 Summary: t/Edifact.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 25515 03:28:19 koha_1 | substr outside of string at /kohadevbox/koha/Koha/Edifact/Segment.pm line 101. 03:28:19 koha_1 | Use of uninitialized value $seg in substitution (s///) at /kohadevbox/koha/Koha/Edifact/Segment.pm line 103. 03:28:19 koha_1 | Use of uninitialized value $seg in split at /kohadevbox/koha/Koha/Edifact/Segment.pm line 104. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 40387] New: t/db_dependent/Koha/EDI.t
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40387 Bug ID: 40387 Summary: t/db_dependent/Koha/EDI.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 25515 03:27:57 koha_1 | substr outside of string at /kohadevbox/koha/Koha/Edifact/Segment.pm line 101. 03:27:57 koha_1 | Use of uninitialized value $seg in substitution (s///) at /kohadevbox/koha/Koha/Edifact/Segment.pm line 103. 03:27:57 koha_1 | Use of uninitialized value $seg in split at /kohadevbox/koha/Koha/Edifact/Segment.pm line 104. 03:27:57 koha_1 | substr outside of string at /kohadevbox/koha/Koha/Edifact/Segment.pm line 101. 03:27:57 koha_1 | Use of uninitialized value $seg in substitution (s///) at /kohadevbox/koha/Koha/Edifact/Segment.pm line 103. 03:27:57 koha_1 | Use of uninitialized value $seg in split at /kohadevbox/koha/Koha/Edifact/Segment.pm line 104. 03:27:57 koha_1 | # Loaded QUOTE file with 1 Message that contains 2 LIN segments with the first 03:27:57 koha_1 | # consistent of 1 item and the second with 3 items with 2 different funds. 03:27:57 koha_1 | No matching EAN found for 5412345000013 at t/db_dependent/Koha/EDI.t line 385. 03:27:57 koha_1 | # Looking at order: 1 03:27:57 koha_1 | # Looking at order: 2 03:27:57 koha_1 | # Looking at order: 3 03:27:57 koha_1 | # Second LIN split into 2 Orderlines, one for each Fund 03:27:57 koha_1 | # Loading QUOTE file with 1 Message that contains 2 LIN segments with the first 03:27:57 koha_1 | # consistent of 1 item and the second with 3 items with 2 different undefined funds. 03:27:57 koha_1 | # Loading QUOTE file with 2 messages 03:27:57 koha_1 | No orderlines for basket 285 at t/db_dependent/Koha/EDI.t line 618. 03:27:57 koha_1 | No orderlines for basket 286 at t/db_dependent/Koha/EDI.t line 618. 03:27:57 koha_1 | Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/EDI.pm line 420. 03:27:57 koha_1 | Use of uninitialized value in multiplication (*) at /kohadevbox/koha/Koha/EDI.pm line 420. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 40858] New: t/00-merge-conflict-markers.t should only test files part of git repo
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40858 Bug ID: 40858 Summary: t/00-merge-conflict-markers.t should only test files part of git repo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It's currently failing on kohadev-db-request.txt that is owned by root. But it's not part of the Koha codebase, this file should not be tested. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 40541] New: Add new line at the end of the files when missing
by bugzilla-daemon＠bugs.koha-community.org 13 Nov '25

13 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40541 Bug ID: 40541 Summary: Add new line at the end of the files when missing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)gmail.com Reporter: jonathan.druart(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We have insert_final_newline = true to ensure files will contain a new line at the end. However we have seen commits with "No new line" added in the git log. We should have a xt test to prevent more occurrences. We should also have a test at the QA script level: https://gitlab.com/koha-community/qa-test-tools/-/issues/96 -- You are receiving this mail because: You are watching all bug changes.

1 18