February 2026 - Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #354 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194082&action=e… Bug 10190: warn when no default triggers exist and show libraries with rules When viewing the default library context with no triggers defined, show a warning message explaining defaults apply to all libraries. If any libraries have specific triggers, list them as clickable links that switch the filter to that library. If no rules exist anywhere, show a prompt to add the first trigger. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #353 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194081&action=e… Bug 10190: fix NaN trigger number when adding first rule for a library When no circulation rules exist for a library, triggerCounts[library_id] is undefined, causing undefined + 1 = NaN. Use nullish coalescing to default to 0 so the first trigger correctly gets number 1. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #352 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194080&action=e… Bug 10190: remove has_rules sentinel from circulation_rules table has_rules was a purely frontend marker stored as a circulation rule to signal that a context had explicitly-saved overdue trigger rules. The backend never reads it; the information is fully derivable from whether any of delay/notice/mtt/restrict are non-null for a given context. Replace all has_rules DB reads/writes with a hasExplicitRulesForTrigger() helper that checks the four real rule suffixes directly. has_rules remains as a computed in-memory concept in the Vue store (derived in findEffectiveRule) so templates require no changes. Also adds an atomicupdate to delete existing has_rules rows from the DB, and removes the has_rules insert from the bug_10190 migration script. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #351 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194079&action=e… Bug 10190: three minor issues - overdue_notices.pl: fix verbose sprintf - remove spurious \$triggered argument (CLI 0/1 flag had replaced delay value in output) and use the \$borr string that was computed but never included in the message - overdue_notices.pl: remove %already_queued hash which was populated in _enact_trigger but never read; dead code since the refactor - C4/Overdues.pm GetBranchcodesWithOverdueRules: guard the global-rule expansion with @branchcodes check so an empty result (no rules at all) correctly returns an empty list instead of all branches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #350 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194078&action=e… Bug 10190: correction to x-koha-authorization on /circulation_rules/config The config endpoint is used exclusively by the Circulation Triggers Vue app, which is gated on parameters/manage_circ_rules. Using acquisition/'*' and erm/1 was inconsistent copy-paste from an unrelated endpoint and would 403 circ-rules admins while granting access to unrelated module users. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #349 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194077&action=e… Bug 10190: fix four more issues spotted in the overdues script - Patron.pm has_restricting_overdues: sort ASC not DESC so the oldest (most overdue) item is checked per branch/itemtype; DESC caused the deduplication skip to discard the very items most likely to trigger a restriction - overdue_notices.pl: fix --itemtypesout option name in GetOptions (was 'itemtypeouts', never matched the documented --itemtypesout flag) - overdue_notices.pl: fix typo 'catagorycode' -> 'categorycode' in --borcatout search, which silently broke category exclusion - circulation_triggers.pl: add flagsrequired => parameters/manage_circ_rules so the admin page enforces the correct permission; also add missing use Koha::Notice::Templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #348 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194076&action=e… Bug 10190: fix three regressions in overdue_notices.pl - Store patron name/address fields in \$borrower_overdues so prepare_letter_for_printing has data for printed/CSV/text notices - Fix email->print fallback: look up items under original MTT key, not the effective (fallback) key - Set \$admin_email_address from \$library unconditionally in _enact_trigger; previously undef in non-patron_homelibrary mode, stripping the from_address on all queued notices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #347 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194075&action=e… Bug 10190: rewrite atomicupdate with correct 1:1 rule migration The previous migration had two fundamental errors: 1. It manufactured phantom empty rows for all patron categories that had no rule, which corrupted the "most frequent" calculation. 2. It created categorycode=NULL (all-categories) default rules for every branchcode seen, silently extending overdue notice coverage to patron categories that had no configured rule in the old system. The backend (overdue_notices.pl) does not consult has_rules, so these invented defaults would cause notices to be sent to patrons that were deliberately uncovered. The rewrite migrates only explicit (branchcode, categorycode) pairs that had a positive delay configured. No default rules are created. branchcode='' maps to NULL as before. exit is replaced with return to avoid killing subsequent atomicupdate scripts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #346 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194074&action=e… Bug 10190: Deprecate permission user_permissions rows do not need manual cleanup because the FK on user_permissions(module_bit, code) references permissions(module_bit, code) ON DELETE CASCADE, so deleting from permissions automatically removes per-patron rows. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 27 Feb '26

27 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #345 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194073&action=e… Bug 10190: prevent duplicate ruleset load - prevent the initial API call and subsequent exhaustive applied ruleset list generation logic from running twice -- You are receiving this mail because: You are watching all bug changes.

1 0