February 2026 - Koha-bugs - lists.koha-community.org

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #310 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193901&action=e… Bug 10190: remove has_rules sentinel from circulation_rules table has_rules was a purely frontend marker stored as a circulation rule to signal that a context had explicitly-saved overdue trigger rules. The backend never reads it; the information is fully derivable from whether any of delay/notice/mtt/restrict are non-null for a given context. Replace all has_rules DB reads/writes with a hasExplicitRulesForTrigger() helper that checks the four real rule suffixes directly. has_rules remains as a computed in-memory concept in the Vue store (derived in findEffectiveRule) so templates require no changes. Also adds an atomicupdate to delete existing has_rules rows from the DB, and removes the has_rules insert from the bug_10190 migration script. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #309 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193900&action=e… Bug 10190: three minor issues - overdue_notices.pl: fix verbose sprintf - remove spurious \$triggered argument (CLI 0/1 flag had replaced delay value in output) and use the \$borr string that was computed but never included in the message - overdue_notices.pl: remove %already_queued hash which was populated in _enact_trigger but never read; dead code since the refactor - C4/Overdues.pm GetBranchcodesWithOverdueRules: guard the global-rule expansion with @branchcodes check so an empty result (no rules at all) correctly returns an empty list instead of all branches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #308 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193899&action=e… Bug 10190: correction to x-koha-authorization on /circulation_rules/config The config endpoint is used exclusively by the Circulation Triggers Vue app, which is gated on parameters/manage_circ_rules. Using acquisition/'*' and erm/1 was inconsistent copy-paste from an unrelated endpoint and would 403 circ-rules admins while granting access to unrelated module users. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #307 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193898&action=e… Bug 10190: fix four more issues spotted in the overdues script - Patron.pm has_restricting_overdues: sort ASC not DESC so the oldest (most overdue) item is checked per branch/itemtype; DESC caused the deduplication skip to discard the very items most likely to trigger a restriction - overdue_notices.pl: fix --itemtypesout option name in GetOptions (was 'itemtypeouts', never matched the documented --itemtypesout flag) - overdue_notices.pl: fix typo 'catagorycode' -> 'categorycode' in --borcatout search, which silently broke category exclusion - circulation_triggers.pl: add flagsrequired => parameters/manage_circ_rules so the admin page enforces the correct permission; also add missing use Koha::Notice::Templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #306 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193897&action=e… Bug 10190: fix three regressions in overdue_notices.pl - Store patron name/address fields in \$borrower_overdues so prepare_letter_for_printing has data for printed/CSV/text notices - Fix email->print fallback: look up items under original MTT key, not the effective (fallback) key - Set \$admin_email_address from \$library unconditionally in _enact_trigger; previously undef in non-patron_homelibrary mode, stripping the from_address on all queued notices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #305 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193896&action=e… Bug 10190: rewrite atomicupdate with correct 1:1 rule migration The previous migration had two fundamental errors: 1. It manufactured phantom empty rows for all patron categories that had no rule, which corrupted the "most frequent" calculation. 2. It created categorycode=NULL (all-categories) default rules for every branchcode seen, silently extending overdue notice coverage to patron categories that had no configured rule in the old system. The backend (overdue_notices.pl) does not consult has_rules, so these invented defaults would cause notices to be sent to patrons that were deliberately uncovered. The rewrite migrates only explicit (branchcode, categorycode) pairs that had a positive delay configured. No default rules are created. branchcode='' maps to NULL as before. exit is replaced with return to avoid killing subsequent atomicupdate scripts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #304 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193895&action=e… Bug 10190: Deprecate permission user_permissions rows do not need manual cleanup because the FK on user_permissions(module_bit, code) references permissions(module_bit, code) ON DELETE CASCADE, so deleting from permissions automatically removes per-patron rows. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #303 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193894&action=e… Bug 10190: prevent duplicate ruleset load - prevent the initial API call and subsequent exhaustive applied ruleset list generation logic from running twice -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #302 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193893&action=e… Bug 10190: (QA follow-up) swap undef for all in update db output Patch from commit e9264df -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10190] Overdue notice triggers based on item type
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '26

25 Feb '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #301 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 193892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193892&action=e… Bug 10190: trigger add/edit form UI/UX enhancements - scroll to the add/edit form on button click - prevent redundant full page reload upon the user swapping between adding and editing while the modal is open - ensure robust scroll behaviour, handling: - the URL being accessed directly - the edit button in the table in the main page being used to access the form directly - the stepper workflow being used - the user swapping between add and edit once already looking at the form - dynamic display of 'Transport Type' consistency: only show if a 'Notice' has been selected - if a notice has been selected, prevent form submission if transport type isn't set and display an alert on submission attempt -- You are receiving this mail because: You are watching all bug changes.

1 0