- Koha-bugs - lists.koha-community.org

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #114 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 151223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151223&action=e… Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #113 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 151222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151222&action=e… Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150537|0 |1 is obsolete| | Attachment #150538|0 |1 is obsolete| | Attachment #150539|0 |1 is obsolete| | Attachment #150540|0 |1 is obsolete| | Attachment #150541|0 |1 is obsolete| | Attachment #150542|0 |1 is obsolete| | Attachment #150543|0 |1 is obsolete| | Attachment #150544|0 |1 is obsolete| | Attachment #150545|0 |1 is obsolete| | Attachment #150546|0 |1 is obsolete| | Attachment #150547|0 |1 is obsolete| | Attachment #150548|0 |1 is obsolete| | --- Comment #112 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 151221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151221&action=e… Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer(a)nyls.edu> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber(a)kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #111 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 151220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151220&action=e… k -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #110 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I can fix the test. I think what happens is: If the field is a repeatable one, we are only looking at the first occurence. The test was using 999, but this field is already present in the created biblio, before another 999 is added with $Z. So when trying to set the field, no $Z was found and the additional_field was not set. This can be fixed by: 1) Using another field than 999 that doesn't already exist in the record. 2) appending Z to the already existing 999 3) Making sure that set_additional_fields loops through repeatable subfields, using the first subfield found. 1) is done easily, 3) is harder. I tried to determine how it worked before this patch set, as the 'set' functionality was already there: https://git.koha-community.org/Koha-community/Koha/src/commit/f891156f424a4… my $value = $query->param('additional_field_' . $field->id); if ($field->marcfield) { my ($field, $subfield) = split /\$/, $field->marcfield; if ( $record and $field and $subfield ) { $value = $record->subfield( $field, $subfield ); } } It appears it never dealt 'cleverly' with repeated subfields. So we might move this to a separate bug and go with 1) for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26628] New: Clubs permissions should grant access to Tools page
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Bug ID: 26628 Summary: Clubs permissions should grant access to Tools page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: - create a patron with only the catalogue, borrowers, and clubs permissions - log in to the staff client as that patron - navigate to a patron record, confirm you can see the Clubs tab in the patron account, can add patrons to and remove patrons from clubs - confirm you don't have a link to the Tools module either on the Koha homepage or in the More menu - enter the clubs url manually (/cgi-bin/koha/clubs/clubs.pl), confirm you are allowed to open the page We should give a Tools link to anyone with clubs, edit_clubs, or edit_templates permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 27546] New: Add option to search within results on the staff client
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Bug ID: 27546 Summary: Add option to search within results on the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This enhancement will add a new box above the search results allowing one to search within the previous search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 33097] New: Is message for staff or OPAC on circulation.pl?
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097 Bug ID: 33097 Summary: Is message for staff or OPAC on circulation.pl? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When looking at patron messages (not notices) on circulation.pl, it is impossible to tell if a message was posted to staff or to the OPAC. They display differently, with one red and the other not. But that doesn't tell the staff member which is which. We should have some kind of indicator to differentiate the two types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

1 0