- Koha-bugs - lists.koha-community.org

[Bug 16865] New: marking branchcode unwanted breaks self registration
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16865 Bug ID: 16865 Summary: marking branchcode unwanted breaks self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If you add branchcode to PatronSelfRegistrationBorrowerUnwantedField then self registration fails silently. The library and the user have no idea what happened. We should have an error and/or not let branchcode be added to that preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 17364] New: branchcode should not be allowed in BorrowerUnwantedField , PatronSelfRegistrationBorrowerUnwantedField
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Bug ID: 17364 Summary: branchcode should not be allowed in BorrowerUnwantedField, PatronSelfRegistrationBorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If branchcode is among the fields in BorrowerUnwantedField, saving the borrower record in members/memberentry.pl will generate an Internal Server Error because there is a foreign key constraint on borrowers.branchcode. To replicate the issue: 1/ Set the syspref BorrowerUnwantedField so that it contains branchcode 2/ Create a patron on members/memberentry.pl 3/ Save the patron, you will get "Internal Server Error". It follows that PatronSelfRegistrationBorrowerUnwantedField should not contain branchcode either -- it's necessary to create a record in the borrowers table, so we shouldn't be able to exclude it. Details for those who like that sort of thing: If you're watching the plack error logs,you'll see something like this: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_salinas`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "INSERT INTO `borrowers` ( `address`, `address2`, `borrowernotes`, `cardnumber`, `categorycode`, `city`, `contactnote`, `country`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `emailpro`, `fax`, `firstname`, `initials`, `mobile`, `opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`, `sex`, `sort1`, `sort2`, `state`, `surname`, `title`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="1234 MAIN ST", 1="", 2="", 3="TESTYTESTERSON", 4="STAFF", 5="Bradley, CA", 6="", 7="", 8='2016-09-27', 9='2024-12-27', 10=undef, 11=undef, 12="", 13="", 14="", 15="TESTY", 16="", 17="", 18="", 19="", 20='!', 21="555 555 1212", 22="", 23=1, 24="", 25="C", 26="", 27="", 28="TESTERSON", 29="", 30='testy.testerson', 31="93426"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_salinas`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/C4/Members.pm line 769 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 44

[Bug 13093] Allow/Don't allow holds on items with set statuses
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think settings would work, yes. Also this would allow for migrations without changing behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Christopher Brannon from comment #6) > (In reply to Katrin Fischer from comment #5) > > We do now have this permission: > > Allow staff to change logged in library (loggedinlibrary) > > What version? Not seeing it in 22.11. Correct, it's a 23.05 feature: Bug 30624 - Add a permission to control the ability to change the logged in library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13165] Don't trigger holds when patrons have already reached limit of checkouts
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 --- Comment #6 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- I think that it should be up to the system admin to implement, not how complicated we might think it is for the patron. If a library can communicate this well, it would be worth it. It could simply be communicated at the time the hold is being placed like a warning: "Please note that holds are not filled if you have reached the limit of your library's checkouts." Maybe we could even have something that would display checkout limits, if any. It should be up to the library whether this would be implemented or not, leaving it to the library as to whether a patron's holds can be filled if their checkout limits have been reached. As is, a patron gets notified that they have a hold, and they go to pick it up, only to find out that they can't check it out until they return something. They probably are not prepared with this dilemma, and have to return home to get something to return so they can claim their hold. With a new option, they are not even eligible or notified until they are under the limit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13125] Total holds does not tally holds / items.reserves is not populated
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 --- Comment #7 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- I don't agree with doing away with it. Perhaps the simple answer is to have the following options: A) uptick the count in this field if a hold is triggered on the specific item. First available or item specific is moot. If the hold is triggered, it is assigned to a specific item at that point. B) decide if a cancelled hold leaves the count as is, or downticks the count. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13093] Allow/Don't allow holds on items with set statuses
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13093 --- Comment #2 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Then perhaps we do away with the negative value/hold relationship in NOTFORLOAN, and a new setting created to list what statuses allow holds? NOTFORLOAN: 1,2,5 DAMAGED: 2,5 LOST: 3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11420] Patron preference to restrict staff from changing location
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420 --- Comment #6 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Katrin Fischer from comment #5) > We do now have this permission: > Allow staff to change logged in library (loggedinlibrary) What version? Not seeing it in 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 34246] New: Add search filter for library backend
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34246 Bug ID: 34246 Summary: Add search filter for library backend Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de CC: pedro.amorim(a)ptfs-europe.com It would be very helpful if there as an additional search filter for library backends on the left side of the ILL start page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '23

10 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau <samalau(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153261|0 |1 is obsolete| | --- Comment #58 from Sam Lau <samalau(a)gmail.com> --- Created attachment 153280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153280&action=e… Bug 6796: Don't add a day if hourly loan period pushes due date If ConsiderLibraryHoursWhenIssuing is set to shorten the loan period to the closing time, if the loan period initially pushes the due date to the following day, the day still gets added when calculating the due date. We simply need to hardcode the due time here as the due day is the same as the issue day. We only need to calculate a due date if ConsiderLibraryHoursWhenIssuing is set to extend the loan period to the next opening day, as we'll need to consider holidays/closed days. Signed-off-by: Sam Lau <samalau(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0