- Koha-bugs - lists.koha-community.org

[Bug 42119] New: Update various admin pages to use grid layout for forms - Part 3
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42119 Bug ID: 42119 Summary: Update various admin pages to use grid layout for forms - Part 3 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 41823 - Administration -> Curbside pickups - Administration -> Share content with Mana KB - Administration -> Z39.50 servers Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41823 [Bug 41823] Update acquisitions admin pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 39419] New: Holds API treats 'expiration_date' as 'patron_expiration_date'
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39419 Bug ID: 39419 Summary: Holds API treats 'expiration_date' as 'patron_expiration_date' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This is going to have a related issue in Aspen, but I think the confusion starts here Koha has two fields for hold expiration: expirationdate - (usually) auto generated date set based no when holds on the shelf expire patron_exiration_date - the day the patron says they don't need the hold after The API takes "expiration_date" and maps it to "patron_expiration_date" This can be unclear for outside systems. Aspen has a 'Default Not Needed After Days' setting which is assumed to be setting the automatic expiraton date, but in fact sets the patron date We should allow either field to be set via the API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 63

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Comment 4 contains a typo, remove the S> before executing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 199342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199342&action=e… Bug 8127: Fix filters use in 'Most-circulated items report' Filters are broken for many reasons. Previous patch contains some (little) tidying. There are 3 parts in this patch: 1 - The column name is incorrectly named in the dropdown for "branch", it is added in this patch 2 - There is a definition for 'Day' and 'Month', but not for 'Week', it is also added in this patch 3 - Dbh variables are passed in the string definition AND in the call. I removed them from the string definition since it violates the coding guidelines. Test plan: 1. On an fresh ktd db, run the script provided here (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127#c3) to fill the database with checkins/checkouts: Visit http://your_koha:8081/cgi-bin/koha/reports/cat_issues_top.pl 2. Run a baseline test with following params: Checkout date from 01/01/2020 Checkout date to: tomorrow Library: Any library Fill nothing else Notice it is works 3. Test with some limits (Library, Week, and any other), notice you encounter errors on Library and Week, and that any other is empty, without error. 4. Apply patch 5. Rerun 2-3 and notice you now have results. Check with each possible limit, limiting to 5. Test once with 10 as a limit. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 199341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199341&action=e… Bug 8127: Remove useless commented warns Patch from commit f821cb6 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- This is a script that might help running the upcoming test plan: use C4::Circulation qw( AddIssue AddReturn ); use Koha::Items; use Koha::Patrons; use t::lib::Mocks; use Koha::DateUtils qw(dt_from_string); S>my $koha_user = Koha::Patrons->find(51); t::lib::Mocks::mock_userenv({patron => $koha_user}); my $henry = Koha::Patrons->find(19); my $edna = Koha::Patrons->find(5); my $book1 = Koha::Items->find({ itemnumber => 1 }); my $book2 = Koha::Items->find({ itemnumber => 2 }); my $book3 = Koha::Items->find({ itemnumber => 12 }); my $book4 = Koha::Items->find({ itemnumber => 19 }); my $book5 = Koha::Items->find({ itemnumber => 21 }); my $musics = Koha::Items->search({ itype => 'MU' }); my $music1 = $musics->next; my $nb_days; for( my $i = 10; $i<100; $i++){ $nb_days = $i; my $item; my $patron; my $branch; if ($i == 15){ $item = $book3; } elsif ($i == 16){ $item = $book4; } elsif ($i == 17){ $item = $book5; } elsif ($i < 30){ $item = $book1; } elsif ($i < 70){ $item = $book2; } else { $item = $music1; }; if ($i % 2 == 1){ $patron = $edna; } else { $patron = $henry; } if ($i % 3 == 0){ $branchcode = 'CPL'; } elsif ($i % 3 == 1){ $branchcode = 'MPL'; } else { $branchcode = 'FFL'; }; $branch = t::lib::Mocks::mock_userenv({branchcode => $branchcode}); my $due = dt_from_string->subtract(days => $nb_days)->set_hour(12)->set_minute(00)->set_second(00); AddIssue($patron, $item->barcode, $due); AddReturn($item->barcode, $branchcode); my $returned_date = dt_from_string->subtract(days => $nb_days)->set_hour(12)->set_minute(00)->set_second(00); my $lastIssue = Koha::Old::Checkouts->filter_by_last_update({ younger_than => 0, timestamp_column_name => 'returndate', })->single; $lastIssue->set({ returndate => $returned_date })->store(); $lastIssue->set({ issuedate => $returned_date })->store(); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- This is a script that might help running the upcoming test plan: use C4::Circulation qw( AddIssue AddReturn ); use Koha::Items; use Koha::Patrons; use t::lib::Mocks; use Koha::DateUtils qw(dt_from_string); S>my $koha_user = Koha::Patrons->find(51); t::lib::Mocks::mock_userenv({patron => $koha_user}); my $henry = Koha::Patrons->find(19); my $edna = Koha::Patrons->find(5); my $book1 = Koha::Items->find({ itemnumber => 1 }); my $book2 = Koha::Items->find({ itemnumber => 2 }); my $book3 = Koha::Items->find({ itemnumber => 12 }); my $book4 = Koha::Items->find({ itemnumber => 19 }); my $book5 = Koha::Items->find({ itemnumber => 21 }); my $musics = Koha::Items->search({ itype => 'MU' }); my $music1 = $musics->next; my $nb_days; for( my $i = 10; $i<100; $i++){ $nb_days = $i; my $item; my $patron; my $branch; if ($i == 15){ $item = $book3; } elsif ($i == 16){ $item = $book4; } elsif ($i == 17){ $item = $book5; } elsif ($i < 30){ $item = $book1; } elsif ($i < 70){ $item = $book2; } else { $item = $music1; }; if ($i % 2 == 1){ $patron = $edna; } else { $patron = $henry; } if ($i % 3 == 0){ $branchcode = 'CPL'; } elsif ($i % 3 == 1){ $branchcode = 'MPL'; } else { $branchcode = 'FFL'; }; $branch = t::lib::Mocks::mock_userenv({branchcode => $branchcode}); my $due = dt_from_string->subtract(days => $nb_days)->set_hour(12)->set_minute(00)->set_second(00); AddIssue($patron, $item->barcode, $due); AddReturn($item->barcode, $branchcode); my $returned_date = dt_from_string->subtract(days => $nb_days)->set_hour(12)->set_minute(00)->set_second(00); my $lastIssue = Koha::Old::Checkouts->filter_by_last_update({ younger_than => 0, timestamp_column_name => 'returndate', })->single; $lastIssue->set({ returndate => $returned_date })->store(); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8127] Most-circulated items report doesn't work when limited by library
by bugzilla-daemon＠bugs.koha-community.org 20 May '26

20 May '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.

1 0