- Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #172 from The Minh Luong <the-minh.luong(a)inlibro.com> --- Created attachment 130402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130402&action=e… Bug 12446: Adult can now have guarantors This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #171 from The Minh Luong <the-minh.luong(a)inlibro.com> --- Created attachment 130401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130401&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #170 from The Minh Luong <the-minh.luong(a)inlibro.com> --- Created attachment 130400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130400&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #169 from The Minh Luong <the-minh.luong(a)inlibro.com> --- Created attachment 130399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130399&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 The Minh Luong <the-minh.luong(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122184|0 |1 is obsolete| | Attachment #122185|0 |1 is obsolete| | Attachment #122186|0 |1 is obsolete| | Attachment #122187|0 |1 is obsolete| | --- Comment #168 from The Minh Luong <the-minh.luong(a)inlibro.com> --- Created attachment 130398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130398&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30066] New: POD for chargeable_units on CalcFine wrong?
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30066 Bug ID: 30066 Summary: POD for chargeable_units on CalcFine wrong? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org POD reads: C<$chargeable_units> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed, minus any applicable grace period, or hours) But actually it looks like the grace period (firstremind) is still included. Otherwise this would make no sense: my $chargeable_units = get_chargeable_units($fine_unit, $start_date, $end_date, $branchcode); my $units_minus_grace = $chargeable_units - ($issuing_rule->{firstremind} || 0); my $units = C4::Context->preference('FinesIncludeGracePeriod') ? $chargeable_units : $units_minus_grace; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 30062] New: Add ability in patron attributes to use an authorized value with an "Other" option
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30062 Bug ID: 30062 Summary: Add ability in patron attributes to use an authorized value with an "Other" option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com For patron attributes, libraries sometimes want a semi-controlled list of values with the ability to pick "Other" and enter a one-time non-authorized value. For example, a library uses a patron attribute to store the hometown of guest patrons to whom they've issued a card. In order to promote consistency of data, they've created an authorized value that lists all the most common hometown they encounter. But sometimes a patron shows up with a hometown the library hasn't allowed for. They may go back and add this new town to the authorized value later, but for now they just want to put it in the patron record. I suggest we add an option in patron attribute setup so that if one connects an attribute to an authorized value one can also check a box for "include an 'Other' option." If that box is checked in the attribute setup, when one is editing a patron the dropdown for the attribute will include the option "Other." If the user selects "Other," then a text box appears and the user can enter a free text value. That value gets saved in borrower_attributes.attribute but not added to the authorized value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 9097] 'Welcome mail' for new library users
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Lucy Vaux-Harvey <lucy.vaux-harvey(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com --- Comment #9 from Lucy Vaux-Harvey <lucy.vaux-harvey(a)ptfs-europe.com> --- I agree it would be good if the Welcome email could be sent to self-registered patrons (without the password included - see bug 27812). We have library customers who would like to use this facility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 27912] New: Quotes break guarantor search.
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27912 Bug ID: 27912 Summary: Quotes break guarantor search. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If a patron has quotes in the borrowernotes field, you will not be able to search for them with the guarantor search. The search just keeps searching and never ends. If there are going to be characters that break functions, there should be some validation in place to prevent these characters from being saved. Otherwise, we need to make it so the characters don't break the function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 22316] New: Double quotes in borrowernotes breaks table sort
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Bug ID: 22316 Summary: Double quotes in borrowernotes breaks table sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To reproduce: - Add a comment with double quotes to the borrowernotes of a patron. - Do a patron search that returns a good number of hits, including the patron with the double quote comment - Sort the table on "Circ cote". This should bring patrons without comments to the top, so it should work. - Sort the table on "Circ note" again. This should bring patrons with comments to the top. If the patron with the double quote comment is not in the first page of patrons you might have to click to the "Previous" page one or more times. Eventually you should see the small "Processing" popup never go away. The developer tools shows the data benig returned OK from the server, so there is probably some problem when the data is getting shoehorned into the table. Tested with 18.11.02. Probably somewhat related to bug 21986. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6