- Koha-bugs - lists.koha-community.org

[Bug 22316] New: Double quotes in borrowernotes breaks table sort
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22316 Bug ID: 22316 Summary: Double quotes in borrowernotes breaks table sort Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- To reproduce: - Add a comment with double quotes to the borrowernotes of a patron. - Do a patron search that returns a good number of hits, including the patron with the double quote comment - Sort the table on "Circ cote". This should bring patrons without comments to the top, so it should work. - Sort the table on "Circ note" again. This should bring patrons with comments to the top. If the patron with the double quote comment is not in the first page of patrons you might have to click to the "Previous" page one or more times. Eventually you should see the small "Processing" popup never go away. The developer tools shows the data benig returned OK from the server, so there is probably some problem when the data is getting shoehorned into the table. Tested with 18.11.02. Probably somewhat related to bug 21986. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30055 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén <bjorn.nylen(a)ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- Got around to this. Rebased the patchset onto current master as there was some conflicts. Fixed the warning in the tests and commit-titles. Test and qa-tool passes for me now. Setting back to Signed off as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #29 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- Created attachment 130347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130347&action=e… Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #28 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- Created attachment 130346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130346&action=e… Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson <barbara.johnson(a)bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #27 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- Created attachment 130345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130345&action=e… Bug 14783: (QA follow-up) Add unit tests. This commit adds unit tests for Bug 14783. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 09 Feb '22

09 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Björn Nylén <bjorn.nylen(a)ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123708|0 |1 is obsolete| | Attachment #127488|0 |1 is obsolete| | Attachment #127490|0 |1 is obsolete| | Attachment #127492|0 |1 is obsolete| | --- Comment #26 from Björn Nylén <bjorn.nylen(a)ub.lu.se> --- Created attachment 130344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130344&action=e… Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Barbara Johnson <barbara.johnson(a)bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30050] New: Koha::DateUtils needs usable POD
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30050 Bug ID: 30050 Summary: Koha::DateUtils needs usable POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There's no mention of the possible values. For example, the valid formats. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #79 from Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> --- On parcel.pl, when selecting orders to receive, we should have a "Select all" option to check the boxes for all orders currently onscreen. In this multi-receiving workflow, for order set to create items in cataloging, quantity received is defaulting to 0 and requiring the user to manually change it to match quantity ordered. When following the normal single order receiving workflow, Koha will assume that quantity received = quantity ordered if your basket was set to create items in cataloging. This change needs to be corrected. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29543] Self-checkout allows returning everybody's loans
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '22

08 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29543 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #55) > (In reply to Marcel de Rooy from comment #50) > > Why dont you pass the session cookie? > > You could pass something like [ $cookie1, $cookie2 ] ? > > I think CGISESSID is in the CGI object already. Cookies need to be sent out. If they have changed, they will only be updated at client side when you sent them explicitly to the output subs. output_html_with_http_headers and friends actually assume that it is the authentication cookie; so you are cheating here. > (In reply to Marcel de Rooy from comment #53) > > Iiuc JWT is not encrypted. So this may be a bit more secure, but could be > > improved. > > It is encoded using a secret, see Koha::Token::_gen_jwt OK. It is bit hidden but I found it in the _default_params sub. -- You are receiving this mail because: You are watching all bug changes.

1 0