- Koha-bugs - lists.koha-community.org

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129922|0 |1 is obsolete| | Attachment #129923|0 |1 is obsolete| | Attachment #129937|0 |1 is obsolete| | --- Comment #23 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 129943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129943&action=e… Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Rebased-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29259] New: Url contains slash '/
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29259 Bug ID: 29259 Summary: Url contains slash '/ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andriiverem(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com After placing hold user is redirected to a link containing a redundant slash in the end, which leads to unexpected consequences. Steps to reproduce: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber); E.g.: request.pl?biblionumbers=233/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 29257] New: Redundant slash in the URL appear during item level hold placing
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Bug ID: 29257 Summary: Redundant slash in the URL appear during item level hold placing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: andriiverem(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com After placing hold user is redirected to a link containing a redundant slash in the end, which leads to unexpected consequences. Steps to reproduce: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber); E.g.: request.pl?biblionumbers=233/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #22 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 129937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129937&action=e… Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Owen Leonard <oleonard(a)myacpl.org> --- > > FAIL installer/data/mysql/en/mandatory/sample_notices.yml > > FAIL yaml_valid > > ARRAY(0x55d88d804738) Line 1594 has an extra quote: - "<li>"" I get an error when printing a fine slip for a charge which isn't associated with a checkout: Can't call method "date_due" on an undefined value at /kohadevbox/koha/C4/Members.pm line 711 I triggered this by going to Accounting -> Create manual invoice and adding an arbitrary amount. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- (In reply to Owen Leonard from comment #17) > I'm still getting warnings from the QA tool: > > FAIL installer/data/mysql/en/mandatory/sample_notices.yml > FAIL yaml_valid > ARRAY(0x55d88d804738) > > The change to sample_notices.yml also lacks a value for "module," which is > required. > > After applying the patch and running "reset_all" in koha-testing-docker I > see this error in the output: > > C4::Installer::load_sql returned the following errors while attempting to > load /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml: > DBD::mysql::db do failed: Cannot add or update a child row: a foreign key > constraint fails (`koha_kohadev`.`letter`, CONSTRAINT > `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) > REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE > CASCADE ON UPDA) at /kohadevbox/koha/C4/Installer.pm line 574. I was unable to produce these errors, but fixed invalid yaml syntax and missing "module" value to the first patch. Also fixed atomicupdate files name (there was cap between 12285 and -allow) and added IGNORE to INSERT statement (my wild guess is that this caused that last error). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129724|0 |1 is obsolete| | --- Comment #19 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 129923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129923&action=e… Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '22

28 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129723|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> --- Created attachment 129922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129922&action=e… Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Rebased-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

1 0