- Koha-bugs - lists.koha-community.org

[Bug 29813] New: skeleton.pl missing semicolon
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Bug ID: 29813 Summary: skeleton.pl missing semicolon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 27312] New: Add a syspref to redirect patron after self registration
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27312 Bug ID: 27312 Summary: Add a syspref to redirect patron after self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org We need to implement a workflow that looks like this: 1. A new patron self registers in the OPAC, with a temporary category code, including providing a social security number 2. After the data is saved, the patron is redirected to a Script (similar to opac/svc/auth/googleopenidconnect, but provided by a plugin) 3. The script redirects the patron again, to an OpenID provider, where (s)he has to login in a secure manner 4. After logging in, the user is redirected back to the Script, and the Script can tell what the correct social security number of the patron is 5. If the social security number provided by the OpenID provider matches one of a temporary patron, that patron is updated to a permanent patron We need to be able to set the URL that the user should be redirected to in step 2 above. This could be done in a couple of ways: 1. As a syspref This would be fairly simple. The syspref holds the URL and if it is set, the user is redirected at the right place in opac/opac-memberentry.pl 2. As a plugin hook The first plugin hook of the right type called would provide the URL and, if there is a URL, the patron is redirected. One advantage of the plugin hook approach is that the information about where to redirect the user would be contained in the same plugin that provides the Script. But a plugin hook does seem like a bit of overkill for providing a single, static URL. And I guess the plugin could set the syspref, if it wanted to, so I will submit a patch that uses a syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 29944] New: Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can.
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29944 Bug ID: 29944 Summary: Non-superlibrarian patrons can't see holds from other libraries, but superlibrarian can. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: the-minh.luong(a)inlibro.com Reporter: the-minh.luong(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: caroline.cyr-la-rose(a)inlibro.com, gmcharlt(a)gmail.com, philippe.blouin(a)inlibro.com The module "Holds queue" is modified in this patch. Holds from all libraries are displayed for superlibrarian patrons. However, holds from other libraries are not displayed for non-superlibrarian patrons. To test: 1) Select "Yes" for the preferences "IndependentBranches", "IndependentBranchesPatronModifications" and "IndependentBranchesTransfers". 2) Create a patron with limited permissions (Not superlibrarian). 3) To give permissions to a patron, click on "More" on the patron's profile (on the top right), then in the drop-down menu, click on "Set permissions". You can now give your patron permissions. Here is an example of permissions that you can give to a limited patron: - circulate (all) - catalogue - borrowers - delete_borrowers - edit_borrowers - reserveforothers (all) - reports (all) 4) Create a superlibrarian patron. (Make sure that patron is in a different library than your limited patron) 5) Log in in OPAC as your superlibrarian patron. 6) Place an hold for an available item. 7) Run misc/cronjobs/holds/build_holds_queue.pl 8) Go to Circulation > Holds queue, click "Submit" and make sure you can see the hold. 9) Log in as your limited patron. 11) Go to Circulation > Holds queue 10) In the drop-down menu, choose "All" and click "Submit". 12) Notice that you can see your superlibrarian patron's hold. 13) Apply the patch. 14) Notice that the "All" option is no longer available for the limited patron. Limited patrons can't see holds from other libraries anymore. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard <oleonard(a)myacpl.org> --- I'm still getting warnings from the QA tool: FAIL installer/data/mysql/en/mandatory/sample_notices.yml FAIL yaml_valid ARRAY(0x55d88d804738) The change to sample_notices.yml also lacks a value for "module," which is required. After applying the patch and running "reset_all" in koha-testing-docker I see this error in the output: C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDA) at /kohadevbox/koha/C4/Installer.pm line 574. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 [Bug 29940] Phase out jquery.cookie.js in the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6734] Show location in full and brief subscription history in OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #12 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- (In reply to Katrin Fischer from comment #10) > (In reply to Fridolin Somers from comment #9) > > Also use <span class="shelvingloc"> like in opac-detail.tt > > I have tried that out and it didn't work well since there is a CSS style > attached to it. But: the subscription location already shows in the > subscription tab with the class "subscription_location", so I've used that > in the other spots which makes things consistent :) Great :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6743] displayFacetCount not working
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '22

24 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6743 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6734] Show location in full and brief subscription history in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '22

24 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6734] Show location in full and brief subscription history in OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '22

24 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6734 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 129740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129740&action=e… Bug 6734: (QA follow-up) Fix punctuation, TT filters, and CSS class * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line * Add subscription_location CSS class * Use AuthorisedValues.GetDescriptionByKohaField() Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=6743 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6743] displayFacetCount not working
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '22

24 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6743 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119251|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 119251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119251&action=e… test --- Comment #7 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 119252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119252&action=e… test 2 --- Comment #8 from Chris Cormack <chris(a)bigballofwax.co.nz> --- The content of attachment 119252 has been deleted --- Comment #9 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 119254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119254&action=e… test 3 --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 129739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129739&action=e… Bug 6734: (QA follow-up) Fix punctuation, TT filters, and CSS class * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line * Add subscription_location CSS class * Use AuthorisedValues.GetDescriptionByKohaField() Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0