- Koha-bugs - lists.koha-community.org

[Bug 29953] New: Possible inefficiency in REST API for biblios endpoint
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29953 Bug ID: 29953 Summary: Possible inefficiency in REST API for biblios endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au CC: tomascohen(a)gmail.com I was looking at Koha/REST/V1/Biblios.pm because of bug 28201 when I noticed it looks like we're running $record->$method calls more than we need to in the "get" function. Consider the following block of code: if ( $c->req->headers->accept =~ m/application\/json/ ) { return $c->render( status => 200, json => $biblio->to_api ); } else { my $record = $biblio->metadata->record; $c->respond_to( marcxml => { status => 200, format => 'marcxml', text => $record->as_xml_record }, mij => { status => 200, format => 'mij', text => $record->to_mij }, marc => { status => 200, format => 'marc', text => $record->as_usmarc }, txt => { status => 200, format => 'text/plain', text => $record->as_formatted }, any => { status => 406, openapi => [ "application/json", "application/marcxml+xml", "application/marc-in-json", "application/marc", "text/plain" ] } ); } If there is an Accept header for application/json, then we run $biblio->to_api, and that's it. However, if there isn't an Accept header for application/json, it looks like we create a hash of hashrefs that output the $record in 4 different formats. I think it would make more sense (based on what I see in https://docs.mojolicious.org/Mojolicious/Plugin/DefaultHelpers#respond_to) to provide anonymous functions instead of hashrefs so that $record->$method calls are only run when a specific format is actually chosen by Mojolicious. In terms of performance, it might be only a marginal gain, but if you're doing a lot of API calls, small gains can translate into large scale time savings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- Remote branch updated to remove the non-minified version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #10 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Owen Leonard from comment #9) > (In reply to Jonathan Druart from comment #8) > > Do we really need to include the non-minified version of jstree? > > It's not strictly necessary as long as the minified version includes version > number information in it. Yes, that's my point. If someone wants to debug it is easy to retrieve the corresponding non-minified version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #8) > Do we really need to include the non-minified version of jstree? It's not strictly necessary as long as the minified version includes version number information in it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11873] Upgrade jstree jQuery plugin to the latest version
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11873 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Do we really need to include the non-minified version of jstree? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6590] Removing hyphens from ISBN and ISSN when cataloging a biblio
by bugzilla-daemon＠bugs.koha-community.org 26 Jan '22

26 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Johanna Räisä <johanna.raisa(a)koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa(a)koha-suomi.fi --- Comment #26 from Johanna Räisä <johanna.raisa(a)koha-suomi.fi> --- Removing hyphens from the marcxml record is against the standard. I liked the idea in the bug 27774 and now we have elasticsearch, so could this be done with a system preference? When using elasticsearch keep hyphens on the marcxml for example. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12656] Allow a CANCELLATION_REASON to be specified on the cancel_expired_holds.pl job
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6659] Show OpacNav and OpacNavBottom on the login page
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- It is by design that the login page is focused on the login form and associated information. I think that the availability of the OpacLoginInstructions content option also makes this WONTFIX. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 29717] New: Too many DateTime manipulation in tools/additional-contents.pl
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29717 Bug ID: 29717 Summary: Too many DateTime manipulation in tools/additional-contents.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 29813] New: skeleton.pl missing semicolon
by bugzilla-daemon＠bugs.koha-community.org 25 Jan '22

25 Jan '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29813 Bug ID: 29813 Summary: skeleton.pl missing semicolon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20