- Koha-bugs - lists.koha-community.org

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #394 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Not from this report, but very related: $self->{_components} = $results if ( defined($results) && scalar(@$results) ); } return $self->{_components} || []; Why do we save these component parts in the object and not use them later (if we would call again)? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #393 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- my $components = $biblio->get_marc_components(300) This 300 is hardcoded. At least a constant? Or some other configuration option? Probably the latter. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #392 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Seems you only remove 2 newlines, please remove these changes. + [% IF defaulttab == 'components' %] + <li id="tab_components" class="ui-tabs-active"> + [% ELSE %] + <li id="tab_components"> + [% END %] + <a href="#components">Components ([% ( ComponentParts.size ) %])</a> + </li> Indentation. diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl index 105da508c7..2df0e1b3b4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl @@ -541,7 +541,6 @@ <xsl:value-of select="$partName" /> </xsl:if> </xsl:template> - </xsl:stylesheet> <!-- Stylus Studio meta-information - (c)1998-2002 eXcelon Corp. Dont do this please -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #391 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- [% IF count == 0 %] [% IF ( Koha.Preference('HTML5MediaEnabled') == 'staff' or Koha.Preference('HTML5MediaEnabled') == 'both' ) && HTML5MediaSets.size %] $('#bibliodetails').tabs("option", "active", $('#media_tab').index() ); [% ELSIF ComponentParts %] $('#bibliodetails').tabs("option", "active", $('#components_tab').index() ); [% END %] [% END %] What about indentation? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #390 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- 14 files changed, 322 insertions(+), 55 deletions(-) $showcomp variable naming; show_components better Changes XSLTParse4Display; no tests. (Yes, there is no, but there should be.) Code block if ($xslsyspref =~ m/Details/) { We are fetching components while we may not use them. Have the impression that the if inside the block should be incorporated into the main condition. installer/data/mysql/atomicupdate/bug_11175.perl Needs to be converted to new style +('ShowComponentRecords', 'nowhere', 'nowhere|staff|opac|both','In which record detail pages to show list of the component records, as linked via 773','Choice'), Should nowhere just be empty? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '21

22 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #389 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '21

21 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Took a first look here and I think we will need unit tests for the new sub in Holds.pm: can_change_branch_opac -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14300] siplogs do not record process IDs
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '21

21 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14300 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28306] New: Allow to query database with minimal memory footprint
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '21

21 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28306 Bug ID: 28306 Summary: Allow to query database with minimal memory footprint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au The goal is to be able to build a database handler (dbh) and to execute queries without loading unnecessary stuff. This will be useful to reduce memory usage of daemons that need to check the database periodically -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 26875] New: Allow printing of just one barcode
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '21

21 Oct '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 Bug ID: 26875 Summary: Allow printing of just one barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The new barcode batch printing tool from bug 7468 requires that one enter barcodes a "to" barcode higher than one's "from" barcode. That means you have to print at least 2 barcodes. It's be nice if the check was, instead, "to" must be greater than or equal to "from." -- You are receiving this mail because: You are watching all bug changes.

1 18