- Koha-bugs - lists.koha-community.org

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to David Nind from comment #24) Great feedback David, thanks for testing :) > 1. The link in the log viewer 'Object' column doesn't go to the actual > notice - it just lists the notices. This is because there are two ?? after > letter.pl (for example: > /cgi-bin/koha/tools/letter. > pl??op=add_form&branchcode=&module=members&code=A_NOTICE_2&lang=default) Good catch, fixed in the first QA follow-up. > 2. I'm not sure whether changes to the notice name should be logged or not - > if I change the notice name it doesn't show in the log. I'm therefore > assuming that only actual changes to the notice itself are logged. I didn't add logging for title changes at this time, but perhaps that could be added too.. I wasn't sure of the best format to take though and felt at the moment it was more important to expose the template changes diff view than record the title changes and lose the diff view. Perhaps a later followup bug :) > 3. The changes logged - I'm not sure whether this is the correct behaviour, > but assume it is: > . If I make a change to a notice, in the log viewer 'Info' column it > shows what it was before the change was made. > . If that is what is expected, then it is working - you can only compare > previous changes, but not to the current version of the notice. Oops, this is a mistake on my part, it should be the 'after' so we can do the comparison with current and prior. I've corrected this in the second QA follow-up. > 4. I could add new notices, the change was logged, and I didn't get the > error the Owen did in Comment 19, presumably because of the follow-up patch. Correct, that was the earlier follow-up :) > 5. Is it possible to add the notice code somewhere? Maybe in front of the > notice name in the log viewer's 'Object' column. Maybe a future enhancement? Done, added in the 'follow-up'. > 6. I was confused that there is already a 'Letter' module listed (before and > after the patch is applied). Is the 'Letter' module something different from > the 'Notices' module, or the same - I prefer notices as it matches up with > the name in the tools section. I hadn't even noticed the existing 'Letter' filtering.. when I dug into it, it seems that it's linked to the acquisitions claims emails. I wonder if we could rename it to 'Claims' in the UI to clarify it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116761|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117259&action=e… Bug 14233: [DO NOT PUSH] DBIC Schema File Update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117258&action=e… Bug 14233: (follow-up) Add notice code to log viewer -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #31 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117257&action=e… Bug 14233: (QA follow-up) Record updated content We should record the updated template, not the content prior to the update.. That way we can properly compare between versions to see the changes made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117256&action=e… Bug 14233: (QA follow-up) Fix typo in viewlog.tt We had a double ?? in the object link.. Thanks for spotting that David :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116760|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117255&action=e… Bug 14233: (follow-up) Fix for delete entire notice This fixes the overall notice delete option. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116674|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117254&action=e… Bug 14233: Allow comparing notice changes This patch adds the 'compare' option to the Notices logs. Test plan 1/ Make some changes to at least two different notices to trigger logs 2/ Go to the 'Log viewer' from 'Tools' and filter on 'Notices' 3/ Note, you can now see the 'Compare' checkbox option for these logs 4/ Select the checkbox on one of the notices and note that the results are now filtered by that specific notice. 5/ Select a second checkbox to expose the option to 'View comparison' 6/ Click 'View comparison' to see the 'Diff view' of the two notices. 7/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116673|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117253&action=e… Bug 14233: Add filtering of NOTICES type action logs to the logviewer This patch adds handling for the new 'NOTICES' type action_logs to the logviewer page. Test plan 1/ Add some 'Notice' action logs by adding a new notice or updateing an existing notice 2/ Go to the 'Log viewer' under 'Tools' 3/ Note you can filter by 'Notices' 4/ Confirm the changes you made appear in the logs and that the 'Object' field links back to the updated notice ready for editing. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116672|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117252&action=e… Bug 14233: Add logging to notice create/update/delete This patch adds the call to logaction to record when a notice is added or changed. Test plan 1/ Add a new notice and check a corresponding line appears in the action_logs table. 2/ Update a notice and check that a corresponding line appears in the action_logs table. 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116671|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117251&action=e… Bug 14233: Add 'id' field to `letter` table to allow linking To allow for 'object' linking from the action_logs table we need an int(11) identifier. This patch updates the letter table to add such a field as a replacement for the multi-field primary key and moves that key to a unique constraint. Test plan 1/ Run the database update 2/ Check that the 'letter' table now includes an 'id' primary key and 'letter_uniq_1' multi-field unique key 3/ Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0