- Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com --- Comment #35 from David Nind <david(a)davidnind.com> --- Testing notes (koha-testing-docker): - I was able to test the emails being sent by copying the HTML for the message from the database and pasting it into a Thunderbird email message (Insert > HTML) - everything looked okay to me. - I wasn't able to properly test the attachment, but I'm going to assume the code creates a valid iso2709 file for attaching, sending, and saving/viewing by the recipient. - There was some minor things I noticed with the email input forms (the ones that pop up after you click the email buttons in Koha) - the 'Comment' label for the input box follows directly after the email address input box. Depending on the width of the pop up window the label isn't aligned properly to the left, but this behaviour is the same as what it was before the patch was applied. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114582|0 |1 is obsolete| | --- Comment #34 from David Nind <david(a)davidnind.com> --- Created attachment 117237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117237&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17179] New: Add keyboard shortcuts to repeat (duplicate) a field, and cut text
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Bug ID: 17179 Summary: Add keyboard shortcuts to repeat (duplicate) a field, and cut text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl add two more keyboard shortcut commands to the list already available: Ctrl-R : Repeat or duplicate a field Ctrl-C : cut command (to be used with paste - Ctrl-V) -- You are receiving this mail because: You are watching all bug changes.

1 56

[Bug 7806] Don't use 0000-00-00 to signal a non-existing date
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Phil Ringnalda <phil(a)chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil(a)chetcolibrary.org --- Comment #10 from Phil Ringnalda <phil(a)chetcolibrary.org> --- (In reply to Jonathan Druart from comment #7) > It could be useful to know if production DBs still contain such values (?) I have 175 in items.replacementpricedate, looks like a chunk from the original import to this system, another chunk from importing 7 more libraries, then a chunk starting a couple weeks ago when we updated to 20.05, which apparently inserts 0000-00-00 when you mispaste your replacementprice into replacementpricedate's input. Not sure where else to look for 0000-00-00, though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27604] PatronSelfRegistrationLibraryList can be bypassed
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27604 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- And pushed to master for 21.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27715] Possibly SQL injection in virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '21

23 Feb '21

1 0

[Bug 27604] PatronSelfRegistrationLibraryList can be bypassed
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '21

23 Feb '21

1 0

[Bug 14233] Add logging support to notices and slips management
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '21

23 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com --- Comment #24 from David Nind <david(a)davidnind.com> --- I had a go at testing this and a few things I noted: 1. The link in the log viewer 'Object' column doesn't go to the actual notice - it just lists the notices. This is because there are two ?? after letter.pl (for example: /cgi-bin/koha/tools/letter.pl??op=add_form&branchcode=&module=members&code=A_NOTICE_2&lang=default) 2. I'm not sure whether changes to the notice name should be logged or not - if I change the notice name it doesn't show in the log. I'm therefore assuming that only actual changes to the notice itself are logged. 3. The changes logged - I'm not sure whether this is the correct behaviour, but assume it is: . If I make a change to a notice, in the log viewer 'Info' column it shows what it was before the change was made. . If that is what is expected, then it is working - you can only compare previous changes, but not to the current version of the notice. 4. I could add new notices, the change was logged, and I didn't get the error the Owen did in Comment 19, presumably because of the follow up patch. 5. Is it possible to add the notice code somewhere? Maybe in front of the notice name in the log viewer's 'Object' column. Maybe a future enhancement? 6. I was confused that there is already a 'Letter' module listed (before and after the patch is applied). Is the 'Letter' module something different from the 'Notices' module, or the same - I prefer notices as it matches up with the name in the tools section. Sorry about all the questions! Testing notes (using koha-testing-docker): - Apply patches and then updatedatabase, dbic, flush_memcached, restart_all - MySQL commands for database table checks in test plans: . koha-mysql kohadev . show columns from letter; . show index from letter; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26602] New: Datatables - Actions columns should not be exported
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '21

23 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Bug ID: 26602 Summary: Datatables - Actions columns should not be exported Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org th should contain the NoExport class to prevent these columns to be exported. -- You are receiving this mail because: You are watching all bug changes.

1 21