- Koha-bugs - lists.koha-community.org

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27772 [Bug 27772] Add a Koha::Patron->todays_checkins method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #68 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I've added a minor QA follow-up to pass patron language into GetPreparedLetter as expected. This is a long overdue enhancement and is great to see making it's way into Koha. I would love to see the database call moved into Koha::Patron as a method (->todays_checkins perhaps) and as such have a unit test associated with it.. but we can handle that in another bug. QA script is happy, no regressions found. Passing QA :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #67 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117250&action=e… Bug 12224: (QA follow-up) Ensure patron language is respected Things have moved on a bit since this code was first written, we now expect a 'lang' parameter passed into GetPrepparedLetter to allow for translated notices. Simple fix, so a quick QA follow-up will suffice :) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116489|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117249&action=e… Bug 12224: (follow-up) Loop old_issues with itemnumber Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116488|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117248&action=e… Bug 12224: (follow-up) Switching to TT notice Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116487|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117247&action=e… Bug 12224: (follow-up) Access old_issues table when editing notice This QA follow-up allows access to the old_issues table when editing the notice in Tools. Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116486|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117246&action=e… Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12224] Allow easy printing of patron check-in slip
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116485|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 117245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117245&action=e… Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Alexandra Speer <alexandra.speer(a)bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27715] Possibly SQL injection in virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '21

24 Feb '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0