- Koha-bugs - lists.koha-community.org

[Bug 13305] Fix tab order in cataloguing/item editor
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '20

21 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13305] Fix tab order in cataloguing/item editor
by bugzilla-daemon＠bugs.koha-community.org 21 Jan '20

21 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Owen Leonard from comment #2) > Is there any valid reason for having a tabindex value attached to any of > these fields? I would prefer a solution which removed 'tabindex="1"' from > the generated code rather than one which adds it. I have taken the time to think deeply on that and came to appreciate it :) Patch forthcoming finally. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97646&action=ed… Bug 7468: Use Modern::Perl Just a tiny coding guidelines fix. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97558|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97645&action=ed… Bug 7468: fix the export labels popup header When exporting a barcode range, the export popup should display "1 batch to export" instead of "0 batches to export". In this context, it can be considered a label batch and should be counted as such. To test: When clicking the "Print range" button, the popup should show "1 batch to export". Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97557|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97644&action=ed… Bug 7468: (follow-up) Add missing filters Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97556|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97643&action=ed… Bug 7468: (follow-up) fix label-edit-range template Edit the labels/label-edit-range.tt template to follow current standards : - Use footer javascript - Use bootstrap grid - Use jQuery Validation plugin for validation Also fixes breadcrumbs to be more specific. To test: Make sure the page looks correct and still works as expected. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97555|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97642&action=ed… Bug 7468: (follow-up) Make sure only integers are accepted as from/to values Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97554|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97641&action=ed… Bug 7468: Showing the error message according to the community interface patterns, fixing a javascript condition TEST PLAN++ 1) Apply all the patches 2) Connect to the intranet with an account with permissions to visit the "Tools" page 3) Go to /cgi-bin/koha/labels/label-home.pl . Either by entering the URL directly . OR, from the front page, by clicking "Tools", followed by the hyperlink "Label creator" under the "Catalog" section 4) Under the "+ New" button, a new option should be available: "Barcode range" 5) Fill the "From:" and the "To:" fields of the "Print barcode range" form . Keeping both fields at "0" should trigger a warning beside the first field: "*Cannot be smaller than 1" . If the value "From:" is greater the "To:" value, a warning should appear beside the second field: "*Cannot be smaller than the starting value" . Make sure the form doesn't let you enter non-numerical values . For a casual test, use "From: 1000" and "To: 1100" 6) After pressing the "Print Range" button, choose a template, a layout, and a starting position . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of 0pt, don't use it . All the default layouts should look alike, since we're only printing a barcode over a number, and not bibliographic information . Using a layout not defined as 'Barcode' will show a warning message 7) Clicking the "Export" button should lead to a second dialog window with a "Download as PDF" hyperlink. Clicking the link should prop up a download dialog box 8) Save the PDF locally, or simply open it, and make sure the options you used were taken into account Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97553|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97640&action=ed… Bug 7468: Add warning when range has non-existent barcodes + Added a warning when the user selects a range with some non-existent barcodes, and a layout without barcodes. This allows the user to print barcodes of items not in the database if he so desires, but will warn him if he tries to print only biblios (which results in missing entries or a blank page). Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 20 Jan '20

20 Jan '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97552|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 97639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97639&action=ed… Bug 7468: Fix 'false' message on Firefox It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand. Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0