- Koha-bugs - lists.koha-community.org

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193941|0 |1 is obsolete| | --- Comment #277 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 194569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194569&action=e… Bug 38365: Add content_security_policy section to koha-conf.xml To test: 1. xmllint --noout --nonet etc/koha-conf.xml; echo $? 2. Observe 0 Signed-off-by: David Cook <dcook(a)prosentient.com.au> Signed-off-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> Signed-off-by: David Cook <dcook(a)prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #276 from David Cook <dcook(a)prosentient.com.au> --- I was thinking more about Jonathan's problem... and I suspect that there's probably some ancestors that might only live in Lari and my git repos at this point, so I just tried applying everything on a different git repo and sure enough... so I'll try to rebase all that... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194422|0 |1 is obsolete| | --- Comment #275 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 194567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194567&action=e… Bug 38365: Add CSP nonces to all inline script and style tags -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #274 from David Cook <dcook(a)prosentient.com.au> --- Oops guess I should attach the new patch... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #273 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #271) > (In reply to Jonathan Druart from comment #265) > > (In reply to David Cook from comment #258) > > > (In reply to Jonathan Druart from comment #253) > > > > Ok, however I found more: > > > > Caught by the xt tests (and now by add_csp_nonces.pl as well) > > > > * t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt > > > > > > So this is an interesting one. I will upload a patch for this one, but it's > > > going to work differently to what you might expect. I'll explain more in my > > > response to your comment about cataloguing plugins. > > > > > > (To test this one, you'll want to run `prove > > > t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t`) > > > > xt/find-missing-nonce.t is still failing on this file then. Should we > > exclude it? > > I think that we should exclude it, since it's good at testing that > Koha::FrameworkPlugin is working correctly at this time. Hmm... I looked at adding an exclusion but not sure how we do it. If we change Koha::Devel::Files->ls_tt_files to exclude that test template, won't we be excluding it from other scripts perhaps should include it? It would be good to be able to provide runtime exceptions to ls_tt_files() and friends. What do you think, Jonathan? (It wouldn't be the end of the world if we did add a nonce to test_valuebuilder_popup.tt, but it probably is good to also be able to provide future exceptions anyway.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #272 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #267) > (In reply to Jonathan Druart from comment #265) > > (In reply to David Cook from comment #258) > > > (In reply to Jonathan Druart from comment #253) > > > > And those ones when testing the UI: > > > > * cataloguing/value_builder/* (oops, all cataloguing plugins are broken) > > > > We might need to adjust the xt test and add_csp_nonces.pl to caught those > > > > files as well. > > > > > > So these aren't actually broken. When I was first working on the patches, I > > > thought they would be, but the script tags are actually already re-written > > > by Koha/FrameworkPlugin.pm, so it adds the nonce to them. If you try out the > > > cataloguing plugins, they should all work without any violation reports. See > > > the patch labelled "Bug 38365: Fix nonce caching and add to framework plugin > > > scripts". > > > > I do see dozens of violations in the console when I edit a biblio: > > https://snipboard.io/X7OYJp.jpg > > I cannot clone a subfield. > And plugins don't work (tried with 100$a) Is this when you're in "report-only" mode or in "enabled" mode? If you're in "enabled" mode, then yeah you'll have a number of problems in the intranet/staff interface, since it is still using inline event handlers. (As I note in my above comment, the 100$a doesn't use a plugin. It uses an inline event handler. The plugins used by things like the leader and 008 are fine.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #271 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Jonathan Druart from comment #265) > (In reply to David Cook from comment #258) > > (In reply to Jonathan Druart from comment #253) > > > > > 7. When enabled, I see an error in the browser's console: > > > > > Content-Security-Policy: The page’s settings blocked the loading of a > > > > > resource (media-src) at data: because it violates the following directive: > > > > > “default-src 'self'” > > > > > > > > That's interesting. I'd like to hear more about this one. Were there > > > > additional details? I wonder if it had to do with audio when doing a > > > > checkout or something? > > > > > > No idea! There is nothing else! Don't you see it? > > > > Nope! I haven't been able to find it. I don't see it anywhere. Does it > > happen on a particular page? > > All pages: https://snipboard.io/if28Qu.jpg Yeah, I don't see that on mine: https://snipboard.io/GSboJW.jpg media-src is for <audio> and <video> elements, also even that violation message looks weird, although I see other people talking about it online. Do you have any browser plugins/extensions? I think something in your browser is injecting audio/video into your pages. > > > Ok, however I found more: > > > Caught by the xt tests (and now by add_csp_nonces.pl as well) > > > * t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt > > > > So this is an interesting one. I will upload a patch for this one, but it's > > going to work differently to what you might expect. I'll explain more in my > > response to your comment about cataloguing plugins. > > > > (To test this one, you'll want to run `prove > > t/db_dependent/Koha/Plugins/Valuebuilder_hooks.t`) > > xt/find-missing-nonce.t is still failing on this file then. Should we > exclude it? I think that we should exclude it, since it's good at testing that Koha::FrameworkPlugin is working correctly at this time. > > > And those ones when testing the UI: > > > * cataloguing/value_builder/* (oops, all cataloguing plugins are broken) > > > We might need to adjust the xt test and add_csp_nonces.pl to caught those > > > files as well. > > > > So these aren't actually broken. When I was first working on the patches, I > > thought they would be, but the script tags are actually already re-written > > by Koha/FrameworkPlugin.pm, so it adds the nonce to them. If you try out the > > cataloguing plugins, they should all work without any violation reports. See > > the patch labelled "Bug 38365: Fix nonce caching and add to framework plugin > > scripts". > > I do see dozens of violations in the console when I edit a biblio: > https://snipboard.io/X7OYJp.jpg So those are different violations unrelated to the nonces. Those are due to inline event handlers, and bug 38407 is for fixing those. If you try the cataloguing plugins for the leader and 008, they're fine. Same with the item editor. The "tag editor" for 100$a isn't using a cataloguing plugin. It's using an inline event handler. These inline event handlers need to be moved into <script> elements with nonces or moved into separate files. But that's what bug 38407 is for. > > I think an argument could be made for fixing them a different way... and you > > just reminded me of why I used an ENV variable initially. It was for this. > > When the plugins get launched the CGI context gets re-set which is why I > > lost the cached values, but the ENV variable would persist and the package > > level variable are fine. > > > > > Also wondering if this one won't require adjustment: > > > misc/devel/tidy.pl:172 $content =~ s#\n*( > > > *)<script>\n*#\n$1<script>\n#g; > > > > Yeah I guess so since it won't match. I've written a patch that will cover > > this (as well as a future where we have other attributes like type for ESM > > modules or use async or defer). > > Hum I've revert your patch and tried to see how it broke the tidy but it > didn't. All good but maybe this is no longer needed. Will keep in mind if > some tidy errors appear in the next weeks. I was wondering that too. That bit of tidying is just collapsing multiple new lines into a single new line, so I'm not sure it's that helpful? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '26

06 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #270 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #269) > (In reply to Lari Taskula from comment #268) > > (In reply to Jonathan Druart from comment #266) > > > Patch application failed for attachment 194449 [details] [review] [review] [review] - Bug > > > 38365: Make swagger-cli happy > > > > > > > > > failed: error: sha1 information is lacking or useless > > > (api/v1/swagger/definitions/csp_report.yaml). > > Hmm all patches apply cleanly for me, using git-bz. > > > > On top of c3cf41c275695d260c5397e7cfbd4cf83e60fa9c > > Yeah, I tried an apply yesterday of all the patches on main and it applied > cleanly. I'll take another look today though when I'm looking into the other > things. I would've sworn I was up-to-date on main, and I don't have any updates to fetch this morning, but it looks like I'm 52 commits behind somehow. Weird. I'll get fresh patches posted. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 38365] Add Content-Security-Policy HTTP header to HTML responses
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '26

05 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38365 --- Comment #269 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Lari Taskula from comment #268) > (In reply to Jonathan Druart from comment #266) > > Patch application failed for attachment 194449 [details] [review] [review] - Bug > > 38365: Make swagger-cli happy > > > > > > failed: error: sha1 information is lacking or useless > > (api/v1/swagger/definitions/csp_report.yaml). > Hmm all patches apply cleanly for me, using git-bz. > > On top of c3cf41c275695d260c5397e7cfbd4cf83e60fa9c Yeah, I tried an apply yesterday of all the patches on main and it applied cleanly. I'll take another look today though when I'm looking into the other things. -- You are receiving this mail because: You are watching all bug changes.

1 0