- Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #118 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I cannot test it, when I save a new patron with a guarantor I get No property new_guarantor_surname for Koha::Patron at /usr/share/perl5/Exception/Class/Base.pm line 73 When I click "Add Child", I land on a "Add patron (Adult)" page. I would suggest to request another signoff after the re-submission. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- - Are you sure we need the change to Koha::Object? - koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt [% To.json(data) %] must have the html filter - changes to opac-user.tt are wrong (not needed) - There are too many (unneeded) changes made to members/update-child.pl, it will conflict with bug 20226 (not blocker) - misc/cronjobs/j2a.pl transaction must be done using txn_begin/txn_commit/txn_rollback - C4::Installer::load_sql returned the following errors while attempting to load /home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_14570.sql: I do not know what the error is. - Charset/collate: relationship VARCHAR(100) COLLATE utf8_unicode_ci NOT NULL, => this is wrong - same in the atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77348&action=ed… Bug 14570: Remove double declaration of $patron in opac-user.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77347&action=ed… Bug 14570: Update schema files [Do Not Push] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77290|0 |1 is obsolete| | Attachment #77291|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77346&action=ed… Bug 14570: Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine <kmpeine(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #113 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #96) > > d. IMPORTANT - Should not we finally keep these fields and force the > > guarantors to be existing patrons? We could have only 1 "contact" and > > several guarantors. It seems that it will simplify a lot the code (for > > instance Koha::Patron->guarantors would return Koha::Patrons, and > > Koha::Patron::Relationship[s] would stay simple Koha::Object[s]) > > I'm going to have to ruminate on this and find out what the sponsors > requirements are. I like how it would simplify the code, but it would also > provide limitations that have already been overcome in the current patch set. What did you finally decide? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17539] New: t/db_dependent/Reserves.t is failing
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539 Bug ID: 17539 Summary: t/db_dependent/Reserves.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: lari.taskula(a)jns.fi QA Contact: gmcharlt(a)gmail.com 1..72 ok 1 - use C4::Reserves; ok 2 - CheckReserves Test 1 ok 3 - CheckReserves() include reserve_id in its response ok 4 - CheckReserves Test 2 ok 5 - CheckReserves Test 3 ok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary ok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary ok 8 - Item is correctly waiting ok 9 - Item is correctly priority 1 ok 10 - Item is correctly priority 2 ok 11 - GetWaiting got only the waiting reserve ok 12 - GetWaiting got the reserve for the correct borrower Undefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1852. # Looks like you planned 72 tests but ran 12. # Looks like your test exited with 255 just after 12. I went back in the version history until the test passed this point, and it seems issues began after commit bf1563e60b31244f4ea977eb84954fb8501ed59a from Bug 14610; this commit on top looks to be failing with error Undefined subroutine &C4::Circulation::GetItemnumberFromBarcode called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853. -- You are receiving this mail because: You are watching all bug changes.

1 33

[Bug 5598] More Granular Cloning Circulation & Fine Rules
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5598 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17767] New: Let Koha::Patron::Modification handle extended attributes
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Bug ID: 17767 Summary: Let Koha::Patron::Modification handle extended attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org This is actually needed in order to implement bug 13757, because the underlying code doesn't handle extended attributes. -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 11375] Improve patrons permissions display
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '18

31 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20813 -- You are receiving this mail because: You are watching all bug changes.

1 0