- Koha-bugs - lists.koha-community.org

[Bug 2000] separation of issuing & fines rules breaks defaults propagation
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2000 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20227 [Bug 20227] admin/smart-rules.pl should pass categorycode instead of branchcode -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #35) > [1] With reference to above comments: > >> Furthermore I would expect to have max_holds also under Default checkout, > >> hold and return policy. It seems consistent to add it also without a patron > >> category restriction. > > > That behavior is controlled by the maxreserves system preference. We should > > move that out of a syspref and into the circ rules. I'd be happy to do that > > on another bug but it's definitely out of the scope of this bug. > > Yes, sir. Please remove maxreserves on a new report. Note that you already > added code for that by putting max_holds in default_circ_rules. At this > moment it is actually not used by the interface. > > [2] See my earlier comment about introducing new DBIx constructions. No > blocker for now, but imo we should add a coding guideline. About 1 & 2: And I think that is what is wrong here. We should have default_circ_rules.max_holds on the interface, then call GetBranchBorrowerCircRule from CanItemBeReserved It sounds like a trivial change and so I think it should be added by this patch set. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #181 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- It would have been better to get another QA point of view but I am going push this patch set anyway, it has been waiting for too long. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20221] New: Fix for JavaScript error during checkout or holds patron search
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Bug ID: 20221 Summary: Fix for JavaScript error during checkout or holds patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19641 If you submit a patron name to the checkout form it will trigger a JavaScript error in the console because there is JS embedded in an include, circ-patron-search-results.inc. This JS should be moved so that it is included in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 20193] New: Label export displaying on never-ending webpage
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Bug ID: 20193 Summary: Label export displaying on never-ending webpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: claire_gravely(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org When trying to export a label batch, the pop up frame to display export options is not being correctly created. Instead the export information is at the bottom of a never-ending page. (Scrolling never reaches it). To reproduce: Go to Manage Label batches (label-manage.pl) and/or edit a batch (label-edit-batch.pl) and try to export. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #111 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #110) > Created attachment 71822 [details] [review] > Bug 12904: Add KOHA_VERSION to few more .css Pushed to master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #110 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71822&action=ed… Bug 12904: Add KOHA_VERSION to few more .css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Vinod <mishravk79(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mishravk79(a)gmail.com --- Comment #4 from Vinod <mishravk79(a)gmail.com> --- @Indranil, I will be the part of co-sponsor, trying to get some more very soon. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71802&action=ed… Bug 12001: Format DEBT correctly Before this patchset, DEBT was formatted in the module, now it should be done template-side. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71801&action=ed… Bug 12001: Prove that result are the same \o/ -- You are receiving this mail because: You are watching all bug changes.

1 0