- Koha-bugs - lists.koha-community.org

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- pply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8630 - Adlibris covers (OPAC minified CSS) Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/css/opac.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css error: Failed to merge in the changes. Patch failed at 0001 Bug 8630 - Adlibris covers (OPAC minified CSS) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8630---Adlibris-covers-OPAC-minified-CSS-2gtmVc.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- There is a conflict with the CSS files, Aleisha, could you fix please? Would it be safe to leave the first patch off and then regenereate opac.css from the lst one? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Trying to test :) - Nothing found in code review. - Database update works nicely. Not OK: - QA test tools give some bad results: FAIL Koha/Schema/Result/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon OK sysprefs_order FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns OK git manipulation FAIL spelling OK tt_valid OK valid_template - On the /cgi-bin/koha/tools/signs.pl the datatable is broken (next page, etc.) - I think it would be nicer to use "SIGN" instead of "SIG" for the report group and include it in the sample values. - On point 16) of the test plan I receive an internal server error, so can't test the last steps: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1182. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Holds history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Summary|Reserves history for patron |Holds history for patron --- Comment #8 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #6) > Hi Josef, Hi Katrin, thanks for testing! > some small things: > - 'Reserves' should be 'holds' everywhere (see terminology page) should be fixed now > - Please be careful about capitalization (page title) Also fixed > - Should this be tied to intranetreadinghistory or not better be a new > separate pref? Or leave it with borrowers permission for now? > + [% IF ( CAN_user_borrowers ) %] > + [% IF ( intranetreadinghistory ) %] I thought about that an I think history of holds is very similar as history of checkouts... it's kind of part of checkouts... so I tied id with existing preference. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Reserves history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67730|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 67807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67807&action=ed… Bug 14919: Add holds history for patron Test plan: 0) Have a patron with some current and old reserves 1) Go to patron circulation page 2) Notice, there is new item called "Holds history" in the left circulation menu 3) Go to this page and confirm the data on this page are OK, and that ui does behave as expected 4) Go to adminitration, columns setting, try to change the setting for holdshistory table and confirm it is taken into account on holds history page -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13359] provide virtual-mysql-server Depends On to facilitate alternate mysql implementations
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13359 Pablo AB <pablo.bianchi(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi(a)gmail.com --- Comment #6 from Pablo AB <pablo.bianchi(a)gmail.com> --- JFTR, on Koha 17.05 over Ubuntu 16.04 is a good idea to use mariadb-server instead of mysql[0]. apt-cache depends koha-common | grep mysql pipe flag (OR) reveals is a good idea to install mariadb-server *before* koha-common (thanks wizzyrea!). [0] https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14919] Reserves history for patron
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Josef, some small things: - 'Reserves' should be 'holds' everywhere (see terminology page) - Please be careful about capitalization (page title) - Should this be tied to intranetreadinghistory or not better be a new separate pref? Or leave it with borrowers permission for now? + [% IF ( CAN_user_borrowers ) %] + [% IF ( intranetreadinghistory ) %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14647] Make the file name extension dynamic on exporting records
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer(a)bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply, please rebase! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] need an add option in marc modification templates
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think Update is not quite right as the option actually adds a field when it doesn't exist yet. I have used it to add items with different subfields a lot of times. Maybe it needs a better description - Add or update? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '17

07 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66830|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67802&action=ed… Bug 12365 - Notes for rules Lee Jamison <ldjamison(a)marywood.edu> rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. To test: Follow test plan in Comment 2 Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: macon lauren KohaCon17 <caballeromaricon(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0