- Koha-bugs - lists.koha-community.org

[Bug 14715] results per page setting for catalog search in staff client and opac
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply anymore, but this sounds like an interesting feature. Can someone rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14715: results per page setting for catalog search Using index info to reconstruct a base tree... M C4/Search.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl CONFLICT (content): Merge conflict in catalogue/search.pl Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14715: results per page setting for catalog search The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14715-results-per-page-setting-for-catalog-sea-nZTnir.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12902] Cronjob monitoring script, nagios3 compatible
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch still applies, but I don't know how to test this. Someone using Nagios maybe? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) Translations in mind, I suggest to make the message a bit more specific: Daily limit reached for patron > Daily hold limit reached for patron 2) If nothing is entered, it appears to default to 0 (instead of unlimited). So I think this will break existing installations. I'd suggest to copy the max holds total into max holds daily. 3) The tests are giving me trouble: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/59 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 65280 Tests: 56 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 59 tests but ran 56. Files=1, Tests=56, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.70 cusr 0.34 csys = 2.07 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #26 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Apart from the qa script this worked nicely, please fix! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #25 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67813&action=ed… Bug 14620: (follow-up) Link URL in system preference description -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61843|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 67812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67812&action=ed… Bug 14620: Contact information validations This patch adds a phone number validation by regex and centralizes different validation methods into Koha::Validation class. Introduces a new system preference, ValidatePhoneNumber, that takes a regular expression and uses it to validate phone numbers both client and server side. Unit tests to test: 1. prove t/db_dependent/Koha/Validation.t To test: 1. Apply the patches and run updatedatabase.pl to install the new system preference 2. Set system preference ValidatePhoneNumber to any regex you like (there is an example in the description of the preference) 3. Navigate to edit user contact informations in Staff client and OPAC. 4. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 5. Confirm that form will not be submitted and errors will be given. 6. Disable JavaScript and test that these errors will also be provided by the server. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- There are some complaints from the QA tool: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt FAIL forbidden patterns forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 233) OK git manipulation OK spelling OK tt_valid OK valid_template FAIL Koha/Validation.pm OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK pod coverage OK spelling OK valid Tests pass, database update is ok. Reattaching the rebased patch and a tiny follow-up with a suggestion for better system preference formatting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14620] Contact information validations
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Had a conflict, think I fixed it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14590] Validate messaging preferences
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, I had missed the dependency on bug 14620, but this also doesn't apply. Marking this one 'blocked' and the other 'doesn't apply'. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14590] Validate messaging preferences
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '17

08 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am sorry, this does no longer apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14590: Validate messaging preferences .git/rebase-apply/patch:663: trailing whitespace. print scalar ($destination eq "circ") ? error: sha1 information is lacking or useless (Koha/Validation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 14590: Validate messaging preferences The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14590-Validate-messaging-preferences-JMLoUs.patch >From eyeballing the code I was wondering if you only check 'primary email' and don't take AutoEmailPrimaryAddress into account? -- You are receiving this mail because: You are watching all bug changes.

1 0