- Koha-bugs - lists.koha-community.org

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 60952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60952 Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances Review of attachment 60952: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- Hi Blou, did a first code review. Additionally to the comments I made I noticed that the changes to kohastructure.sql are misssing for the column. ::: C4/Auth.pm @@ +523,4 @@ > OPACURLOpenInNewWindow => "" . C4::Context->preference("OPACURLOpenInNewWindow"), > OPACUserCSS => "" . C4::Context->preference("OPACUserCSS"), > OpacAuthorities => C4::Context->preference("OpacAuthorities"), > + OpacZ3950 => C4::Context->preference("OpacZ3950"), It's better to use the newer TT plugin method to check system preferences. I think this is done below, so this can possibly be reoved. ::: admin/z3950servers.pl @@ +66,4 @@ > $id = 0; > } elsif ( $op eq 'add_validated' ) { > my @fields=qw/host port db userid password rank syntax encoding timeout > + recordtype checked servername servertype sru_options sru_fields attributes opac attributes is added by another patch on bug 11297, so should be marked as a dependency or removed here. ::: installer/data/mysql/sysprefs.sql @@ +569,5 @@ > ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), > +('OPACZ3950','0','','Allow patrons to search for bibliographic records in other libraries via Z39.50.','YesNo') The list in sysprefs.sql should be sorted alphabetically to minimize conflicts. ::: installer/data/mysql/updatedatabase.pl @@ +13959,4 @@ > print "Upgrade to $DBversion done (Bug 16530 - Add a circ sidebar navigation menu)\n"; > } > > +$DBversion = "XXX"; This should be an atomicupdate in a separate file now instead of an entry in updatedatabase. @@ +13960,5 @@ > } > > +$DBversion = "XXX"; > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);"); Please specify where the new column should be added using AFTER/BEFORE column. @@ +13962,5 @@ > +$DBversion = "XXX"; > +if( CheckVersion( $DBversion ) ) { > + $dbh->do("ALTER TABLE z3950servers ADD COLUMN opac TINYINT(1);"); > + $dbh->do("INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) VALUES('OPACZ3950','0','','Allow patrons to search for bibliographic records in other libraries via Z39.50.','YesNo')"); > + print "Add opac column to z3950servers table.\nAdd OPACZ3950 preference.\n"; I am not sure if the \n work nicely in the HTML output of the web installer, maybe remove them. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt @@ +235,4 @@ > You searched for [% searchfield %] > [% END %] > <table id="serverst"> > + <thead><tr><th>Target</th><th>Hostname/Port</th><th>Database</th><th>Userid</th><th>Password</th><th>Preselected</th><th>Rank</th><th>Syntax</th><th>Encoding</th><th>Timeout</th><th>Record type</th><th>Attributes</th><th>OPAC</th><th>Options</th> Attributes are from bug 11297 - see above. ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +273,4 @@ > [% IF ( Koha.Preference( 'UseCourseReserves' ) == 1 ) %]<li><a href="/cgi-bin/koha/opac-course-reserves.pl">Course reserves</a></li>[% END %] > [% IF Koha.Preference( 'OpacBrowser' ) == 1 %]<li><a href="/cgi-bin/koha/opac-browser.pl">Browse by hierarchy</a></li>[% END %] > [% IF Koha.Preference( 'OpacAuthorities' ) == 1 %]<li><a href="/cgi-bin/koha/opac-authorities-home.pl">Authority search</a></li>[% END %] > + [% IF Koha.Preference( 'OpacZ3950' ) %]<li><span id="z3950searchOpac"><a target="_blank" href="#" >Z39.50 Search</a></span></li>[% END %] Not sure patrons will know what Z39.50 means, maybe we could find another label - "search other catalogs" maybe? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-z3950-search.tt @@ +52,5 @@ > + { label => "Keyword (any)", prop => 'srchany' }, > + { label => "LC call number", prop => 'lccall' }, > + { label => "Control no.", prop => 'controlnumber' }, > + { label => "Dewey", prop => 'dewey' }, > + { label => "Standard ID", prop => 'stdid' } Not sure if this syntax is translatable - needs testing. @@ +64,5 @@ > + <input type="hidden" name="op" id="op" value="do_search" /> > + <input type="hidden" name="biblionumber" value="[% biblionumber %]" /> > + <input type="hidden" name="frameworkcode" value="[% frameworkcode %]" /> > + <div id="search_params" class="span6 form-horizontal"> > + <h2>Search Parameters</h2> Should be: Search parameters (only first word capitalized in Koha) @@ +180,5 @@ > + <div class="row-fluid"> > + <div class="span4"> > + <div class="input-prepend input-append"> > + [% IF ( show_prevbutton ) %] > + <button class="btn" type="button" name="changepage_prev" onclick="$('#current_page').val([% current_page %]-1);$('#page_form').submit();">Previous Page</button> see above (Previous page) @@ +184,5 @@ > + <button class="btn" type="button" name="changepage_prev" onclick="$('#current_page').val([% current_page %]-1);$('#page_form').submit();">Previous Page</button> > + [% END %] > + <span class="add-on">Page [% current_page %] / [% total_pages %]</span> > + [% IF ( show_nextbutton ) %] > + <button class="btn" type="button" name="changepage_next" onclick="$('#current_page').val([% current_page %]+1);$('#page_form').submit();">Next Page</button> see above (Next page) ::: opac/opac-z3950-search.pl @@ +18,5 @@ > +# with Koha; if not, write to the Free Software Foundation, Inc., > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + > +use strict; > +use warnings; Should be: use Modern::Perl @@ +51,5 @@ > +my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ > + template_name => "opac-z3950-search.tt", > + query => $input, > + type => "opac", > + authnotrequired => 1, All pages should require auth if OpacPublic is set to Disable: authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #122 from Barton Chittenden <barton(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #121) > Hm, you could already do that with Apache I think? I thought of that, but Tomas pointed out that overdue_notices.pl doesn't run via apache... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #29 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 59831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59831 Bug 13952: Import and export authority types Review of attachment 59831: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=139…) ----------------------------------------------------------------- Just eyeballed this. ::: admin/import_export_authtype.pl @@ +18,5 @@ > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > + > +use strict; > +use warnings; The recommendation is use Modern::Perl; for the equivalent of these. @@ +26,5 @@ > +use C4::Auth qw/check_cookie_auth/; > +use C4::ImportExportFramework; > + > +my %cookies = CGI::Cookie->fetch(); > +my $authenticated = 0; The variable seems extraneous. Optimized, you could $auth_status //= q{}; and unless ($auth_status eq 'ok'). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Summary|Add a way to access files |Add a way to access files |from the intranet. |from the intranet --- Comment #69 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, this does no longer apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11317: Adds a page to access log files on the server from the intranet. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 11317: Follow up - Update ID to allow for permalinking Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. Applying: Bug 11317 - Rename config to 'accessdir' and fix qa Applying: Bug 11317 - Allows for multiple directories to be accessible Applying: Bug 11317 - Move file access under Tools and add specific permission fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11317 - Move file access under Tools and add specific permission The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11317---Move-file-access-under-Tools-and-add-s-D7DJsU.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Blocked by failed 11299 for now - hope we can get this moving soon! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #33 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Bouzid, I've tested the linking from the normal cataloguing editor and I really love it. So, some first feedback: There are 2 complaints from the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 710) FAIL authorities/authorities.pl FAIL spelling autority ==> authority Testing: When a match was found, it works nicely. Problems appear, when a new authority is to be added. - When I click on the plugin, instead of the normal search form, the add authority form opens, but the window is too small for the big form with the normal header on top, the navigation on top is 'messy' in the small screen. - It opened the wrong framework. I had 655 - so it should open Genre/Form, but instead it was Personal name. Maybe it would be worth to split this big patch. For now, have the automatic linking from cataloguing and leave the authority plugin untouched and deal with that later on? But maybe it's an easy fix. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Leaving final decisions about unit tests to QA team. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62939&action=ed… [SIGNED OFF] Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50420|0 |1 is obsolete| | Attachment #59448|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 62938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62938&action=ed… [SIGNED OFF] Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> New sign-off, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0