- Koha-bugs - lists.koha-community.org

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #6 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Benjamin Daeuber from comment #5) > (In reply to Christopher Brannon from comment #2) > > How are fines/fees taken into account with this action? Will associated > > fines be removed if claimed returned? Or will they be removed if marked as > > found? Will there be a preference for this? > > I think this covers your first questions: > > >Add system preference to ask ‘charge’, ‘don’t charge’, or ‘ask for confirmation’ when marking an item claimed returned This is good. Since we have started making the refund library specific, would you consider preferences under each library? > As to your second, I think we ought to treat it like we do lost items via > the system preference RefundLostItemFeeOnReturn > > Perhaps a system pref: RefundClaimReturnonLocate? As mentioned in my response above, this functionality was moved to the library configuration as individual preferences for each library. I would say it needs to be there. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10267] No error message when entering an invalid cardnumber
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |nick(a)bywatersolutions.com |ity.org | CC| |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #121 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, you could already do that with Apache I think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Tested this a bit and it appears to work ok. Some things found: 1) Doesn't work on item fields, would be nice to see it implemented there as well. Maybe for now we could add a hint to the setting to avoid confusion -"Currently not implemented for items"? 2) I marked 001 as important but it didn't trigger the message. I had to mark the subfield @ important to make it work. Would be nice if this could be fixed. 3) It would be nice to have some visual hint on the important fields and subfields, atm it seems only visible when saving a record. 4) At the moment it will first tell you about the mandatory missing and then after fixing those about the important ones. It would be nicer if the checks were done altogether, to avoid the repeated action. Marking failed QA for 1) and 2), but hopefully those should not be hard to fix! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 02 May '17

02 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Barton Chittenden <barton(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton(a)bywatersolutions.com --- Comment #120 from Barton Chittenden <barton(a)bywatersolutions.com> --- The other place that this feature is likely to be used is in large libraries which keep a test server in place... these libraries tend to be *very* sensitive to sending out large numbers of emails to patrons. As such, I think that it should be possible to override the syspref using a line in koha-conf.xml, so that libraries can load their production database into a test server, without having to manually re-set the syspref to make them safe. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Benjamin Daeuber <bdaeuber(a)cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber(a)cityoffargo.com --- Comment #5 from Benjamin Daeuber <bdaeuber(a)cityoffargo.com> --- (In reply to Christopher Brannon from comment #2) > How are fines/fees taken into account with this action? Will associated > fines be removed if claimed returned? Or will they be removed if marked as > found? Will there be a preference for this? I think this covers your first questions: >Add system preference to ask ‘charge’, ‘don’t charge’, or ‘ask for confirmation’ when marking an item claimed returned As to your second, I think we ought to treat it like we do lost items via the system preference RefundLostItemFeeOnReturn Perhaps a system pref: RefundClaimReturnonLocate? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Took a quick look at the code of the patches too: 1) There is an atomicupdate for adding a new permission edit_digital_signs, but no corresponding change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc 2) Maybe a merge issue, but sysprefs.sql removes 2 existing system preferences and doesn't add the new ones? 3) There is a comment about YUI - maybe that can just be thrown out? + // prepare DOM for YUI Toolbar 4) the borrow permission is used in opac-signs.pl but has since been removed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The QA scripts are pointing out some issues with these patches: FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 1 simicolon found instead of comma at line 3 simicolon found instead of comma at line 2 OK sysprefs_order FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table sign_streams does not have the current charset collate (see bug 11944) The table signs_to_streams does not have the current charset collate (see bug 11944) The table signs does not have the current charset collate (see bug 11944) OK git manipulation OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 407) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 441) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 227) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 86) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 87) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 226) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 442) OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 468) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 561) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 67) forbidden pattern: simple-quote string (line 464) forbidden pattern: simple-quote string (line 448) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 465) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 462) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 70) forbidden pattern: simple-quote string (line 478) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 69) OK git manipulation FAIL spelling initilize ==> initialize OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid FAIL tools/signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 01 May '17

01 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #119 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Katrin Fischer from comment #107) > Looking at this I am wondering if it wouldn't be better to implement the > fallback to the central email address in Koha/Email.pm. It also takes care > of other fallbacks like the reply-to addresses. > It could avoid changes in some of the files and put things in a central spot. I am still confused about having so much duplicated code if we could just override the To => $params->{to} in Koha::Email? What am I missing? Can you please explain why this other approach was taken? -- You are receiving this mail because: You are watching all bug changes.

1 0