- Koha-bugs - lists.koha-community.org

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188006|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189259&action=e… Bug 3492: (follow-up) Remove last reservefee references Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188005|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189258&action=e… Bug 3492: Modernize hold fee system and migrate to circulation rules This commit completely modernizes the hold fee system by migrating from the deprecated categories.reservefee column to the circulation rules framework and implementing modern Koha::Objects patterns. WHAT CHANGED: 1. MIGRATION TO CIRCULATION RULES: - Moved hold fees from categories.reservefee to circulation_rules table - Added database migration script with atomic update - Maintains existing fee amounts during migration - Provides rule hierarchy: category+itemtype+branch specific rules 2. NEW SYSTEM PREFERENCE: TitleHoldFeeStrategy - Options: highest, lowest, most_common - Addresses inconsistent title-level hold fees when items have different fees - Default: 'highest' (safest approach for library revenue) 3. MODERN Koha::Objects API: - Koha::Item->holds_fee($patron): Calculate fee for specific item - Koha::Hold->calculate_hold_fee(): Enhanced item/title-level logic - Koha::Hold->should_charge($stage): Centralized charging logic - Koha::Hold->charge_hold_fee(): Modern fee charging with proper accounting - Removed C4::Reserves::GetReserveFee and ChargeReserveFee 4. ENHANCED FUNCTIONALITY: - Proper ReservesControlBranch logic (patron home vs item home library) - Complete HoldFeeMode implementation (placement/collection/not_always) - Clear OPAC messaging with "You will be charged..." commitment - Comprehensive test coverage for all fee scenarios 5. TECHNICAL IMPROVEMENTS: - Object-oriented design following Koha patterns - Proper error handling and edge case management - Modern test structure with comprehensive coverage - Clean separation between fee calculation and charging TEST PLAN: A) MIGRATION AND SETUP: 1. Apply all patches and run database update 2. Verify existing hold fees migrated to circulation rules: - Administration > Circulation and fine rules - Previous categories.reservefee values now in "Hold fee" column 3. Confirm old categories.reservefee column no longer used B) BASIC FEE CALCULATION: 1. Set up patron categories with different hold fees in circulation rules 2. Create items with different item types, each with different hold fees 3. Test item-level holds charge correct fees based on specific item 4. Test title-level holds use TitleHoldFeeStrategy preference C) TITLE-LEVEL HOLD STRATEGIES: 1. Set TitleHoldFeeStrategy to "highest": - Create title with items having fees $1.00, $2.00, $3.00 - Verify title-level holds charge $3.00 2. Set TitleHoldFeeStrategy to "lowest": - Verify same title charges $1.00 3. Set TitleHoldFeeStrategy to "most_common": - Add multiple items with $2.00 fee - Verify title-level holds charge $2.00 (most common) D) HOLDFEEMODE PREFERENCES: 1. Set HoldFeeMode to "any_time_is_placed": - Place holds and verify immediate fee charging - Check patron account for correct hold fee debits 2. Set HoldFeeMode to "any_time_is_collected": - Place holds, verify no immediate charges - Check out items to patron, verify fee charged on collection 3. Set HoldFeeMode to "not_always": - With available items: verify no fee charged - With all items checked out but no other holds: verify no fee - With all items checked out and other holds exist: verify fee charged E) RULE HIERARCHY TESTING: 1. Set different fees for different category/itemtype/branch combinations 2. Verify most specific rule applies: - Branch + Category + ItemType (most specific) - Category + ItemType - Category only (most general) 3. Test with different patron categories and item types F) USER INTERFACE TESTING: 1. OPAC interface: - Verify "You will be charged..." messages display correct amounts - Test both item-level and title-level hold fee messages - Confirm fees match actual charges in patron account 2. Staff interface: - Place holds for patrons and verify fee calculations - Check Administration > Circulation rules interface works correctly G) EDGE CASES AND ERROR HANDLING: 1. Test $0.00 fees (no charge scenarios) 2. Test patrons with no applicable fee rules (should default to $0.00) 3. Test items with no holdable copies (should return $0.00) 4. Test invalid/missing itemtypes or categories 5. Test holds on biblios with no items H) REGRESSION TESTING: 1. Verify existing hold placement workflows unchanged 2. Check patron account charging remains accurate 3. Confirm OPAC and staff interfaces display correctly 4. Test that existing holds continue to work properly I) UNIT TESTS: Run the following test suites to verify functionality: - prove t/db_dependent/Koha/Hold.t - prove t/db_dependent/Koha/Item.t - prove t/db_dependent/Reserves.t - prove t/db_dependent/Circulation.t BACKWARDS COMPATIBILITY: - All existing functionality preserved - Hold fee amounts maintained during migration - Existing workflows continue unchanged - Legacy code updated to use new API seamlessly Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188004|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189257&action=e… Bug 3492: Remove from patron categories admin Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188003|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189256&action=e… Bug 3492: Add hold fees to circulation rules system This commit integrates hold fee configuration into the main circulation rules system, providing granular control over hold fees based on patron category, item type, and branch combinations. Changes: - Add hold_fee as a new circulation rule type with full scope support - Remove deprecated reservefee column mapping from Koha::Patron::Category - Integrate hold fee input into the circulation rules admin interface - Add hold fee column to the main circulation rules matrix - Enable proper rule hierarchy resolution for hold fees Hold fees can now be configured at multiple levels with automatic fallback handling following standard circulation rule patterns. Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188002|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189255&action=e… Bug 3492: DBIC Update Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3492] Move hold fee setting into circulation rules
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3492 Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188001|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 189254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189254&action=e… Bug 3492: Database migration for hold fees to circulation rules This commit adds the database migration to move hold fee configuration from patron categories to circulation rules, providing more granular control over hold fees based on patron category, item type, and branch. The migration: - Creates circulation rules for existing categories.reservefee values - Removes the deprecated reservefee column from categories table Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: Jackie Usher <jackie.usher(a)westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 40778] New: Manage, upgrade and audit npm packages in a structured manner
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40778 Bug ID: 40778 Summary: Manage, upgrade and audit npm packages in a structured manner Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: paul.derscheid(a)lmscloud.de QA Contact: testopia(a)bugs.koha-community.org This bug is meant to collect things that need to be done to safely manage, upgrade and audit npm packages in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 41213] New: 500 Error: The amount collected from the patron is higher than the amount to be paid
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41213 Bug ID: 41213 Summary: 500 Error: The amount collected from the patron is higher than the amount to be paid Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: eric(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 189247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189247&action=e… Showing the amount outstanding, payment, and tendered amounts To recreate: 1. Create a manual invoice 2. Make a payment on the invoice BUT: 1. Set the "amount to be paid" to be less than the total outstanding 2. Set the Amount Tendered to be more than what is being paid The "Change to be given" value is correct, but when you confirm the action you get a 500 error and the payment is not tracked in the accountlines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 39219] New: Error when issuing a refund from the transaction table
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '25

07 Nov '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39219 Bug ID: 39219 Summary: Error when issuing a refund from the transaction table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: - Create a manual invoice: $10.00 - Pay using the pay button in the transactions table: $1.00 - Now issuing a refund explodes into: Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Amount to payout (3.00) is higher than amountoutstanding (0)' at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10